From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by mx.groups.io with SMTP id smtpd.web12.8819.1651569267814130931 for ; Tue, 03 May 2022 02:14:27 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=aXJ0vKaN; spf=pass (domain: kernel.org, ip: 139.178.84.217, mailfrom: ardb@kernel.org) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 3059E6135C for ; Tue, 3 May 2022 09:14:27 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 992BEC385B0 for ; Tue, 3 May 2022 09:14:26 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1651569266; bh=BKEBQM/884kzLZL1R5NDikzS6t9BUVRd2XmrwoC7Ej0=; h=References:In-Reply-To:From:Date:Subject:To:Cc:From; b=aXJ0vKaN8bUN/66f5lCpn9Nljo80rHMjCl0IftEUCGFRNOHxZURXLsdT70/fWS8ut Ymnws3p1sme1YIZGgjXpoaG9py0+okpXEUk380Y7D+rX+nHoZvgDKzX5y4iEmYiO0+ Bu4ALOaHdoH1yX30h0ZJI7om8K9Y4xaGITOh7ifX1fDdy2zdmtpxg2JrvcAhMFzk3R QKmtODxXGJ+f1D5JmSAlAnZgydUINcuyy/GRD58ij+bpf3gJbxYjGbH0dhNKc8kOQS QiqVqV4TKSK6OPoWDyuP5b3R1RVFj0Kni+WB7zM0M9JQ/Q5SBmgx1WT8P1aZ3S59Fo 8LzlKEhzeVnxg== Received: by mail-oa1-f52.google.com with SMTP id 586e51a60fabf-ed8a3962f8so6554731fac.4 for ; Tue, 03 May 2022 02:14:26 -0700 (PDT) X-Gm-Message-State: AOAM531ArnupofIOvF6Rjui2/3VDirUWFMnQFLjZOgoo/NeXpFCZ+77z PM4VjgEk8QOYzNAm1j0mGoakvMEKyqCII0NSX0c= X-Google-Smtp-Source: ABdhPJwHSuYAT9Et5gM8wKyVSQs+3Qi6A8YpEEhGAMirf7E4TpT+SUNbcuFFHpO3h6ansDMlInN2b1eZ7IrrFnLZ15k= X-Received: by 2002:a05:6870:b4a4:b0:e9:4fdc:8ce with SMTP id y36-20020a056870b4a400b000e94fdc08cemr1373127oap.126.1651569265734; Tue, 03 May 2022 02:14:25 -0700 (PDT) MIME-Version: 1.0 References: <20220411011659.191390-1-rebecca@bsdio.com> <9de1de3f-b14b-5671-878d-7d2799a71934@bsdio.com> In-Reply-To: <9de1de3f-b14b-5671-878d-7d2799a71934@bsdio.com> From: "Ard Biesheuvel" Date: Tue, 3 May 2022 11:14:14 +0200 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH 0/3] ArmPlatformPkg: Fix Scripts/Ds5 debugging and Makefile To: Rebecca Cran Cc: edk2-devel-groups-io , Leif Lindholm , Ard Biesheuvel Content-Type: text/plain; charset="UTF-8" On Wed, 20 Apr 2022 at 02:43, Rebecca Cran wrote: > > Could I get some reviews on this please? > Merged as #2849 Thanks, > > -- > > Rebecca Cran > > > On 4/10/22 19:16, Rebecca Cran wrote: > > I ran into some problems debugging EDK2 code using Development Studio with > > the files under ArmPlatformPkg/Scripts and these patches fix them. > > > > I'm using Arm Development Studio 2021.2 and not DS-5, so I'm not sure if > > these changes would break things for people using the older environment. > > > > Rebecca Cran (3): > > ArmPlatformPkg: Fix error message in Scripts/Ds5/edk2_debugger.py > > ArmPlatformPkg: Fix target initialisation in cmd_load_symbols.py > > ArmPlatformPkg: Fix EDK2_DSC check in Scripts/Makefile > > > > ArmPlatformPkg/Scripts/Ds5/cmd_load_symbols.py | 5 ++--- > > ArmPlatformPkg/Scripts/Ds5/edk2_debugger.py | 2 +- > > ArmPlatformPkg/Scripts/Makefile | 2 +- > > 3 files changed, 4 insertions(+), 5 deletions(-) > >