From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by mx.groups.io with SMTP id smtpd.web09.22468.1628514538492763713 for ; Mon, 09 Aug 2021 06:08:58 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=Nn8JTDWq; spf=pass (domain: kernel.org, ip: 198.145.29.99, mailfrom: ardb@kernel.org) Received: by mail.kernel.org (Postfix) with ESMTPSA id 3400F60F93 for ; Mon, 9 Aug 2021 13:08:57 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1628514537; bh=ZO99efp2KLXUPCBXRmE1r0DYJ/o6PIvAB04Ae4zCjhQ=; h=References:In-Reply-To:From:Date:Subject:To:From; b=Nn8JTDWq5J3PE35Fqba75QP1S3v99k81LlScSq3ykRk74bqB3+/GaDOj2Kfsabjy2 kywZ9Nx8ydZZGV0oBWBEdCHs2aTjKsT9BidSMGUgZ1wS+Ys9V0RnOghcqNkuua//T5 3xpfPWwi4fLe3Q5KO52y5T6+OixAneA+tA9R0FaV00UdmeT/Iwx1BtKyA3Gytfybym X5RZUbsAuWP9kWNg+pds3IPGrbUK7+2IW7lDpptAO4zL1dNIy9s4pjzMbzSc9Yn2jm LeKGWVrkUFJFhh7IkpvonMJPWHfUjMX/3oGmVhDWwd7IY6Ow7mNC1YzUh9VDevgZJx M3espPH1T5DkQ== Received: by mail-oi1-f177.google.com with SMTP id s13so14105492oie.10 for ; Mon, 09 Aug 2021 06:08:57 -0700 (PDT) X-Gm-Message-State: AOAM532LnaofARFxo34PAmkQR2d4609Z5wUgjuI5wGpXselumobzr7jM 2M2pZA8kVbnRCBTsVZNWbspUDEmGYwgWREFUKkM= X-Google-Smtp-Source: ABdhPJx4xnyabD3+VEMd00H3YKtsyAKp6/V6HKfu1pE243WTjbo0IriundsDsSenxKMCiMePB9CGaOglz5zQzeWziKc= X-Received: by 2002:aca:ea54:: with SMTP id i81mr4419647oih.174.1628514536602; Mon, 09 Aug 2021 06:08:56 -0700 (PDT) MIME-Version: 1.0 References: <20210728020232.127332-1-chris.willing@linux.com> <20210728020232.127332-2-chris.willing@linux.com> In-Reply-To: <20210728020232.127332-2-chris.willing@linux.com> From: "Ard Biesheuvel" Date: Mon, 9 Aug 2021 15:08:45 +0200 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [edk2-devel] [PATCH 1/1] OvmfPkg PlatformBootManagerLib: Move TryRunningQemuKernel() To: edk2-devel-groups-io , chris.willing@linux.com Content-Type: text/plain; charset="UTF-8" On Wed, 28 Jul 2021 at 04:18, Christoph Willing wrote: > > Ref: https://bugzilla.tianocore.org/show_bug.cgi?id=3504 > > This change ensures that PlatformBdsConnectSequence() is run > before TryRunningQemuKernel(). > > It reverses commit a34a886962561f6d8550b2a1bb193798ca456431 which aimed > to improve UEFI boot time. Unfortunately that commit now results in boot > failure when using qemu's -kernel option, therefore rendering the -initrd > & -append options useless. > > Such failures are seen in all releases from edk2-stable201808 to > edk2-stable202105 as well as the master branch. > Can we pinpoint the failure condition a bit more? I heavily rely on -kernel for my local OVMF testing and other uses, and I am pretty sure it hasn't been broken for 3 years. So what else are you doing that triggers this failure? Is it related to boot order, the type of devices, etc? > The last releases which actually work correctly are vUDK2017 and vUDK2018 > as they don't contain the a34a88 commit. > > This change has been tested with edk2-stable201808, edk2-stable201811, > edk2-stable202105 as well as master (at 21/7/2021). It results in correct > booting using the -kernel option in all the test cases. No measurable > change in boot times was discernible compared with the unaffected vUDK2017 > & vUDK2018 releases. > > Signed-off-by: Christoph Willing > --- > OvmfPkg/Library/PlatformBootManagerLib/BdsPlatform.c | 8 ++++---- > 1 file changed, 4 insertions(+), 4 deletions(-) > > diff --git a/OvmfPkg/Library/PlatformBootManagerLib/BdsPlatform.c b/OvmfPkg/Library/PlatformBootManagerLib/BdsPlatform.c > index b0e9742937..f08ace87b3 100644 > --- a/OvmfPkg/Library/PlatformBootManagerLib/BdsPlatform.c > +++ b/OvmfPkg/Library/PlatformBootManagerLib/BdsPlatform.c > @@ -1517,14 +1517,14 @@ PlatformBootManagerAfterConsole ( > Tcg2PhysicalPresenceLibProcessRequest (NULL); > > // > - // Process QEMU's -kernel command line option > + // Perform some platform specific connect sequence > // > - TryRunningQemuKernel (); > + PlatformBdsConnectSequence (); > > // > - // Perform some platform specific connect sequence > + // Process QEMU's -kernel command line option > // > - PlatformBdsConnectSequence (); > + TryRunningQemuKernel (); > > EfiBootManagerRefreshAllBootOption (); > > -- > 2.32.0 > > > > ------------ > Groups.io Links: You receive all messages sent to this group. > View/Reply Online (#78261): https://edk2.groups.io/g/devel/message/78261 > Mute This Topic: https://groups.io/mt/84497355/5717338 > Group Owner: devel+owner@edk2.groups.io > Unsubscribe: https://edk2.groups.io/g/devel/unsub [ardb+tianocore@kernel.org] > ------------ > >