From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by mx.groups.io with SMTP id smtpd.web10.3699.1623486191716479407 for ; Sat, 12 Jun 2021 01:23:11 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=PNsy170s; spf=pass (domain: kernel.org, ip: 198.145.29.99, mailfrom: ardb@kernel.org) Received: by mail.kernel.org (Postfix) with ESMTPSA id C541A6120D for ; Sat, 12 Jun 2021 08:23:10 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1623486190; bh=tKNOCINxGZFX92WQdLTnVghEtkTYEUCebzGYt8EbFcM=; h=References:In-Reply-To:From:Date:Subject:To:Cc:From; b=PNsy170sWiJjSx1HNjLgx4Y7G1vojieHyP0jAYzBW9ULWQUoQ0W99OVNTZQIrazYQ l6QZeqXiTqgOXhSytZAeO4SdWbvKdceyrY2UdPKIzjPUrzlrwF44onb1Y5Se6tZPOf eWULWxS5r4MWPx3HSAPWHI1W3C/tK1r+ks1lrVfiJP3E+DjVHNWWBHTSOxl3sS8lLk 0jDCd5o5fwWIw96ZDpnC57D3HeJSdXZ1oy6MFTovz7cTxKzjVrybUjDkotGvydtJx/ aECIDd4f8Bq52ieU+WSAJUHRVM+JPuCOIEUEnrDOhJg4fRoGaNO2CynH2BUqO9zDH+ JGvRdHAbIyciQ== Received: by mail-oi1-f169.google.com with SMTP id a26so8454215oie.11 for ; Sat, 12 Jun 2021 01:23:10 -0700 (PDT) X-Gm-Message-State: AOAM5326W9+JOPkGhsKuy07gVo6iwWOSGKkQThqPkZFJ/4r9I5Ss9UHb +1hPa5pAPe9FmKPPkUL/AWuAeG4O6D4+4vkjXhM= X-Google-Smtp-Source: ABdhPJysZ725uBSEqBD+KT5+7RWRxycv0bh3Tvf+Fw5NFkxBqpp0GE4o30A2VNJQ4acw/6bRWsH92zptkXv32PSY9lU= X-Received: by 2002:aca:4343:: with SMTP id q64mr4866701oia.33.1623486189986; Sat, 12 Jun 2021 01:23:09 -0700 (PDT) MIME-Version: 1.0 References: <20210612034422.536-1-kuqin12@gmail.com> <20210612034422.536-2-kuqin12@gmail.com> In-Reply-To: <20210612034422.536-2-kuqin12@gmail.com> From: "Ard Biesheuvel" Date: Sat, 12 Jun 2021 10:22:57 +0200 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH v1 1/4] StandaloneMmPkg: Core: Spelling error in comment To: Kun Qin Cc: edk2-devel-groups-io , Ard Biesheuvel , Sami Mujawar , Jiewen Yao , Supreeth Venkatesh , Sean Brogan Content-Type: text/plain; charset="UTF-8" On Sat, 12 Jun 2021 at 05:44, Kun Qin wrote: > > From: Sean Brogan > > REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3445 > > This change fixed a misspelling that was not caught by spell check. > > Cc: Ard Biesheuvel > Cc: Sami Mujawar > Cc: Jiewen Yao > Cc: Supreeth Venkatesh > Cc: Sean Brogan > > Signed-off-by: Sean Brogan Hello Kun Qin, When you send patches to the list that were authored by someone else, you should add your own signoff, and add it last. (The signoff means that you attest that the patch is contributed under terms that are compatible with the open source licenses we support. The signoff has nothing to do with recognizing authorship, so even if someone else did most of the work, if that person is not involved in contributing these changes, their name does not need to appear in the Git log.) Sean is the author, which will be reflected in the git log anyway, so his signoff does not have any significance here, as he is not the one sending the patch to the public mailing list. Usually, I would fix up minor issues like these when merging the changes, but adding a signoff on someone else's behalf is the one thing I can never do. So please fix this up, and then you can add Reviewed-by: Ard Biesheuvel to the entire series. Thanks, > --- > StandaloneMmPkg/Core/Dispatcher.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/StandaloneMmPkg/Core/Dispatcher.c b/StandaloneMmPkg/Core/Dispatcher.c > index dbd5332fa9d3..7e4bf5e94025 100644 > --- a/StandaloneMmPkg/Core/Dispatcher.c > +++ b/StandaloneMmPkg/Core/Dispatcher.c > @@ -4,7 +4,7 @@ > Step #1 - When a FV protocol is added to the system every driver in the FV > is added to the mDiscoveredList. The Before, and After Depex are > pre-processed as drivers are added to the mDiscoveredList. If an Apriori > - file exists in the FV those drivers are addeded to the > + file exists in the FV those drivers are added to the > mScheduledQueue. The mFwVolList is used to make sure a > FV is only processed once. > > -- > 2.31.1.windows.1 >