From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by spool.mail.gandi.net (Postfix) with ESMTPS id B55FBAC0D9F for ; Wed, 6 Sep 2023 07:02:20 +0000 (UTC) DKIM-Signature: a=rsa-sha256; bh=FZ6VJ8pP0zP/ESOy5XDzUsa/QLHLg+vu1nmIqHJUNhQ=; c=relaxed/simple; d=groups.io; h=MIME-Version:References:In-Reply-To:From:Date:Message-ID:Subject:To:Cc:Precedence:List-Subscribe:List-Help:Sender:List-Id:Mailing-List:Delivered-To:Reply-To:List-Unsubscribe-Post:List-Unsubscribe:Content-Type:Content-Transfer-Encoding; s=20140610; t=1693983739; v=1; b=LIonNZDK9OtYqwlcuaHByH6+hGLkhA/9xrNq9VA6SeHkLd5h7cl8tsCCwuDqeMxvccw2ZqhH F6yAAomL9s5DTETiQBnxWJErYdlIQZI92H0olf/5GQzNEuMmJOp1L9PZbeA/QBNOlcYEXoe0rrC guYWyi03+3lBIBNkR1Hk9kE4= X-Received: by 127.0.0.2 with SMTP id KIxyYY7687511xXoXtx89M1D; Wed, 06 Sep 2023 00:02:19 -0700 X-Received: from sin.source.kernel.org (sin.source.kernel.org [145.40.73.55]) by mx.groups.io with SMTP id smtpd.web11.2883.1693983738339734916 for ; Wed, 06 Sep 2023 00:02:18 -0700 X-Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by sin.source.kernel.org (Postfix) with ESMTPS id 3E96BCE13AF for ; Wed, 6 Sep 2023 07:02:15 +0000 (UTC) X-Received: by smtp.kernel.org (Postfix) with ESMTPSA id 8230AC433C9 for ; Wed, 6 Sep 2023 07:02:13 +0000 (UTC) X-Received: by mail-lf1-f45.google.com with SMTP id 2adb3069b0e04-5009969be25so5183956e87.3 for ; Wed, 06 Sep 2023 00:02:13 -0700 (PDT) X-Gm-Message-State: ho6yjoirPOZ963J1SN8zrn6ix7686176AA= X-Google-Smtp-Source: AGHT+IFARt/7dv5tVtrZ2XeiUk+8f5rj/fcNNudwa8YcSCRPPQCpq6eIEfE4MuUA2q7evPqRwocZJdvIowESO3Yyy14= X-Received: by 2002:a05:6512:3101:b0:500:cb2b:866f with SMTP id n1-20020a056512310100b00500cb2b866fmr1245454lfb.30.1693983731477; Wed, 06 Sep 2023 00:02:11 -0700 (PDT) MIME-Version: 1.0 References: <20230901082117.1618901-1-yin.wang@intel.com> In-Reply-To: From: "Ard Biesheuvel" Date: Wed, 6 Sep 2023 09:02:00 +0200 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [edk2-devel] [PATCH v5 1/1] OvmfPkg: Fix Hii form name mismatch with EFI variable To: "Bi, Dandan" Cc: "Wang, Yin" , "devel@edk2.groups.io" , "Yao, Jiewen" , "Justen, Jordan L" , Gerd Hoffmann , Sunil V L , "Warkentin, Andrei" , "Dong, Eric" Precedence: Bulk List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,ardb@kernel.org List-Unsubscribe-Post: List-Unsubscribe=One-Click List-Unsubscribe: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-GND-Status: LEGIT Authentication-Results: spool.mail.gandi.net; dkim=pass header.d=groups.io header.s=20140610 header.b=LIonNZDK; dmarc=fail reason="SPF not aligned (relaxed), DKIM not aligned (relaxed)" header.from=kernel.org (policy=none); spf=pass (spool.mail.gandi.net: domain of bounce@groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce@groups.io On Wed, 6 Sept 2023 at 05:03, Bi, Dandan wrote: > > Reviewed-by: Dandan Bi > Thanks for the review Merging as #4789 Thanks, > > > Thanks, > Dandan > -----Original Message----- > From: Wang, Yin > Sent: Friday, September 1, 2023 4:21 PM > To: devel@edk2.groups.io > Cc: Wang, Yin ; Ard Biesheuvel ; Yao, Jiewen ; Justen, Jordan L ; Gerd Hoffmann ; Sunil V L ; Warkentin, Andrei ; Bi, Dandan ; Dong, Eric > Subject: [PATCH v5 1/1] OvmfPkg: Fix Hii form name mismatch with EFI vari= able > > The Hii form is named "MainFormState" while the EFI variable is named "P= latformConfig". > This discrepancy in names causes the following SCT cases to fail on > RiscVVirtQemu: > ExtractConfigConformance > ExtractConfigFunction > ExtractConfig_Func > > Cc: Ard Biesheuvel > Cc: Jiewen Yao > Cc: Jordan Justen > Cc: Gerd Hoffmann > Cc: Sunil V L > Cc: Andrei Warkentin > Cc: Dandan Bi > Cc: Eric Dong > Signed-off-by: Yin Wang > Acked-by: Gerd Hoffmann > Acked-by: Sunil V L > --- > v5: Re-organize commit message > v4: Update commit message about version history > > - aefcc918: Enhance ExtractConfig() to match UEFI specification, > adding check of whether " matches the GUID and name" > - 16acacf2: Fix Hii form name mismatch in ExtractConfig() > - This patch: Add one more fix for Hii form name mismatch > > v3: Gerd comments on v2 that caused issues may related to RISC-V specific= config. To address this separately, the patch was restored to v1, and deta= ils were added to the commit message. > > v2: Add two more changes which caused other two SCT Hii cases to fail. > > v1: Initial version > --- > OvmfPkg/PlatformDxe/Platform.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/OvmfPkg/PlatformDxe/Platform.c b/OvmfPkg/PlatformDxe/Platfor= m.c index cd3bfd554c..c32439683d 100644 > --- a/OvmfPkg/PlatformDxe/Platform.c > +++ b/OvmfPkg/PlatformDxe/Platform.c > @@ -279,7 +279,7 @@ ExtractConfig ( > // ConfigRequestHdr =3D HiiConstructConfigHdr ( = &gOvmfPlatformConfigGuid,- mVariableName,+= mHiiFormName, mImageHandl= e ); if (ConfigRequestHdr =3D=3D NULL) {-- > 2.34.1 > -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#108309): https://edk2.groups.io/g/devel/message/108309 Mute This Topic: https://groups.io/mt/101090614/7686176 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-