From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mail.kernel.org (mail.kernel.org [198.145.29.99])
 by mx.groups.io with SMTP id smtpd.web08.3990.1630408144517749677
 for <devel@edk2.groups.io>;
 Tue, 31 Aug 2021 04:09:04 -0700
Authentication-Results: mx.groups.io;
 dkim=pass header.i=@kernel.org header.s=k20201202 header.b=otpmcuVi;
 spf=pass (domain: kernel.org, ip: 198.145.29.99, mailfrom: ardb@kernel.org)
Received: by mail.kernel.org (Postfix) with ESMTPSA id A37DC60249
	for <devel@edk2.groups.io>; Tue, 31 Aug 2021 11:09:03 +0000 (UTC)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org;
	s=k20201202; t=1630408143;
	bh=WPDT9epxCNjuIDkWmtnqGf5/fgnAhYLsX7lqUmH3KMM=;
	h=References:In-Reply-To:From:Date:Subject:To:Cc:From;
	b=otpmcuVi+p+V/6499o1xsFpKUpn16i4sdw5p/vs1xiUgmoKyVym4dH4mXEe2gC45W
	 KUOkrYOcTIJCEgxLzeFzPM+/vWny58Zuj85c8qnNzJ2lKhOuqadbVDocKm3fI945NR
	 oTH9VrpxnSw6ONlxG2r0KQn7mnF3WHynQwd3cwIWrLcp8JlvmHy1Vkaw5rYSAI2Wvr
	 +iGdoGgKyBnfiaOlIkTitsNOzfwHSP1iMGp2A7yg7dCd2+subkux/ihbpNiYrzVUmd
	 iquDKNZhjNas+Rx0Q8fQx3yfluwwHkP3Raf4e+cPYYy1zrlEBS4baiTQApciQaAHqE
	 x9DJEM3xheVPw==
Received: by mail-ot1-f45.google.com with SMTP id x10-20020a056830408a00b004f26cead745so22204395ott.10
        for <devel@edk2.groups.io>; Tue, 31 Aug 2021 04:09:03 -0700 (PDT)
X-Gm-Message-State: AOAM530+QMLl/3PVIEiYPXXi6hmRZvWznmJ9OLk3K/a52xQO83NQhdXY
	/m0F7azyON2UuC+GlHEXrl75WSMywp1OCz7blAM=
X-Google-Smtp-Source: ABdhPJxicjXmEy7e0x/cX2BmdGyIeVRwJrSml/kGqRSyAkkRGeQDx9gBVCvTdnh6zYiaM997J1Gb9rSvIvsJ4xFuzUw=
X-Received: by 2002:a05:6830:444:: with SMTP id d4mr23096748otc.108.1630408143033;
 Tue, 31 Aug 2021 04:09:03 -0700 (PDT)
MIME-Version: 1.0
References: <20210831013115.23110-1-gary.lin@hpe.com>
In-Reply-To: <20210831013115.23110-1-gary.lin@hpe.com>
From: "Ard Biesheuvel" <ardb@kernel.org>
Date: Tue, 31 Aug 2021 13:08:52 +0200
X-Gmail-Original-Message-ID: <CAMj1kXHUHt=0+L7=ToY-WW1a7WgXeFisqn6oZHVjFuSUegLrvA@mail.gmail.com>
Message-ID: <CAMj1kXHUHt=0+L7=ToY-WW1a7WgXeFisqn6oZHVjFuSUegLrvA@mail.gmail.com>
Subject: Re: [edk2-devel] [RESEND PATCH v3 0/4] Fix OvmfXen boot failure due to s3 support state
To: devel@edk2.groups.io, gary.lin@hpe.com
Cc: Ard Biesheuvel <ardb+tianocore@kernel.org>, Jiewen Yao <jiewen.yao@intel.com>, 
	Jordan Justen <jordan.l.justen@intel.com>, Gerd Hoffmann <kraxel@redhat.com>, 
	Anthony Perard <anthony.perard@citrix.com>, Julien Grall <julien@xen.org>, 
	Jim Fehlig <jfehlig@suse.com>, Joey Li <jlee@suse.com>
Content-Type: text/plain; charset="UTF-8"

On Tue, 31 Aug 2021 at 03:31, Lin, Gary (HPS OE-Linux) <gary.lin@hpe.com> wrote:
>
> When using HVM Direct kernel boot with OvmfXen, it could fail at the
> S3BootScript due to the inconsistency between QemuFwCfgS3Enabled()
> and PcdAcpiS3Enable.
>
> This patch series initializes PcdAcpiS3Enable in
> . Besides, QemuFwCfgS3Enabled() is
> replaced with PcdAcpiS3Enable in several OVMF libraries to avoid the
> potential inconsistency.
>
> Ref: https://bugzilla.tianocore.org/show_bug.cgi?id=3573
>
> v3:
>   - Update the description per Anthony's suggestion
>   - Add the bugzilla links
>   - Move the QemuKernelLoaderFsDxe patch out of this patch series
>     and make it an independent patch
> v2:
>   - Amend the description and address "HVM Direct Kernel Boot"
>   - Add the comment for the conditional test of QemuFwCfgS3Enabled()
>   - Remove unused QemuFwCfgLib
>   - Update my email address
>
> Cc: Ard Biesheuvel <ardb+tianocore@kernel.org>
> Cc: Jiewen Yao <jiewen.yao@intel.com>
> Cc: Jordan Justen <jordan.l.justen@intel.com>
> Cc: Gerd Hoffmann <kraxel@redhat.com>
> Cc: Anthony Perard <anthony.perard@citrix.com>
> Cc: Julien Grall <julien@xen.org>
> Cc: Jim Fehlig <jfehlig@suse.com>
> Cc: Joey Li <jlee@suse.com>
>
> Gary Lin (4):
>   OvmfPkg/OvmfXen: set PcdAcpiS3Enable at initialization
>   OvmfPkg/LockBoxLib: use PcdAcpiS3Enable to detect S3 support
>   OvmfPkg/PlatformBootManagerLib: use PcdAcpiS3Enable to detect S3
>     support
>   OvmfPkg/SmmControl2Dxe: use PcdAcpiS3Enable to detect S3 support
>


Merged as #1933

Thanks,

>  OvmfPkg/Library/LockBoxLib/LockBoxDxeLib.inf        |  3 +--
>  .../PlatformBootManagerLib.inf                      |  1 +
>  OvmfPkg/SmmControl2Dxe/SmmControl2Dxe.inf           |  2 ++
>  OvmfPkg/XenPlatformPei/XenPlatformPei.inf           |  2 ++
>  OvmfPkg/Library/LockBoxLib/LockBoxDxe.c             |  4 +---
>  .../Library/PlatformBootManagerLib/BdsPlatform.c    |  2 +-
>  OvmfPkg/SmmControl2Dxe/SmmControl2Dxe.c             |  4 +---
>  OvmfPkg/XenPlatformPei/Platform.c                   | 13 +++++++++++++
>  8 files changed, 22 insertions(+), 9 deletions(-)
>
> --
> 2.31.1
>
>
>
> 
>
>