From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217])
 by mx.groups.io with SMTP id smtpd.web11.17821.1683726862767786521
 for <devel@edk2.groups.io>;
 Wed, 10 May 2023 06:54:22 -0700
Authentication-Results: mx.groups.io;
 dkim=pass header.i=@kernel.org header.s=k20201202 header.b=lP2+WVwL;
 spf=pass (domain: kernel.org, ip: 139.178.84.217, mailfrom: ardb@kernel.org)
Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140])
	(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
	(No client certificate requested)
	by dfw.source.kernel.org (Postfix) with ESMTPS id 4B99663172
	for <devel@edk2.groups.io>; Wed, 10 May 2023 13:54:22 +0000 (UTC)
Received: by smtp.kernel.org (Postfix) with ESMTPSA id B59D6C4339E
	for <devel@edk2.groups.io>; Wed, 10 May 2023 13:54:21 +0000 (UTC)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org;
	s=k20201202; t=1683726861;
	bh=6cSRABSXZgUN40c4IbspSeegLZqReXaAV/6JtCUDYYM=;
	h=References:In-Reply-To:From:Date:Subject:To:Cc:From;
	b=lP2+WVwLk3Z35YVrM/HEEvxwO7W9WOUdSKyu6Cha6QrdnRz8T8FuQLN47LS5pA2HS
	 6UacGix6zGuffghh4o41Dt++JE9AJ4mwSYfbtkV7VkUS+DDcDKpg7ud7qnvbWbz8gC
	 SZd2zeh9QsVeoeFFUTi4q+bTRDBnsHdlEM3XAvCbXSGeETYPwjuDJLQXUwHGYkIKgQ
	 zFeieXWBapiaDoZgCRszpHGACcxFxHRgyokHZlQuFLpfsXxvSdmB65RYp2bdKZoekM
	 wHa9qucY63+RxqB8F5ZoeDZSVr7tUUKJX6GNewjmar8kqiOwdBaFpWyrfgkX/Kt/oU
	 3VPHXzlAZnpjg==
Received: by mail-lj1-f175.google.com with SMTP id 38308e7fff4ca-2ac806f4fccso80680441fa.1
        for <devel@edk2.groups.io>; Wed, 10 May 2023 06:54:21 -0700 (PDT)
X-Gm-Message-State: AC+VfDwLrGOKC5KpvVkW+v2NVvP5788XyTkg8fESAnMk67KxIsTblG93
	PLYGFs2GpJxM0/3KZh5ge2Rt9czsp1eum+2m6Ks=
X-Google-Smtp-Source: ACHHUZ5hONKRAuuIIdmov0qId/WT7LroF7EvjH0vH2T8bq8xQSl6MnAMdikpeYy5Gn4Bw95rJSIFgiVAPceUzDTDZd8=
X-Received: by 2002:a2e:8ece:0:b0:2ad:85dd:f3a8 with SMTP id
 e14-20020a2e8ece000000b002ad85ddf3a8mr2128496ljl.30.1683726859783; Wed, 10
 May 2023 06:54:19 -0700 (PDT)
MIME-Version: 1.0
References: <20230510073358.79042-1-kraxel@redhat.com> <CAMj1kXEvG_Shq6egSXxxENALezzETBL1VMJh9bYY9UVvvUPSgA@mail.gmail.com>
 <CAMj1kXGSnK2O=R9d=eZs67iRQip+4sSKMS=9cm1JwU4HnhORkg@mail.gmail.com>
In-Reply-To: <CAMj1kXGSnK2O=R9d=eZs67iRQip+4sSKMS=9cm1JwU4HnhORkg@mail.gmail.com>
From: "Ard Biesheuvel" <ardb@kernel.org>
Date: Wed, 10 May 2023 15:54:08 +0200
X-Gmail-Original-Message-ID: <CAMj1kXHUQKLUR6X-+kxv0si6SLQm4WuQ03c+MkfbHWFgeTrQfQ@mail.gmail.com>
Message-ID: <CAMj1kXHUQKLUR6X-+kxv0si6SLQm4WuQ03c+MkfbHWFgeTrQfQ@mail.gmail.com>
Subject: Re: [edk2-devel] [PATCH 1/1] OvmfPkg/VirtioSerialDxe: fix RELEASE build error
To: devel@edk2.groups.io, kraxel@redhat.com
Cc: Pawel Polawski <ppolawsk@redhat.com>, Ard Biesheuvel <ardb+tianocore@kernel.org>, 
	Jordan Justen <jordan.l.justen@intel.com>, Oliver Steffen <osteffen@redhat.com>, 
	Jiewen Yao <jiewen.yao@intel.com>, Rebecca Cran <rebecca@bsdio.com>
Content-Type: text/plain; charset="UTF-8"

On Wed, 10 May 2023 at 11:18, Ard Biesheuvel <ardb@kernel.org> wrote:
>
> On Wed, 10 May 2023 at 09:39, Ard Biesheuvel <ardb@kernel.org> wrote:
> >
> > On Wed, 10 May 2023 at 09:34, Gerd Hoffmann <kraxel@redhat.com> wrote:
> > >
> > > EventNames is used to pretty-print debug log messages.
> > > Add #ifdef to only include it in debug builds.
> > > Fixes a clang build failure.
> > >
> > > Reported-by: Rebecca Cran <rebecca@bsdio.com>
> > > Signed-off-by: Gerd Hoffmann <kraxel@redhat.com>
> >
> > Queued up as #4381 - thanks.
> >
>
> This appears to break the build
>
> https://github.com/tianocore/edk2/pull/4381

Actually, looking at the code, I think the Clang diagnostic is highly
dubious here. The non-DEBUG code takes the ARRAY_SIZE() of EventNames,
and so the #ifdef will result in a compiler error.

I suppose we can work around this, but we might also just add
-Wunneeded-internal-declaration to the clang cflags for RELEASE