From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail05.groups.io (mail05.groups.io [45.79.224.7]) by spool.mail.gandi.net (Postfix) with ESMTPS id 8FD25AC1018 for ; Fri, 2 Aug 2024 08:46:22 +0000 (UTC) DKIM-Signature: a=rsa-sha256; bh=X/dhCF0caNFChqGi9RvCMmrLh+obHESYKw1LtFi8tgw=; c=relaxed/simple; d=groups.io; h=MIME-Version:References:In-Reply-To:From:Date:Message-ID:Subject:To:Cc:Precedence:List-Subscribe:List-Help:Sender:List-Id:Mailing-List:Delivered-To:Resent-Date:Resent-From:Reply-To:List-Unsubscribe-Post:List-Unsubscribe:Content-Type; s=20240206; t=1722588382; v=1; b=dzhWdjp8fJfECM29pB7oMtpqBw7gDwAxIV+8GqC8Wb4a3r/FkDeapA3rA6WUd7tBwA1ndHfH vI6EI/Dkq8E8AwYTJVR9owAuqPQvpeARQDTxhPNEl5mHsa9TEOPKlichtsS1jFRvZCbR+F4bEJA RjFGOSK023i3fzCjlszRWvwHsLHk9cYzP2NqE1QurCIQQnPBULtUlP5OXTwgDH/I1vqaUNGkHoK GrB5uAnVMc3RkcA4k6gJCw28+DlDai3rA+asFDjGFj0Ul5NffYBpmm/onlKDNXJW1cAG37eZYtF XvF2IZWvWZaeRxoct2hr6QPqY9rooU1Q+JRcEQgH55BKg== X-Received: by 127.0.0.2 with SMTP id KTGvYY7687511xoWAO5zVPsy; Fri, 02 Aug 2024 01:46:20 -0700 X-Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by mx.groups.io with SMTP id smtpd.web11.88546.1722588375246936982 for ; Fri, 02 Aug 2024 01:46:15 -0700 X-Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by dfw.source.kernel.org (Postfix) with ESMTP id 87CF3629B5 for ; Fri, 2 Aug 2024 08:46:14 +0000 (UTC) X-Received: by smtp.kernel.org (Postfix) with ESMTPSA id 3FBCCC4AF0B for ; Fri, 2 Aug 2024 08:46:14 +0000 (UTC) X-Received: by mail-lf1-f53.google.com with SMTP id 2adb3069b0e04-52efe4c7c16so11503844e87.0 for ; Fri, 02 Aug 2024 01:46:14 -0700 (PDT) X-Gm-Message-State: BqpHvJbFGdbKHPKvkh86SiS5x7686176AA= X-Google-Smtp-Source: AGHT+IGqq0rYF73HUUa55dXZ0kSUIYZykJ4oAtXO+JirNDjHMjs4oFW8ghXbGCJTribqIzwNXn7RzLACpGTcNpqOJzI= X-Received: by 2002:a05:6512:33c3:b0:52f:6f49:3593 with SMTP id 2adb3069b0e04-530bb39dcdemr1565724e87.34.1722588372573; Fri, 02 Aug 2024 01:46:12 -0700 (PDT) MIME-Version: 1.0 References: In-Reply-To: From: "Ard Biesheuvel" Date: Fri, 2 Aug 2024 10:46:01 +0200 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [edk2-devel] [RFC] Move CompilerIntrinsicsLib and ArmSoftFloatLib to MdePkg To: Oliver Smith-Denny Cc: "devel@edk2.groups.io" , Leif Lindholm , Sami Mujawar , Michael Kinney , Liming Gao , Zhiguang Liu Precedence: Bulk List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Resent-Date: Fri, 02 Aug 2024 01:46:15 -0700 Resent-From: ardb@kernel.org Reply-To: devel@edk2.groups.io,ardb@kernel.org List-Unsubscribe-Post: List-Unsubscribe=One-Click List-Unsubscribe: Content-Type: text/plain; charset="UTF-8" X-GND-Status: LEGIT Authentication-Results: spool.mail.gandi.net; dkim=pass header.d=groups.io header.s=20240206 header.b=dzhWdjp8; dmarc=fail reason="SPF not aligned (relaxed), DKIM not aligned (relaxed)" header.from=kernel.org (policy=none); spf=pass (spool.mail.gandi.net: domain of bounce@groups.io designates 45.79.224.7 as permitted sender) smtp.mailfrom=bounce@groups.io On Fri, 2 Aug 2024 at 00:39, Oliver Smith-Denny wrote: > > CompilerIntrinsicsLib and ArmSoftFloatLib add ARM/AARCH64 compiler > intrinsics and floating point functions required by OpenSSL, > respectively. CompilerIntrinsicsLib is used almost in every DSC that > builds ARM/AARCH64 and ArmSoftFloatLib is used by every DSC that builds > logic from OpenSSL. What's even worse: OpenSSL doesn't really use floating point at all - the only reason we need this is because there is some global double_t somewhere that records entropy or somesuch, but IIRC that code is not actually used. So perhaps we could add a hack in OpensslLib to work around this in one way or another for ARM only, and get rid of SoftFloatLib altogether. > Together these make almost every DSC have a > dependency on ArmPkg, which is odd and for a handful, MdeModulePkg, > EmbeddedPkg, and ShellPkg, namely, it is a circular dependency. > > There have been previous mailing list suggestions to move > CompilerIntrinsicsLib to MdePkg (possibly combining with other arch > intrinsics). I am not sure the end status of those conversations. By > moving these two libraries to MdePkg package, we accomplish a few > things: > > - Removing the circular dependency from MdeModulePkg and ShellPkg > (EmbeddedPkg has other ArmPkg dependencies) > > - Aligning MdePkg as the base package where baseline build and spec > dependencies are found with other industry standard behavior > > - Detangling ArmPkg and making ARM/AARCH64 more of a first class > citizen in edk2 instead of bolted onto the side > > There is no functional change here and the amount of work is light, but > I think it moves edk2 in the direction it wants to go, so I'm happy to > put up a PR for this, but I wanted to get feedback before I did so. This > aligns with similar efforts, such as moving more ARM/AARCH64 chipset > definitions to MdePkg from ArmPkg [1][2][3]. This also aligns to the > overall goal of deleting ArmPkg: > https://bugzilla.tianocore.org/show_bug.cgi?id=4121 > Intrinsics are tightly coupled with the toolchain, and so it would make sense for the basetools to provide them. Intrinsics are also -essentially- build once, run everywhere objects so I don't think we need the typical handling for them either, and we could just build them once when we build the basetools. -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#120210): https://edk2.groups.io/g/devel/message/120210 Mute This Topic: https://groups.io/mt/107675828/7686176 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io] -=-=-=-=-=-=-=-=-=-=-=-