From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by mx.groups.io with SMTP id smtpd.web10.8566.1614240510075850592 for ; Thu, 25 Feb 2021 00:08:30 -0800 Authentication-Results: mx.groups.io; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=IIHfps/k; spf=pass (domain: kernel.org, ip: 198.145.29.99, mailfrom: ardb@kernel.org) Received: by mail.kernel.org (Postfix) with ESMTPSA id E9C0664EDB for ; Thu, 25 Feb 2021 08:08:28 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1614240509; bh=XIYQGJ1R/Ga99hyKPfrLZOX2QC+2xSNHoEtq9vnacHI=; h=References:In-Reply-To:From:Date:Subject:To:Cc:From; b=IIHfps/kIpG3225wKCKNwC4arvurw3Cp24aildHSVeNl+mVuX4PgE/2upobzpmJsp tFNzgz8AKzIJSuKPLJRq5en9BMZYuk72Y5dhlNFEONzDOtUXNETia3gJk9xuVJ4om7 fj+Hnz2eXC9n5gF9BqVcRQyaAwRZWS81I1brXAviLT+FNQaiX/yLB0dKQIYV7FfTem v3mR4JbojjoIGTpNzzZPf3Fob/NVCZtTGoFt9UNLxQvuYEtZtOX8y8m/1tUDzaRnfC OtcPAWQRMTGT5zSHvHCShj1TQK6fFeLKjjK58nu5nC80tO+vxKRm7g5fS/encynnDh QXQ44MAK3VpjA== Received: by mail-oi1-f177.google.com with SMTP id d20so5264681oiw.10 for ; Thu, 25 Feb 2021 00:08:28 -0800 (PST) X-Gm-Message-State: AOAM531QVZahDBIOLeR8Pl3e0jviKfbF3IqPYNoq9TKjze5nJ42wIk2h y8n0jeZMmVItgzIx3JMoa70ml4TJgqIesdls/Aw= X-Google-Smtp-Source: ABdhPJzhPzP8w07jV6uBQrp7LXrKM+lY2Id1Hncl9PKDFrdGJ//pXH2mz/K5ev8F6a3X4JhzkC9Qmxf7+FyOMsocuqA= X-Received: by 2002:a05:6808:10ca:: with SMTP id s10mr1176403ois.33.1614240508050; Thu, 25 Feb 2021 00:08:28 -0800 (PST) MIME-Version: 1.0 References: <20210225033312.2324-1-mikuback@linux.microsoft.com> In-Reply-To: <20210225033312.2324-1-mikuback@linux.microsoft.com> From: "Ard Biesheuvel" Date: Thu, 25 Feb 2021 09:08:16 +0100 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH v1 1/1] StandaloneMmPkg: Remove StandaloneMmDriverEntryPoint.h To: Michael Kubacki , "Liming Gao (Byosoft address)" Cc: devel@edk2.groups.io, Ard Biesheuvel , Sami Mujawar , Jiewen Yao , Supreeth Venkatesh , Laszlo Ersek Content-Type: text/plain; charset="UTF-8" (+ Liming) On Thu, 25 Feb 2021 at 04:33, wrote: > > From: Michael Kubacki > > REF:https://bugzilla.tianocore.org/show_bug.cgi?id=3235 > > The library for this header initially resided in StandaloneMmPkg > but moved to MdePkg and now this file is a duplicate of the header > file in MdePkg. > > This change removes the header file from StandaloneMmPkg. More > details regarding the history of the library transitioning from > StandaloneMmPkg to MdePkg are below. > > The following commit removed the library from StandaloneMmPkg: > d6253d2f9a33 ("StandaloneMmPkg: remove redundant > StandaloneMmDriverEntryPoint driver", 2019-03-11) > > The following commits added the library class & instance to MdePkg: > 7df4764e6a81a ("MdePkg: introduce standalone MM entry point > library class", 2019-01-14) > > 5866d4992396 ("MdePkg: introduce standalone MM entry point > library implementation", 2019-01-14) > > Cc: Ard Biesheuvel > Cc: Sami Mujawar > Cc: Jiewen Yao > Cc: Supreeth Venkatesh > Cc: Laszlo Ersek > Signed-off-by: Michael Kubacki > Acked-by: Ard Biesheuvel Thanks Michael. If Liming agrees, I'll merge this today. > --- > StandaloneMmPkg/Include/Library/StandaloneMmDriverEntryPoint.h | 142 -------------------- > StandaloneMmPkg/StandaloneMmPkg.dec | 3 - > 2 files changed, 145 deletions(-) > > diff --git a/StandaloneMmPkg/Include/Library/StandaloneMmDriverEntryPoint.h b/StandaloneMmPkg/Include/Library/StandaloneMmDriverEntryPoint.h > deleted file mode 100644 > index b72b64704d16..000000000000 > --- a/StandaloneMmPkg/Include/Library/StandaloneMmDriverEntryPoint.h > +++ /dev/null > @@ -1,142 +0,0 @@ > -/** @file > - Module entry point library for Standalone MM Drivers. > - > -Copyright (c) 2006 - 2008, Intel Corporation. All rights reserved.
> -Copyright (c) 2016 - 2021, Arm Limited. All rights reserved.
> - > -SPDX-License-Identifier: BSD-2-Clause-Patent > - > -**/ > - > -#ifndef __MODULE_ENTRY_POINT_H__ > -#define __MODULE_ENTRY_POINT_H__ > - > -/// > -///Declare the PI Specification Revision that this driver requires to execute correctly. > -/// > -extern CONST UINT32 _gMmRevision; > - > -/** > - The entry point of PE/COFF Image for a Standalone MM Driver. > - > - This function is the entry point for a Standalone MM Driver. > - This function must call ProcessLibraryConstructorList() and > - ProcessModuleEntryPointList(). > - If the return status from ProcessModuleEntryPointList() > - is an error status, then ProcessLibraryDestructorList() must be called. > - The return value from ProcessModuleEntryPointList() is returned. > - If _gDriverUnloadImageCount is greater > - than zero, then an unload handler must be registered for this image and > - the unload handler must invoke ProcessModuleUnloadList(). > - If _gUefiDriverRevision is not zero and SystemTable->Hdr.Revision is > - less than _gUefiDriverRevision, then return EFI_INCOMPATIBLE_VERSION. > - > - @param ImageHandle The image handle of the Standalone MM Driver. > - @param SystemTable A pointer to the EFI System Table. > - > - @retval EFI_SUCCESS The Standalone MM Driver exited normally. > - @retval EFI_INCOMPATIBLE_VERSION _gUefiDriverRevision is greater than > - SystemTable->Hdr.Revision. > - @retval Other Return value from > - ProcessModuleEntryPointList(). > - > -**/ > -EFI_STATUS > -EFIAPI > -_ModuleEntryPoint ( > - IN EFI_HANDLE ImageHandle, > - IN EFI_MM_SYSTEM_TABLE *MmSystemTable > - ); > - > - > -/** > - Required by the EBC compiler and identical in functionality to _ModuleEntryPoint(). > - > - This function is required to call _ModuleEntryPoint() passing in ImageHandle, and SystemTable. > - > - @param ImageHandle The image handle of the Standalone MM Driver. > - @param SystemTable A pointer to the EFI System Table. > - > - @retval EFI_SUCCESS The Standalone MM Driver exited normally. > - @retval EFI_INCOMPATIBLE_VERSION _gUefiDriverRevision is greater than > - SystemTable->Hdr.Revision. > - @retval Other Return value from ProcessModuleEntryPointList(). > -**/ > -EFI_STATUS > -EFIAPI > -EfiMain ( > - IN EFI_HANDLE ImageHandle, > - IN EFI_MM_SYSTEM_TABLE *MmSystemTable > - ); > - > -/** > - Auto generated function that calls the library constructors for all of the module's > - dependent libraries. > - > - This function must be called by _ModuleEntryPoint(). > - This function calls the set of library constructors for the set of library instances > - that a module depends on. This includes library instances that a module depends on > - directly and library instances that a module depends on indirectly through other libraries. > - This function is auto generated by build tools and those build tools are responsible > - for collecting the set of library instances, determine which ones have constructors, > - and calling the library constructors in the proper order based upon each of the library > - instances own dependencies. > - > - @param ImageHandle The image handle of the Standalone MM Driver. > - @param SystemTable A pointer to the EFI System Table. > - > -**/ > -VOID > -EFIAPI > -ProcessLibraryConstructorList ( > - IN EFI_HANDLE ImageHandle, > - IN EFI_MM_SYSTEM_TABLE *MmSystemTable > - ); > - > - > -/** > - Auto generated function that calls the library descructors for all of the module's > - dependent libraries. > - > - This function may be called by _ModuleEntryPoint() or ExitDriver(). > - This function calls the set of library destructors for the set of library instances > - that a module depends on. This includes library instances that a module depends on > - directly and library instances that a module depends on indirectly through other libraries. > - This function is auto generated by build tools and those build tools are responsible for > - collecting the set of library instances, determine which ones have destructors, and calling > - the library destructors in the proper order based upon each of the library instances own dependencies. > - > - @param ImageHandle The image handle of the Standalone MM Driver. > - @param SystemTable A pointer to the EFI System Table. > - > -**/ > -VOID > -EFIAPI > -ProcessLibraryDestructorList ( > - IN EFI_HANDLE ImageHandle, > - IN EFI_MM_SYSTEM_TABLE *MmSystemTable > - ); > - > - > -/** > - Auto generated function that calls a set of module entry points. > - > - This function must be called by _ModuleEntryPoint(). > - This function calls the set of module entry points. > - This function is auto generated by build tools and those build tools are responsible > - for collecting the module entry points and calling them in a specified order. > - > - @param ImageHandle The image handle of the Standalone MM Driver. > - @param SystemTable A pointer to the EFI System Table. > - > - @retval EFI_SUCCESS The Standalone MMDriver executed normally. > - @retval !EFI_SUCCESS The Standalone MM Driver failed to execute normally. > -**/ > -EFI_STATUS > -EFIAPI > -ProcessModuleEntryPointList ( > - IN EFI_HANDLE ImageHandle, > - IN EFI_MM_SYSTEM_TABLE *MmSystemTable > - ); > - > -#endif > diff --git a/StandaloneMmPkg/StandaloneMmPkg.dec b/StandaloneMmPkg/StandaloneMmPkg.dec > index 36de8d561bf3..0dfed4ee995a 100644 > --- a/StandaloneMmPkg/StandaloneMmPkg.dec > +++ b/StandaloneMmPkg/StandaloneMmPkg.dec > @@ -25,9 +25,6 @@ [LibraryClasses] > ## @libraryclass Defines a set of interfaces for the MM core entrypoint. > StandaloneMmCoreEntryPoint|Include/Library/StandaloneMmCoreEntryPoint.h > > - ## @libraryclass Defines a set of interfaces for the MM driver entrypoint. > - StandaloneMmDriverEntryPoint|Include/Library/StandaloneMmDriverEntryPoint.h > - > ## @libraryclass Defines a set of interfaces that provides services for > ## MM Memory Operation. > MemLib|Include/Library/StandaloneMmMemLib.h > -- > 2.28.0.windows.1 >