Re: [edk2-devel] [Patch 1/1] BaseTools/Scripts/PatchCheck: Error if commit modifies multiple packages

["Ard Biesheuvel" <ardb@kernel.org>]

On Thu, 15 Feb 2024 at 00:27, Michael D Kinney
<michael.d.kinney@intel.com> wrote:
>
> Hi Ard,
>
> Using commit message does provide granularity down to a single commit,
> which may be better than PR label which applies across all commits
> in a series.
>
> However, a flag in the commit message can be set by the author who may
> not be a maintainer and maintainers would then need to review commit
> messages for incorrect use of those flags.
>
> Only maintainers/admins can set labels, so from a permission management
> perspective the PR label has an advantage.
>
> Additional comments below.  There are ways to support bisect and meet
> the proposed checks. The suggestion uses techniques that Laszlo helped
> me with in the past when working on issues like there. I have seen more
> complex scenarios than the examples listed below, and have been able to
> figure out a path through.
>
> I would agree it is extra work to think about these when working on
> the code changes and extra work to reformulate the patches when these
> conditions are encountered.
>
> I just want to be clear on the objections.  It is not about if the patches
> can be organized to follow this proposal.  The objection is about the
> extra work required to reformulate patches.
>

No.

The objection is fundamentally about having to appease the CI even if
doing so is unreasonable. I don't mind a bit of extra work. I do mind
having to make code changes that make the code worse just to tick a CI
box. (This is why I disabled uncrustify for the ARM packages: many
header files which were perfectly legible before were converted into a
jumble of alphabet soup because uncrustify removed all of the
indentation)

It is about having the discretion to deviate from the rules in the odd
case where the cure is worse than the disease.


-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#115473): https://edk2.groups.io/g/devel/message/115473
Mute This Topic: https://groups.io/mt/104345509/7686176
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io]
-=-=-=-=-=-=-=-=-=-=-=-