From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by mx.groups.io with SMTP id smtpd.web10.7786.1644920472149195168 for ; Tue, 15 Feb 2022 02:21:12 -0800 Authentication-Results: mx.groups.io; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=svzqjjD3; spf=pass (domain: kernel.org, ip: 139.178.84.217, mailfrom: ardb@kernel.org) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 5FE5C612FF for ; Tue, 15 Feb 2022 10:21:11 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 039DDC340F3 for ; Tue, 15 Feb 2022 10:21:09 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1644920470; bh=i8k4uHAob5mr+In3hpaqyDNIbc8uj6NBQDgiMhDgh10=; h=References:In-Reply-To:From:Date:Subject:To:Cc:From; b=svzqjjD3T/kz08/9IRC4H0rdYBbxVlHDCbTTqoMFuF2yzT2O9QcdAvNWTVbVDE+UN ADdcqzXnNRjrSm77pqjsjeh8zq+jsLf6adcmMJRaWLHb8SEeouqjZe8p2dh8aT4uwp A+kIN4B+CIyDlYJiHjVcv2BmFfzB/y+EIY3g9LmnkSZn2DnZ/hPsfTummjadHJdTYc KRryznYz457DiFgWc8HXQyHbXqASNyWNdf8F9x9Ivw+/9ioCffp2vJXMbUbR9Xqkgc kiVtfxP/sNoZlJUGRh6STBG9ao/oQRFl+pIJ2M8Rs2DMHcMCWtjWesvd6rxjU5IFY4 bv+xHAuX8sVQQ== Received: by mail-wr1-f42.google.com with SMTP id p9so10696856wra.12 for ; Tue, 15 Feb 2022 02:21:09 -0800 (PST) X-Gm-Message-State: AOAM533JI+cRh9jUZITL2l6C84VYJxXKWs0zYvDcFmgMYR2kKBY6mXKr 5CqgLIPc1KOPmrWqvat/s/S4CjglrhtCoCFVMls= X-Google-Smtp-Source: ABdhPJwBST19tWeDrV3rBF3PcSgb1CY+aHj1mBz7SlXhvc7JvflAVLMLsxSqpY5A/dJqrH6vj4fOLctCXbcOv2Bdm7U= X-Received: by 2002:a5d:6d0d:: with SMTP id e13mr2625395wrq.189.1644920468259; Tue, 15 Feb 2022 02:21:08 -0800 (PST) MIME-Version: 1.0 References: <20220204201302.21451-1-quic_rcran@quicinc.com> <002d01d81ee4$9bdd2d90$d39788b0$@byosoft.com.cn> In-Reply-To: <002d01d81ee4$9bdd2d90$d39788b0$@byosoft.com.cn> From: "Ard Biesheuvel" Date: Tue, 15 Feb 2022 11:20:56 +0100 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [edk2-devel] [PATCH v2 1/1] OvmfPkg/VmgExitLib: Fix uninitialized variable warning with XCODE5 To: edk2-devel-groups-io , "Liming Gao (Byosoft address)" Cc: Rebecca Cran , James Bottomley , Min Xu , Jiewen Yao , Tom Lendacky , Jordan Justen , Ard Biesheuvel , Erdem Aktas , Michael Roth , Gerd Hoffmann , Brijesh Singh Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable On Fri, 11 Feb 2022 at 02:14, gaoliming wrote: > > Ard: > I am OK to merge this issue for this stable tag. It is a clear bug fix. > Merged as #2523 Thanks all, > > -----=E9=82=AE=E4=BB=B6=E5=8E=9F=E4=BB=B6----- > > =E5=8F=91=E4=BB=B6=E4=BA=BA: Ard Biesheuvel > > =E5=8F=91=E9=80=81=E6=97=B6=E9=97=B4: 2022=E5=B9=B42=E6=9C=8810=E6=97= =A5 17:18 > > =E6=94=B6=E4=BB=B6=E4=BA=BA: edk2-devel-groups-io ; Rebecca Cran > > ; Liming Gao (Byosoft address) > > > > =E6=8A=84=E9=80=81: James Bottomley ; Min Xu > > ; Jiewen Yao ; Tom Lendacky > > ; Jordan Justen ; > > Ard Biesheuvel ; Erdem Aktas > > ; Michael Roth ; Gerd > > Hoffmann ; Brijesh Singh > > =E4=B8=BB=E9=A2=98: Re: [edk2-devel] [PATCH v2 1/1] OvmfPkg/VmgExitLib:= Fix uninitialized > > variable warning with XCODE5 > > > > On Thu, 10 Feb 2022 at 10:17, Ard Biesheuvel wrote: > > > > > > (+ Liming) > > > > > > > ... for real this time. > > > > > On Fri, 4 Feb 2022 at 21:28, Rebecca Cran > > wrote: > > > > > > > > XCODE5 reported the following warning: > > > > > > > > OvmfPkg/Library/VmgExitLib/VmgExitVcHandler.c:1895:12: note: > > > > uninitialized use occurs here > > > > Compacted > > > > ^^^^^^^^^ > > > > > > > > Initialize the 'Compacted' variable to fix the warning. > > > > > > > > Signed-off-by: Rebecca Cran > > > > --- > > > > OvmfPkg/Library/VmgExitLib/VmgExitVcHandler.c | 1 + > > > > 1 file changed, 1 insertion(+) > > > > > > > > diff --git a/OvmfPkg/Library/VmgExitLib/VmgExitVcHandler.c > > b/OvmfPkg/Library/VmgExitLib/VmgExitVcHandler.c > > > > index a40a31f7c275..ccb1300690fa 100644 > > > > --- a/OvmfPkg/Library/VmgExitLib/VmgExitVcHandler.c > > > > +++ b/OvmfPkg/Library/VmgExitLib/VmgExitVcHandler.c > > > > @@ -1872,6 +1872,7 @@ GetCpuidFw ( > > > > UINT32 XSaveSize; > > > > > > > > XssMsr.Uint64 =3D 0; > > > > + Compacted =3D 0; > > > > > > This should be FALSE not 0. I will fix this up before merging. > > > > > > Liming: is it ok if I merge this today? > > > > > > > > > > if (EcxIn =3D=3D 1) { > > > > /* > > > > * The PPR and APM aren't clear on what size should be > > encoded in > > > > -- > > > > 2.34.1 > > > > > > > > > > > > > > > > > > > > > > > > > > > > >=20 > >