From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by spool.mail.gandi.net (Postfix) with ESMTPS id A9AC4D81415 for ; Tue, 12 Mar 2024 16:59:02 +0000 (UTC) DKIM-Signature: a=rsa-sha256; bh=QhJ/UDidqkDUrk3T/iaAGV8y64AQtiDbLnSID2mvE4s=; c=relaxed/simple; d=groups.io; h=MIME-Version:References:In-Reply-To:From:Date:Message-ID:Subject:To:Cc:Precedence:List-Subscribe:List-Help:Sender:List-Id:Mailing-List:Delivered-To:Resent-Date:Reply-To:List-Unsubscribe-Post:List-Unsubscribe:Content-Type; s=20240206; t=1710262741; v=1; b=ui+X/xITaGd1MchAAmShAKLTLmh8a4R0Gn96A3rIqu0xiYwBaB6gYpAf7AObOx+wxpmXHmov QNHXgXhodbipKIdMWemHYWfNz4N22Kbj3CMaKD/Hy3QVfskxcHB4YxBxk2iDpBH1oTUCFnlxhoO 0FDP5g4t5VObk3yNGusoczSNYC7TGgMgpnpuM6Cne3ekgFDkk7odndPGeIU9MbgzPv2yOqb5PxX aM8XGDMEw9WR9KXK0U06gSG4e5/YIpOkVGqSi27T9OsHATJDTMNmWd4q6vdGlNSQEuyVc6CLjqQ Je/yN9Y2WzpD5YXoR0Z7XjkTK94GMFwHJ67KxumHCjNlg== X-Received: by 127.0.0.2 with SMTP id TXaQYY7687511xinsFnanTIx; Tue, 12 Mar 2024 09:59:01 -0700 X-Received: from sin.source.kernel.org (sin.source.kernel.org [145.40.73.55]) by mx.groups.io with SMTP id smtpd.web11.1721.1710262740391383689 for ; Tue, 12 Mar 2024 09:59:00 -0700 X-Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by sin.source.kernel.org (Postfix) with ESMTP id 7CED2CE138F for ; Tue, 12 Mar 2024 16:58:58 +0000 (UTC) X-Received: by smtp.kernel.org (Postfix) with ESMTPSA id B8ED3C43394 for ; Tue, 12 Mar 2024 16:58:57 +0000 (UTC) X-Received: by mail-lj1-f182.google.com with SMTP id 38308e7fff4ca-2d33986dbc0so65532801fa.2 for ; Tue, 12 Mar 2024 09:58:57 -0700 (PDT) X-Gm-Message-State: 8kXwAxWUTsLykcowyKymModlx7686176AA= X-Google-Smtp-Source: AGHT+IGCJESmsnifBsXZea5c0xKfR3Gwg4MwUXdsze6uB4Lg0nvbUgWjh0svUkLONfjC70SrDLuH0lyNwB9b15rv2uE= X-Received: by 2002:a2e:2c17:0:b0:2d4:15e8:b545 with SMTP id s23-20020a2e2c17000000b002d415e8b545mr1771262ljs.18.1710262735913; Tue, 12 Mar 2024 09:58:55 -0700 (PDT) MIME-Version: 1.0 References: <20240312151716.2154180-1-ardb+git@google.com> <74a4fb99-5d29-44ac-93bd-caea7367d08e@quicinc.com> In-Reply-To: From: "Ard Biesheuvel" Date: Tue, 12 Mar 2024 17:58:44 +0100 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [edk2-devel] [PATCH 1/1] EmbeddedPkg/NonCoherentIoMmuDxe: Make SetAttributes always succeed To: Leif Lindholm Cc: devel@edk2.groups.io, jeremy.linton@arm.com, abner.chang@amd.com Precedence: Bulk List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Resent-Date: Tue, 12 Mar 2024 09:59:00 -0700 Reply-To: devel@edk2.groups.io,ardb@kernel.org List-Unsubscribe-Post: List-Unsubscribe=One-Click List-Unsubscribe: Content-Type: text/plain; charset="UTF-8" X-GND-Status: LEGIT Authentication-Results: spool.mail.gandi.net; dkim=pass header.d=groups.io header.s=20240206 header.b="ui+X/xIT"; spf=pass (spool.mail.gandi.net: domain of bounce@groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce@groups.io; dmarc=fail reason="SPF not aligned (relaxed), DKIM not aligned (relaxed)" header.from=kernel.org (policy=none) On Tue, 12 Mar 2024 at 17:56, Leif Lindholm wrote: > > On 2024-03-12 09:50, Ard Biesheuvel wrote: > > On Tue, 12 Mar 2024 at 17:38, Leif Lindholm wrote: > >> > >> On 2024-03-12 08:17, Ard Biesheuvel wrote: > >>> From: Ard Biesheuvel > >>> > >>> NonCoherentIoMmuSetAttribute() does nothing except return > >>> EFI_UNSUPPORTED. This was fine when it was introduced, but now, the PCI > >>> bus driver will fail a PCI I/O Map() operation if the SetAttributes > >>> fails. > >>> > >>> So return EFI_SUCCESS instead. > >> > >> It's unclear to me why this change is safe (looking forward). > >> Does NonCoherentIoMmuDxe also imply no IoMmu actually exists? > >> > > > > Basically. NonCoherentIoMmuDxe is just a vehicle to allow > > NonCoherentDmaLib to be plugged into the PCI host bridge driver. It is > > not intended to ever do anything more than that. > > Not that it needs to happen for this > (Reviewed-by: Leif Lindholm ) > but maybe we ought to consider renaming it then? > DummyIoMmuDxe? > Fair point. Or PassThroughIoMmuDxe perhaps? -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#116696): https://edk2.groups.io/g/devel/message/116696 Mute This Topic: https://groups.io/mt/104886877/7686176 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io] -=-=-=-=-=-=-=-=-=-=-=-