From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from ams.source.kernel.org (ams.source.kernel.org [145.40.68.75])
 by mx.groups.io with SMTP id smtpd.web11.8850.1661332101579945431
 for <devel@edk2.groups.io>;
 Wed, 24 Aug 2022 02:08:21 -0700
Authentication-Results: mx.groups.io;
 dkim=pass header.i=@kernel.org header.s=k20201202 header.b=It+UAdAR;
 spf=pass (domain: kernel.org, ip: 145.40.68.75, mailfrom: ardb@kernel.org)
Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140])
	(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
	(No client certificate requested)
	by ams.source.kernel.org (Postfix) with ESMTPS id B84D5B82365
	for <devel@edk2.groups.io>; Wed, 24 Aug 2022 09:08:19 +0000 (UTC)
Received: by smtp.kernel.org (Postfix) with ESMTPSA id 6F64EC433D6
	for <devel@edk2.groups.io>; Wed, 24 Aug 2022 09:08:18 +0000 (UTC)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org;
	s=k20201202; t=1661332098;
	bh=1GMLInYs4pfnc5Ccp7V4BfqbRqX9nyAhGXrsoxpoHug=;
	h=References:In-Reply-To:From:Date:Subject:To:Cc:From;
	b=It+UAdARBcqT7qn6a3+pAydArvkLTY/Z5B3NL1KSfliVRQOj7utrqmWF0fbRXwIQz
	 w2tdOO7RG9H8wIeJ2esiIJuegBigObfnoRDtliufBg8qpb1teb5VKiodf2m0kmGA3M
	 rj3qZdNpexYdfoZMJM6gBVeW5ezP6Sr2y6aPczc+Ms7euXcUSWOG8um5rXbQeKbwKy
	 gX+lnz2Haow1rScRrV0bNNCy97I3/fwL9CayRPQsl8Nh2BwOlp30/cnHBMqud1TL0x
	 VLqNyaJo6NjNEo75GWjL0uXXHC8fDCzgSk2ZDAWNT1IC1jGoGYx2KUwWkviJgp2NbS
	 0Q+5zCOXDsGyw==
Received: by mail-wr1-f45.google.com with SMTP id a4so19977390wrq.1
        for <devel@edk2.groups.io>; Wed, 24 Aug 2022 02:08:18 -0700 (PDT)
X-Gm-Message-State: ACgBeo0Hi8CBThNbUZ9cDVGTGRq9v9FPw+k72y6BL65ruYjf+Rsj46aV
	6xhoUxjiFzrtPOIO9eAI8LBrNpPJkpF8z7MZ8Lc=
X-Google-Smtp-Source: AA6agR7K9mxayQmOgdbLZ8D0MoFcFpOeUw51jWIcs/HjHhachcihphLKFi6oi1ndg5vWhO7opmbvb+gsXj6fqTSVcmU=
X-Received: by 2002:a05:6000:1701:b0:225:678e:f3eb with SMTP id
 n1-20020a056000170100b00225678ef3ebmr3713922wrc.598.1661332096602; Wed, 24
 Aug 2022 02:08:16 -0700 (PDT)
MIME-Version: 1.0
References: <20220817151157.1941409-1-ardb@kernel.org> <20220817151157.1941409-3-ardb@kernel.org>
 <606fa379-1740-5353-d156-13069a5ba040@redhat.com> <CAMj1kXFOsd7vOgY5h8eQMH5ZZNkDbqHYQr2f=5ozcVgzSKxtgw@mail.gmail.com>
 <20220823070436.dkc56uz66vfoj6wx@sirius.home.kraxel.org>
In-Reply-To: <20220823070436.dkc56uz66vfoj6wx@sirius.home.kraxel.org>
From: "Ard Biesheuvel" <ardb@kernel.org>
Date: Wed, 24 Aug 2022 11:08:05 +0200
X-Gmail-Original-Message-ID: <CAMj1kXH_nWcFuTiZSpovDnm_eeBY9U52j4KbxA=Q+MvK83kwYA@mail.gmail.com>
Message-ID: <CAMj1kXH_nWcFuTiZSpovDnm_eeBY9U52j4KbxA=Q+MvK83kwYA@mail.gmail.com>
Subject: Re: [edk2-devel] [PATCH v2 2/2] OvmfPkg/OvmfPkgX64: Allow runtime control of IPv4 and IPv6 support
To: Gerd Hoffmann <kraxel@redhat.com>
Cc: devel@edk2.groups.io, lersek@redhat.com, Yuan Yu <yuanyu@google.com>, 
	Pawel Polawski <ppolawsk@redhat.com>, Oliver Steffen <osteffen@redhat.com>, 
	Jiewen Yao <jiewen.yao@intel.com>, "Brian J . Johnson" <brian.johnson@hpe.com>
Content-Type: text/plain; charset="UTF-8"

On Tue, 23 Aug 2022 at 09:04, Gerd Hoffmann <kraxel@redhat.com> wrote:
>
>   Hi,
>
> > > Looks good to me, but should be reflected to the other DSC files, and
> > > perhaps (see Gerd's comments) factored out to some common include snippet.
> >
> > Fair enough, although I'm not sure where to look for Gerd's comments?
> > Did they make it to the list?
>
> Was a reply to v1 series.
>
> Summary: We have alot of duplication in the Ovmf*.{dsc,fdf} files, I think
> moving stuff to include files make sense (similar to OvmfTpm*.inc already in
> tree) to reduce duplication, simplify maintainance and keep the build
> configs in sync.
>
> With more and more include snippets it possibly makes sense to move them
> all into a subdirectory.
>

OK, that is a good point. i will take this into account for the next revision.

Thanks,
Ard.