From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by mx.groups.io with SMTP id smtpd.web11.34904.1685631675919533474 for ; Thu, 01 Jun 2023 08:01:16 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=ZUqK7JkW; spf=pass (domain: kernel.org, ip: 139.178.84.217, mailfrom: ardb@kernel.org) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 4F69964638 for ; Thu, 1 Jun 2023 15:01:15 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 6D9B7C433A4 for ; Thu, 1 Jun 2023 15:01:14 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1685631674; bh=RJ+Wl89YYAI8XGkR4V5+J9Gsqwbg2CcDdG+s3lUfeio=; h=References:In-Reply-To:From:Date:Subject:To:Cc:From; b=ZUqK7JkWnXDCGAXE7s7nebPCl7FN+lQ2gddx22TMVhd1A6dH1q9KjuKYSnpg2kWCP Hu6lycinrYWPazbgDhTjaXpSVQOBDVawhuxYZlFGbDGrdoi3T0XylPzTnR4WzWQGZN obAAtS9kbXoPjeRzL3Sy2eLn63erbB2zzP3Cw3xEy/efg1Gepy/CxEWAM2LD3czwIj MZmzNGKnt3fUj5wDBlxgoo//AJWiK1bOCiPDZaGLDKQ+sUX7LMAhZz5FPPw+Zy4lJY b/xcKQ6ayRdk/CXhFlkBPQItNtO5gNQqjtDGxV6s8xgFGtPfrB+wBnr7Y/g0Z69JdG vaBbU7ELzZ/Eg== Received: by mail-lj1-f169.google.com with SMTP id 38308e7fff4ca-2af20198f20so13235221fa.0 for ; Thu, 01 Jun 2023 08:01:14 -0700 (PDT) X-Gm-Message-State: AC+VfDz2t+f4yaVdeSQQ5/pvyxqmFdZ9pExG7m9RFxzi2KNm4Fn9bqnN qNVileNoE8odD26XIa1soemF2oyn2DM4L+3J9WU= X-Google-Smtp-Source: ACHHUZ6m3QEdxRvyBl/SRhShGhAr+dWcs9OOICij5aFBXcIsZS+Ie7+5KLtwkON7bTXOwCjUezNRL4aAR/8P2r/T8Js= X-Received: by 2002:a2e:8782:0:b0:2ab:e50:315a with SMTP id n2-20020a2e8782000000b002ab0e50315amr5126434lji.51.1685631672389; Thu, 01 Jun 2023 08:01:12 -0700 (PDT) MIME-Version: 1.0 References: <20230511120239.695237-1-corvink@FreeBSD.org> <7f1ffbdb-89d1-4e18-a220-28f61c282f8f@perard> In-Reply-To: <7f1ffbdb-89d1-4e18-a220-28f61c282f8f@perard> From: "Ard Biesheuvel" Date: Thu, 1 Jun 2023 17:01:01 +0200 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [edk2-devel] [PATCH v5 1/3] OvmfPkg/Xen: export search of RSDP into a library function To: devel@edk2.groups.io, anthony.perard@citrix.com Cc: =?UTF-8?Q?Corvin_K=C3=B6hne?= , Gerd Hoffmann , Ard Biesheuvel , Jiewen Yao , Jordan Justen , Julien Grall Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable On Thu, 11 May 2023 at 15:30, Anthony PERARD via groups.io wrote: > > On Thu, May 11, 2023 at 02:02:37PM +0200, Corvin K=C3=B6hne wrote: > > diff --git a/OvmfPkg/Library/AcpiPlatformLib/DxeAcpiPlatformLib.c b/Ovm= fPkg/Library/AcpiPlatformLib/DxeAcpiPlatformLib.c > > new file mode 100644 > > index 000000000000..ce52ad31cf25 > > --- /dev/null > > +++ b/OvmfPkg/Library/AcpiPlatformLib/DxeAcpiPlatformLib.c > > @@ -0,0 +1,62 @@ > > +/** @file > > + Copyright (c) 2023, Corvin K=C3=B6hne > > As this new file move codes from OvmfPkg/XenAcpiPlatformDxe/Xen.c, > shouldn't you also copy the "Copyright" lines from that file as well? > > > Beside that, patch looks fine: > Reviewed-by: Anthony PERARD > Agreed Doing a bit of amateur archaeology, I think we should retain these as well Copyright (c) 2012, Bei Guan Copyright (C) 2021, Red Hat, Inc. Also, please run this series through the CI (just send a PR to the tiancore/edk2 github project - it will not get merged but it will tell you if the CI spots any issues in the code)