From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from ams.source.kernel.org (ams.source.kernel.org [145.40.68.75]) by mx.groups.io with SMTP id smtpd.web12.51254.1643735698042445413 for ; Tue, 01 Feb 2022 09:14:58 -0800 Authentication-Results: mx.groups.io; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=UCuon5R7; spf=pass (domain: kernel.org, ip: 145.40.68.75, mailfrom: ardb@kernel.org) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id 3117EB82F22 for ; Tue, 1 Feb 2022 17:14:56 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id C5BDFC340EE for ; Tue, 1 Feb 2022 17:14:54 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1643735694; bh=YPS16iakg5uO9YDG+9FjoXGQ0GSl8fvJ8Oc8SUgw2dY=; h=References:In-Reply-To:From:Date:Subject:To:Cc:From; b=UCuon5R7IkrhcuCf5gMQ8VSd+SJgTXyPa/ux5UOlA+YzA3uK65h1+l+OEXFOy8CCo 92hN5kdo1Uo1Gzbgavii9GPcP80jeMcuM9CpiMFMR7SePFOeuVYc/N0OryBmYouxPm RZnJOWiDXTpMXSRQ0DGG2YVy5dT1QwJTck8CTlqmauO59+LqIEQaG99CKfoPxRsUsL SvzYfLR+1Xdn5LyUWCfqSogBzJcbmpJFQ/7/B0CmkiWZwWfhYsNBuY8bKaMXPYuF4l CWE8uEz7KH38Shw+UudC8zkacpMC9DNPxnJOrHiMyvywpYP+4vLVqhKSJUTZ6qjQbX VU9BVaP3TKn8w== Received: by mail-wr1-f46.google.com with SMTP id h7so1573786wrc.5 for ; Tue, 01 Feb 2022 09:14:54 -0800 (PST) X-Gm-Message-State: AOAM5331Clm88WL/0fXWWaL8gd8KGtJFeDFspKQuUyabYjm+oRuMs9hM dtvnJucUBNxnVhkk5XZsDnYz6zzl2Ptr5k+S4s8= X-Google-Smtp-Source: ABdhPJxgWcgCt7iiDaEn6VZrwx26JrDmWcVYf4JHWFKces3AKJtp1Qd153/0XVTSgpw2d+ON0nkzxcW9PE4dL5TT/j8= X-Received: by 2002:a05:6000:1c9:: with SMTP id t9mr22677253wrx.550.1643735693123; Tue, 01 Feb 2022 09:14:53 -0800 (PST) MIME-Version: 1.0 References: <20220201165627.25216-1-quic_rcran@quicinc.com> In-Reply-To: From: "Ard Biesheuvel" Date: Tue, 1 Feb 2022 18:14:41 +0100 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [edk2-devel] [PATCH 1/3] Platform/AMD: Move VariablePolicyHelperLib into LibraryClasses.common To: edk2-devel-groups-io , Rebecca Cran Cc: Ard Biesheuvel , Leif Lindholm , Marcin Wojtas , Masami Hiramatsu Content-Type: text/plain; charset="UTF-8" On Tue, 1 Feb 2022 at 17:59, Ard Biesheuvel wrote: > > On Tue, 1 Feb 2022 at 17:58, Rebecca Cran wrote: > > > > Sorry, I forgot to add a cover letter. > > > > I noticed some breakages in Arm platforms caused by additions of > > VariablePolicyHelperLib: the 3 patches fix them by adding it to > > LibraryClasses.common. > > > > > > No worries - I'll pick these up momentarily. > Series Reviewed-by: Ard Biesheuvel Pushed as 5777ed5d604e..ce768c6535cd Thanks, Ard. > > > > > > > > On 2/1/22 09:56, Rebecca Cran wrote: > > > The VariablePolicyHelperLib is now used by a number of driver types, so > > > instead of duplicating it, move it into the LibraryClasses.common section. > > > > > > Signed-off-by: Rebecca Cran > > > --- > > > Platform/AMD/OverdriveBoard/OverdriveBoard.dsc | 3 +-- > > > 1 file changed, 1 insertion(+), 2 deletions(-) > > > > > > diff --git a/Platform/AMD/OverdriveBoard/OverdriveBoard.dsc b/Platform/AMD/OverdriveBoard/OverdriveBoard.dsc > > > index af207391209c..41c1cadc3425 100644 > > > --- a/Platform/AMD/OverdriveBoard/OverdriveBoard.dsc > > > +++ b/Platform/AMD/OverdriveBoard/OverdriveBoard.dsc > > > @@ -125,6 +125,7 @@ DEFINE X64EMU_ENABLE = FALSE > > > OpensslLib|CryptoPkg/Library/OpensslLib/OpensslLib.inf > > > RngLib|MdePkg/Library/DxeRngLib/DxeRngLib.inf > > > TlsLib|CryptoPkg/Library/TlsLib/TlsLib.inf > > > + VariablePolicyHelperLib|MdeModulePkg/Library/VariablePolicyHelperLib/VariablePolicyHelperLib.inf > > > VariablePolicyLib|MdeModulePkg/Library/VariablePolicyLib/VariablePolicyLib.inf > > > > > > UefiBootManagerLib|MdeModulePkg/Library/UefiBootManagerLib/UefiBootManagerLib.inf > > > @@ -209,7 +210,6 @@ DEFINE X64EMU_ENABLE = FALSE > > > PerformanceLib|MdeModulePkg/Library/DxePerformanceLib/DxePerformanceLib.inf > > > MemoryAllocationLib|MdePkg/Library/UefiMemoryAllocationLib/UefiMemoryAllocationLib.inf > > > NonDiscoverableDeviceRegistrationLib|MdeModulePkg/Library/NonDiscoverableDeviceRegistrationLib/NonDiscoverableDeviceRegistrationLib.inf > > > - VariablePolicyHelperLib|MdeModulePkg/Library/VariablePolicyHelperLib/VariablePolicyHelperLib.inf > > > > > > [LibraryClasses.common.DXE_RUNTIME_DRIVER] > > > HobLib|MdePkg/Library/DxeHobLib/DxeHobLib.inf > > > @@ -219,7 +219,6 @@ DEFINE X64EMU_ENABLE = FALSE > > > DebugLib|MdePkg/Library/DxeRuntimeDebugLibSerialPort/DxeRuntimeDebugLibSerialPort.inf > > > !endif > > > VariablePolicyLib|MdeModulePkg/Library/VariablePolicyLib/VariablePolicyLibRuntimeDxe.inf > > > - VariablePolicyHelperLib|MdeModulePkg/Library/VariablePolicyHelperLib/VariablePolicyHelperLib.inf > > > > > > [LibraryClasses.common.UEFI_APPLICATION] > > > PerformanceLib|MdeModulePkg/Library/DxePerformanceLib/DxePerformanceLib.inf > > > > > > > > > >