From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail05.groups.io (mail05.groups.io [45.79.224.7]) by spool.mail.gandi.net (Postfix) with ESMTPS id EDE87AC0C71 for ; Wed, 19 Jun 2024 07:09:46 +0000 (UTC) DKIM-Signature: a=rsa-sha256; bh=DE9oSj3CQilRi3bqrQqkkCHTdxuCd4S88roTZvGcuU4=; c=relaxed/simple; d=groups.io; h=MIME-Version:References:In-Reply-To:From:Date:Message-ID:Subject:To:Cc:Precedence:List-Subscribe:List-Help:Sender:List-Id:Mailing-List:Delivered-To:Resent-Date:Resent-From:Reply-To:List-Unsubscribe-Post:List-Unsubscribe:Content-Type; s=20240206; t=1718780986; v=1; b=zxiubf83Hp7ehNGt0qnDpviSSL/cNo/XDy9LtBUJA+IAFwyi8/KcjZ2UmTnpy5dHE3c4EMrr dEcrmzu3/yP7H9FsIbydso9hCJP89RlN4GhvL1SjE5wtQP6sGMHVXF6PaRQzmt/CeWqi+ijPJk6 /abrfJ+EakySixexHaJbEDi0PcgQDlSzVThux2tHEf+YmZN0hzZ4CC6DTWWPGx/Sihn0dlI+RCe m5pC6jo9CgN3ugKL5Fgex2SxkFBF28NjmscEvDluzobrBCRpaiArsd1WurMuHal4B8pGU4N88Lt e5MwaHu0p7cjWYSzjbnTKRS4pwPAaZv34T82Qo0HE4D/g== X-Received: by 127.0.0.2 with SMTP id zz4eYY7687511xhDIdEA8neH; Wed, 19 Jun 2024 00:09:45 -0700 X-Received: from sin.source.kernel.org (sin.source.kernel.org [145.40.73.55]) by mx.groups.io with SMTP id smtpd.web11.15001.1718780979324395435 for ; Wed, 19 Jun 2024 00:09:39 -0700 X-Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by sin.source.kernel.org (Postfix) with ESMTP id 5FE05CE1D27 for ; Wed, 19 Jun 2024 07:09:36 +0000 (UTC) X-Received: by smtp.kernel.org (Postfix) with ESMTPSA id B0395C32786 for ; Wed, 19 Jun 2024 07:09:35 +0000 (UTC) X-Received: by mail-lf1-f48.google.com with SMTP id 2adb3069b0e04-52c7fbad011so7233415e87.0 for ; Wed, 19 Jun 2024 00:09:35 -0700 (PDT) X-Gm-Message-State: rIsAmLtZxiPqYDvG7ZotleFLx7686176AA= X-Google-Smtp-Source: AGHT+IH4kh2eISY2XNdPMiD5oHv9fV4MBXcMyTdWVaQlIwKqyI29bceHb9+U/vaSpSIqCv2kY8ebDp+FYVXqFhAPkGo= X-Received: by 2002:a05:6512:124a:b0:52c:81fc:eba2 with SMTP id 2adb3069b0e04-52ccaa9280emr1127815e87.44.1718780974080; Wed, 19 Jun 2024 00:09:34 -0700 (PDT) MIME-Version: 1.0 References: <20240619055243.486686-1-marcin.juszkiewicz@linaro.org> In-Reply-To: <20240619055243.486686-1-marcin.juszkiewicz@linaro.org> From: "Ard Biesheuvel" Date: Wed, 19 Jun 2024 09:09:22 +0200 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [edk2-devel] [PATCH edk2-platforms 1/1] QemuSbsa: enable WriteCombine for the FrameBuffer To: devel@edk2.groups.io, marcin.juszkiewicz@linaro.org Cc: Leif Lindholm , Ard Biesheuvel Precedence: Bulk List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Resent-Date: Wed, 19 Jun 2024 00:09:39 -0700 Resent-From: ardb@kernel.org Reply-To: devel@edk2.groups.io,ardb@kernel.org List-Unsubscribe-Post: List-Unsubscribe=One-Click List-Unsubscribe: Content-Type: text/plain; charset="UTF-8" X-GND-Status: LEGIT Authentication-Results: spool.mail.gandi.net; dkim=pass header.d=groups.io header.s=20240206 header.b=zxiubf83; dmarc=fail reason="SPF not aligned (relaxed), DKIM not aligned (relaxed)" header.from=kernel.org (policy=none); spf=pass (spool.mail.gandi.net: domain of bounce@groups.io designates 45.79.224.7 as permitted sender) smtp.mailfrom=bounce@groups.io On Wed, 19 Jun 2024 at 07:52, Marcin Juszkiewicz wrote: > > QEMU no longer permits misaligned access to device memory, which breaks > QemuVideoDxe on SbsaQemu. > > c1d1910be6e04a8b1a73090cf2881fb698947a6e commit in EDK2 fixed it by > enabling WriteCombine for Framebuffer memory. This change enables that > fix. > > Signed-off-by: Marcin Juszkiewicz Reviewed-by: Ard Biesheuvel > --- > Platform/Qemu/SbsaQemu/SbsaQemu.dsc | 3 +++ > 1 file changed, 3 insertions(+) > > diff --git a/Platform/Qemu/SbsaQemu/SbsaQemu.dsc b/Platform/Qemu/SbsaQemu/SbsaQemu.dsc > index b012eaa34147..11126bcaa1fe 100644 > --- a/Platform/Qemu/SbsaQemu/SbsaQemu.dsc > +++ b/Platform/Qemu/SbsaQemu/SbsaQemu.dsc > @@ -311,6 +311,9 @@ [PcdsFeatureFlag.common] > gEfiMdeModulePkgTokenSpaceGuid.PcdConOutGopSupport|TRUE > gEfiMdeModulePkgTokenSpaceGuid.PcdConOutUgaSupport|FALSE > > + # Enable WriteCombine for FrameBuffer > + gUefiOvmfPkgTokenSpaceGuid.PcdRemapFrameBufferWriteCombine|TRUE > + > [PcdsFixedAtBuild.common] > gEfiMdePkgTokenSpaceGuid.PcdMaximumUnicodeStringLength|1000000 > gEfiMdePkgTokenSpaceGuid.PcdMaximumAsciiStringLength|1000000 > -- > 2.45.1 > > > > ------------ > Groups.io Links: You receive all messages sent to this group. > View/Reply Online (#119626): https://edk2.groups.io/g/devel/message/119626 > Mute This Topic: https://groups.io/mt/106755714/5717338 > Group Owner: devel+owner@edk2.groups.io > Unsubscribe: https://edk2.groups.io/g/devel/unsub [ardb+tianocore@kernel.org] > ------------ > > -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#119627): https://edk2.groups.io/g/devel/message/119627 Mute This Topic: https://groups.io/mt/106755714/7686176 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io] -=-=-=-=-=-=-=-=-=-=-=-