From: "Ard Biesheuvel" <ardb@kernel.org>
To: Pete Batard <pete@akeo.ie>
Cc: devel@edk2.groups.io, quic_llindhol@quicinc.com,
michael.d.kinney@intel.com, gaoliming@byosoft.com.cn
Subject: Re: [edk2-devel] [PATCH 1/1] MdePkg/BaseLib: Fix undefined symbol when compiling with Visual Studio
Date: Wed, 8 May 2024 11:07:05 +0200 [thread overview]
Message-ID: <CAMj1kXHbnMUBJycnF1P+xijk73wdVRXwXXUgJnBVc7TJv9dTnw@mail.gmail.com> (raw)
In-Reply-To: <20240508085148.1725-2-pete@akeo.ie>
On Wed, 8 May 2024 at 10:52, Pete Batard <pete@akeo.ie> wrote:
>
> Commit 80bbea192aa44ab664ba8be29ac06c83f246e99c introduced a regression
> resulting in 'error A2023: undefined symbol: InternalAssertJumpBuffer'
> when compling MdePkg for AARCH64 with Visual Studio.
> Fix this by adding the relevant EXTERN reference.
>
> Signed-off-by: Pete Batard <pete@akeo.ie>
> Cc: Leif Lindholm <quic_llindhol@quicinc.com>
> Cc: Ard Biesheuvel <ardb+tianocore@kernel.org>
Reviewed-by: Ard Biesheuvel <ardb@kernel.org>
Note that the same issue has been raised two months ago, and a similar
fix proposed
https://openfw.io/edk2-devel/20240320025130.599086-1-adam.liu@tw.synaptics.com/
so IMHO this qualifies for inclusion in the stable tag.
> ---
> MdePkg/Library/BaseLib/AArch64/SetJumpLongJump.asm | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/MdePkg/Library/BaseLib/AArch64/SetJumpLongJump.asm b/MdePkg/Library/BaseLib/AArch64/SetJumpLongJump.asm
> index 6ec8f35f2c9f..fa161e25f517 100644
> --- a/MdePkg/Library/BaseLib/AArch64/SetJumpLongJump.asm
> +++ b/MdePkg/Library/BaseLib/AArch64/SetJumpLongJump.asm
> @@ -7,6 +7,7 @@
>
> EXPORT SetJump
> EXPORT InternalLongJump
> + EXTERN InternalAssertJumpBuffer
> AREA BaseLib_LowLevel, CODE, READONLY
>
> #define GPR_LAYOUT \
> --
> 2.45.0.windows.1
>
-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#118667): https://edk2.groups.io/g/devel/message/118667
Mute This Topic: https://groups.io/mt/105977470/7686176
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io]
-=-=-=-=-=-=-=-=-=-=-=-
next prev parent reply other threads:[~2024-05-08 9:07 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-05-08 8:51 [edk2-devel] [PATCH 0/1] MdePkg/BaseLib: Fix undefined symbol when compiling with Visual Studio Pete Batard via groups.io
2024-05-08 8:51 ` [edk2-devel] [PATCH 1/1] " Pete Batard via groups.io
2024-05-08 9:07 ` Ard Biesheuvel [this message]
2024-05-08 9:08 ` Ard Biesheuvel
2024-05-08 9:21 ` Pete Batard via groups.io
2024-05-08 9:39 ` Ard Biesheuvel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAMj1kXHbnMUBJycnF1P+xijk73wdVRXwXXUgJnBVc7TJv9dTnw@mail.gmail.com \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox