From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail05.groups.io (mail05.groups.io [45.79.224.7]) by spool.mail.gandi.net (Postfix) with ESMTPS id 53B9894155E for ; Wed, 8 May 2024 09:07:29 +0000 (UTC) DKIM-Signature: a=rsa-sha256; bh=ZQwhcGj+u1zIA9+Vh8gqPRGKecWNE+3cY/R6sa35xEk=; c=relaxed/simple; d=groups.io; h=MIME-Version:References:In-Reply-To:From:Date:Message-ID:Subject:To:Cc:Precedence:List-Subscribe:List-Help:Sender:List-Id:Mailing-List:Delivered-To:Resent-Date:Resent-From:Reply-To:List-Unsubscribe-Post:List-Unsubscribe:Content-Type; s=20240206; t=1715159247; v=1; b=NU0xr73+Vzzz/prVCHnDz9WIX3vLxYKGUqLgotcn0UpaXyTVTZj1/lPqr5xuGgp7KhfTaHz6 39u7MP8NTrMrphc8rt7QpGHY49XkhtlSjUOBZhLRWD5xHqJWcdD3iDRz1bU0uR9DEnLfJTjw3a9 SQQNDXWp/L0RyVU0x4/9ztptDxlQDPwUUI97XNog0RNOBtMkX5TJ8YXmELw6izf+YIRYF+JEJNY dNblP+z9QjrYgf0jNLg4X8favTMe75Dtg5AVhSPgMGeCdv0HI99DaBfrxZLdvyE79keEydC17yG uBcmXNzUQhJRPPH975hsXijVW0qhoICqEdAlVhU3BJyNA== X-Received: by 127.0.0.2 with SMTP id GNZVYY7687511xovchdxfODQ; Wed, 08 May 2024 02:07:27 -0700 X-Received: from sin.source.kernel.org (sin.source.kernel.org [145.40.73.55]) by mx.groups.io with SMTP id smtpd.web11.7704.1715159241972650899 for ; Wed, 08 May 2024 02:07:22 -0700 X-Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by sin.source.kernel.org (Postfix) with ESMTP id 21CC3CE1680 for ; Wed, 8 May 2024 09:07:19 +0000 (UTC) X-Received: by smtp.kernel.org (Postfix) with ESMTPSA id 3369CC4AF18 for ; Wed, 8 May 2024 09:07:18 +0000 (UTC) X-Received: by mail-lj1-f173.google.com with SMTP id 38308e7fff4ca-2e2b468ea12so5679051fa.1 for ; Wed, 08 May 2024 02:07:18 -0700 (PDT) X-Gm-Message-State: vXExE3nISr3WBuNEJ9s42kkBx7686176AA= X-Google-Smtp-Source: AGHT+IGtEeONmG8r1ELR+jCA0nZndbB8hw36ow7A1RGdIDraciaR+iUBHQA4SylvnViEf6CftpCAeijrpYH2JTvQrqc= X-Received: by 2002:a2e:97c2:0:b0:2e1:f38c:b598 with SMTP id 38308e7fff4ca-2e3d9b8bb89mr16400211fa.18.1715159236563; Wed, 08 May 2024 02:07:16 -0700 (PDT) MIME-Version: 1.0 References: <20240508085148.1725-1-pete@akeo.ie> <20240508085148.1725-2-pete@akeo.ie> In-Reply-To: <20240508085148.1725-2-pete@akeo.ie> From: "Ard Biesheuvel" Date: Wed, 8 May 2024 11:07:05 +0200 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [edk2-devel] [PATCH 1/1] MdePkg/BaseLib: Fix undefined symbol when compiling with Visual Studio To: Pete Batard Cc: devel@edk2.groups.io, quic_llindhol@quicinc.com, michael.d.kinney@intel.com, gaoliming@byosoft.com.cn Precedence: Bulk List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Resent-Date: Wed, 08 May 2024 02:07:22 -0700 Resent-From: ardb@kernel.org Reply-To: devel@edk2.groups.io,ardb@kernel.org List-Unsubscribe-Post: List-Unsubscribe=One-Click List-Unsubscribe: Content-Type: text/plain; charset="UTF-8" X-GND-Status: LEGIT Authentication-Results: spool.mail.gandi.net; dkim=pass header.d=groups.io header.s=20240206 header.b=NU0xr73+; dmarc=fail reason="SPF not aligned (relaxed), DKIM not aligned (relaxed)" header.from=kernel.org (policy=none); spf=pass (spool.mail.gandi.net: domain of bounce@groups.io designates 45.79.224.7 as permitted sender) smtp.mailfrom=bounce@groups.io On Wed, 8 May 2024 at 10:52, Pete Batard wrote: > > Commit 80bbea192aa44ab664ba8be29ac06c83f246e99c introduced a regression > resulting in 'error A2023: undefined symbol: InternalAssertJumpBuffer' > when compling MdePkg for AARCH64 with Visual Studio. > Fix this by adding the relevant EXTERN reference. > > Signed-off-by: Pete Batard > Cc: Leif Lindholm > Cc: Ard Biesheuvel Reviewed-by: Ard Biesheuvel Note that the same issue has been raised two months ago, and a similar fix proposed https://openfw.io/edk2-devel/20240320025130.599086-1-adam.liu@tw.synaptics.com/ so IMHO this qualifies for inclusion in the stable tag. > --- > MdePkg/Library/BaseLib/AArch64/SetJumpLongJump.asm | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/MdePkg/Library/BaseLib/AArch64/SetJumpLongJump.asm b/MdePkg/Library/BaseLib/AArch64/SetJumpLongJump.asm > index 6ec8f35f2c9f..fa161e25f517 100644 > --- a/MdePkg/Library/BaseLib/AArch64/SetJumpLongJump.asm > +++ b/MdePkg/Library/BaseLib/AArch64/SetJumpLongJump.asm > @@ -7,6 +7,7 @@ > > EXPORT SetJump > EXPORT InternalLongJump > + EXTERN InternalAssertJumpBuffer > AREA BaseLib_LowLevel, CODE, READONLY > > #define GPR_LAYOUT \ > -- > 2.45.0.windows.1 > -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#118667): https://edk2.groups.io/g/devel/message/118667 Mute This Topic: https://groups.io/mt/105977470/7686176 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io] -=-=-=-=-=-=-=-=-=-=-=-