From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from ams.source.kernel.org (ams.source.kernel.org [145.40.68.75]) by mx.groups.io with SMTP id smtpd.web08.8307.1639758851572006106 for ; Fri, 17 Dec 2021 08:34:12 -0800 Authentication-Results: mx.groups.io; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=jdX26bas; spf=pass (domain: kernel.org, ip: 145.40.68.75, mailfrom: ardb@kernel.org) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id D3A95B828FF for ; Fri, 17 Dec 2021 16:34:08 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 963BAC36AE1 for ; Fri, 17 Dec 2021 16:34:07 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1639758847; bh=uO9iDjPw4DJHPFvEdqZvWIOV6GjBFjSE4NMfSJsVxQs=; h=References:In-Reply-To:From:Date:Subject:To:Cc:From; b=jdX26bas0WkfGmjc12mtppLu8pSJduatCb/vnQURfWUmml9wxOBAQRcZVhFaSrLpo isQbu1fiegYu4/Xyl2XSSwN0xtnhNKvNL7C+jhLFd6MHHfB2ER+mcJOCW3flzq9QXH eX6UomsO+IC6xmWxdBbeX3qsyuEm+yd+DY5e9aa9w8YP/EHYnHtMrqIuRQ4SYmcFLz O8N6imfIA18BtesbgZ3Etnq/fm7dyPXkRUcSbj/Ubb/dcIUEd0UhXsU56SgL3PH++s GFkAx/ahSCCo2h3mMAQgX1Lfbzll4VllWcyRZAqG8pTcNGYV/iVXOel4VZqjhkKj1G l3POMOb4HGpUA== Received: by mail-wm1-f41.google.com with SMTP id z206so2018730wmc.1 for ; Fri, 17 Dec 2021 08:34:07 -0800 (PST) X-Gm-Message-State: AOAM532Bl3EK15mRThgdQlrLL7+5QFVrwIWJzVq4zIvZdRgABr0S12t2 +sLjPw+mhVivo6Yb3AY7sPJ/v5ax4CPZnV5iuIs= X-Google-Smtp-Source: ABdhPJyOZhFMwNXX19uF55SXYjXMP9oWxp1nBmBDeAn4nuTGMVlDrip5mJxzxF/F5wLaQhwhYGzyqEAAvl/5lg+avOs= X-Received: by 2002:a05:600c:4ed2:: with SMTP id g18mr3416646wmq.25.1639758845878; Fri, 17 Dec 2021 08:34:05 -0800 (PST) MIME-Version: 1.0 References: <20211124162330.236813-1-Pierre.Gondois@arm.com> <20211124162330.236813-4-Pierre.Gondois@arm.com> <1d258442-24c4-c155-36f9-f8f42edbefa0@arm.com> <2b637dc0-b36e-abf7-c514-c0bf568ce735@arm.com> In-Reply-To: <2b637dc0-b36e-abf7-c514-c0bf568ce735@arm.com> From: "Ard Biesheuvel" Date: Fri, 17 Dec 2021 17:33:54 +0100 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [edk2-devel] [PATCH edk2-platforms v1 03/10] Platform/ARM: Modify duplicated GUID in ArmVExpressLibSec To: edk2-devel-groups-io , Sami Mujawar Cc: Pierre Gondois , nd , Leif Lindholm , Ard Biesheuvel , xiewenyi2@huawei.com Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable On Fri, 17 Dec 2021 at 17:30, Sami Mujawar wrote: > > Hi Leif, Ard, Wenyi, > > Is it possible to review and provde feedback for this change, please? > I agree that this should be resolved, and I don't think it matters which one we change. The INF GUIDs of libraries are never used anyway, as far as I know. > > > On 17/12/2021 02:15 PM, Pierre Gondois wrote: > > Hi Sami, > > > > You are correct, as stated in Silicon/Hisilicon/Library/ArmPlatformLibH= isilicon/ArmPlatformLibSec.inf: > > > > "Based on the files under ArmPlatformPkg/ArmVExpressPkg/Library/ArmVExp= ressLibRTSM/" > > > > Thanks for updating the commit, > > > > Regards, > > > > Pierre > > > > > > > > On 12/17/21 2:59 PM, Sami Mujawar wrote: > >> Hi Pierre, > >> > >> Please find my response inline marked [SAMI]. > >> > >> Regards, > >> > >> Sami Mujawar > >> > >> > >> On 24/11/2021 04:23 PM, Pierre.Gondois@arm.com wrote: > >>> From: Pierre Gondois > >>> > >>> The two following modules have the same GUID: > >>> - Platform/ARM/VExpressPkg/Library/ > >>> ArmVExpressLibRTSM/ArmVExpressLibSec.inf > >>> - Silicon/Hisilicon/Library/ > >>> ArmPlatformLibHisilicon/ArmPlatformLibSec.inf > >>> > >>> The inf file in the Platform/ARM/ folder is based > >>> on the one in Silicon/Hisilicon/. Modify the one > >> [SAMI] I believe you want to say the inf file in Silicon/Hisilicon/is = based on the one in Platform/ARM and therefore you are modifying the inf fi= le in Silicon/Hisilicon. > >> Please let me know if this is correct, and I will update this in the c= ommit message before merging the change. > >> [/SAMI] > >>> in the Silicon/Hisilicon/. > >>> > >>> Signed-off-by: Pierre Gondois > >>> --- > >>> .../Library/ArmPlatformLibHisilicon/ArmPlatformLibSec.inf | = 2 +- > >>> 1 file changed, 1 insertion(+), 1 deletion(-) > >>> > >>> diff --git a/Silicon/Hisilicon/Library/ArmPlatformLibHisilicon/ArmPla= tformLibSec.inf b/Silicon/Hisilicon/Library/ArmPlatformLibHisilicon/ArmPlat= formLibSec.inf > >>> index ac587deedfd8..7fd7b5183e5b 100644 > >>> --- a/Silicon/Hisilicon/Library/ArmPlatformLibHisilicon/ArmPlatformLi= bSec.inf > >>> +++ b/Silicon/Hisilicon/Library/ArmPlatformLibHisilicon/ArmPlatformLi= bSec.inf > >>> @@ -12,7 +12,7 @@ > >>> [Defines] > >>> INF_VERSION =3D 0x00010005 > >>> BASE_NAME =3D ArmPlatformLibSec > >>> - FILE_GUID =3D a79eed97-4b98-4974-9690-37b32d6= a5b56 > >>> + FILE_GUID =3D ABF3B82B-892F-438F-901F-F148C2D= F89E6 > >>> MODULE_TYPE =3D BASE > >>> VERSION_STRING =3D 1.0 > >>> LIBRARY_CLASS =3D ArmPlatformLib > >>> -- > >>> 2.25.1 > > IMPORTANT NOTICE: The contents of this email and any attachments are conf= idential and may also be privileged. If you are not the intended recipient,= please notify the sender immediately and do not disclose the contents to a= ny other person, use it for any purpose, or store or copy the information i= n any medium. Thank you. > > >=20 > >