From: "Ard Biesheuvel" <ardb@kernel.org>
To: "Yao, Jiewen" <jiewen.yao@intel.com>
Cc: "Li, Yi1" <yi1.li@intel.com>, Gerd Hoffmann <kraxel@redhat.com>,
"devel@edk2.groups.io" <devel@edk2.groups.io>,
"Hou, Wenxing" <wenxing.hou@intel.com>,
"Kinney, Michael D" <michael.d.kinney@intel.com>,
Pedro Falcato <pedro.falcato@gmail.com>
Subject: Re: [edk2-devel] CryptoPkg host test broken due to smoketest for RDRAND
Date: Fri, 14 Jun 2024 18:13:55 +0200 [thread overview]
Message-ID: <CAMj1kXHdUVnwGmNFTWSgPUVa1DZsmBSXtx3JMtr8W9UcE3Hqpg@mail.gmail.com> (raw)
In-Reply-To: <MW4PR11MB58720BDDCC95276EF71FDEE88CC22@MW4PR11MB5872.namprd11.prod.outlook.com>
On Fri, 14 Jun 2024 at 18:09, Yao, Jiewen <jiewen.yao@intel.com> wrote:
>
> Hey
> This PR seems just a workaround.
>
> I don't feel it is right solution to hardcode BIT30.
> What if the host platform does not have such capability? You will get failure later.
>
Agreed. But that was already the case: RngLib assumed that RDRAND was
implemented without checking CPUID at all, and so the code was already
broken on systems without RDRAND.
>
> To fix this function, can we call real CPUID instruction to return real value?
>
That would be better. But this change just restores the old behavior.
And on top of that, Yi Li already merged it.
-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#119575): https://edk2.groups.io/g/devel/message/119575
Mute This Topic: https://groups.io/mt/106666288/7686176
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io]
-=-=-=-=-=-=-=-=-=-=-=-
next prev parent reply other threads:[~2024-06-14 16:14 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-06-14 7:07 [edk2-devel] CryptoPkg host test broken due to smoketest for RDRAND Li, Yi
2024-06-14 7:19 ` Yao, Jiewen
2024-06-14 7:24 ` Li, Yi
2024-06-14 7:51 ` Ard Biesheuvel
2024-06-14 14:20 ` Li, Yi
2024-06-14 10:41 ` Gerd Hoffmann
2024-06-14 13:32 ` Li, Yi
2024-06-14 16:09 ` Yao, Jiewen
2024-06-14 16:13 ` Ard Biesheuvel [this message]
2024-06-14 16:45 ` Yao, Jiewen
2024-06-14 17:16 ` Ard Biesheuvel
2024-06-15 4:54 ` Li, Yi
2024-06-15 4:57 ` Michael D Kinney
2024-06-15 5:18 ` Li, Yi
2024-06-15 3:11 ` Li, Yi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAMj1kXHdUVnwGmNFTWSgPUVa1DZsmBSXtx3JMtr8W9UcE3Hqpg@mail.gmail.com \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox