From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail05.groups.io (mail05.groups.io [45.79.224.7]) by spool.mail.gandi.net (Postfix) with ESMTPS id 444E9AC1260 for ; Fri, 14 Jun 2024 16:14:15 +0000 (UTC) DKIM-Signature: a=rsa-sha256; bh=fZVB75F2EeoZpVVj9H3ccEaMzzLEhst6sqUp2uzebGQ=; c=relaxed/simple; d=groups.io; h=MIME-Version:References:In-Reply-To:From:Date:Message-ID:Subject:To:Cc:Precedence:List-Subscribe:List-Help:Sender:List-Id:Mailing-List:Delivered-To:Resent-Date:Resent-From:Reply-To:List-Unsubscribe-Post:List-Unsubscribe:Content-Type; s=20240206; t=1718381655; v=1; b=wWuQOuBV5qyEAQIPVFW8WDlpjYptC8dm1Gw0PSGnvQLkeI7tMgw66OCO6Qmpbfm1EnDFsmBG QlVqobfY0THLm6aAnXLD6x4WyngMHIlfPW2KYnbK+0lQFJJjX9Z99OFx1BhSyGDsKmeJB98mxlB nOLKXfHhPoVxFrTBKHf0lEY3jXky4RfXVZbPyPdddJU3LaxUUhI/xD5sBQPFh2lswGny5Y96jZ7 5mvDSzHmL1uALvAHwJxlx6HRvDST0wKm/Vpa098xaGj2cPr6/F36X9SiDhACNAMPWg0s8WBk/Am CE5vWMdvf3W1o7dh07zRy09z15T2VZDZuns0Wqy3NBBHQ== X-Received: by 127.0.0.2 with SMTP id 2l5iYY7687511x4DOu55SHux; Fri, 14 Jun 2024 09:14:13 -0700 X-Received: from sin.source.kernel.org (sin.source.kernel.org [145.40.73.55]) by mx.groups.io with SMTP id smtpd.web11.15803.1718381652375067605 for ; Fri, 14 Jun 2024 09:14:12 -0700 X-Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by sin.source.kernel.org (Postfix) with ESMTP id 4E1A9CE2B8C for ; Fri, 14 Jun 2024 16:14:09 +0000 (UTC) X-Received: by smtp.kernel.org (Postfix) with ESMTPSA id 5D2B4C4AF1D for ; Fri, 14 Jun 2024 16:14:08 +0000 (UTC) X-Received: by mail-lf1-f51.google.com with SMTP id 2adb3069b0e04-52bc121fb1eso2887666e87.1 for ; Fri, 14 Jun 2024 09:14:08 -0700 (PDT) X-Forwarded-Encrypted: i=1; AJvYcCU8XhEq49Vzn4F5lOqGeLalc6o+2yJQBF1bp7c6eLr1GEiOdAt2bYHf4fppW+Br6l45QtxpKmwfQgldEJARf1UYzitVcA== X-Gm-Message-State: 7dyo0NpZTJcvD91BoAwoFtPix7686176AA= X-Google-Smtp-Source: AGHT+IEShjKAueqpXTr6DenN41UoOwXdaYteybVQ5/Ty74LQUap6AbUdwvPF6Q7YTfBgtYgLuxcU90Z+7hU5VDHxXUE= X-Received: by 2002:ac2:442c:0:b0:52c:7a2d:5d5d with SMTP id 2adb3069b0e04-52ca6e55e77mr2019542e87.3.1718381646718; Fri, 14 Jun 2024 09:14:06 -0700 (PDT) MIME-Version: 1.0 References: <3kj5r4awgurnnlqm67pvpumo4rwwhounzgynydtdohs7cif4qw@edfavg3ztcaq> In-Reply-To: From: "Ard Biesheuvel" Date: Fri, 14 Jun 2024 18:13:55 +0200 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [edk2-devel] CryptoPkg host test broken due to smoketest for RDRAND To: "Yao, Jiewen" Cc: "Li, Yi1" , Gerd Hoffmann , "devel@edk2.groups.io" , "Hou, Wenxing" , "Kinney, Michael D" , Pedro Falcato Precedence: Bulk List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Resent-Date: Fri, 14 Jun 2024 09:14:12 -0700 Resent-From: ardb@kernel.org Reply-To: devel@edk2.groups.io,ardb@kernel.org List-Unsubscribe-Post: List-Unsubscribe=One-Click List-Unsubscribe: Content-Type: text/plain; charset="UTF-8" X-GND-Status: LEGIT Authentication-Results: spool.mail.gandi.net; dkim=pass header.d=groups.io header.s=20240206 header.b=wWuQOuBV; dmarc=fail reason="SPF not aligned (relaxed), DKIM not aligned (relaxed)" header.from=kernel.org (policy=none); spf=pass (spool.mail.gandi.net: domain of bounce@groups.io designates 45.79.224.7 as permitted sender) smtp.mailfrom=bounce@groups.io On Fri, 14 Jun 2024 at 18:09, Yao, Jiewen wrote: > > Hey > This PR seems just a workaround. > > I don't feel it is right solution to hardcode BIT30. > What if the host platform does not have such capability? You will get failure later. > Agreed. But that was already the case: RngLib assumed that RDRAND was implemented without checking CPUID at all, and so the code was already broken on systems without RDRAND. > > To fix this function, can we call real CPUID instruction to return real value? > That would be better. But this change just restores the old behavior. And on top of that, Yi Li already merged it. -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#119575): https://edk2.groups.io/g/devel/message/119575 Mute This Topic: https://groups.io/mt/106666288/7686176 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io] -=-=-=-=-=-=-=-=-=-=-=-