From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by mx.groups.io with SMTP id smtpd.web08.11229.1619614821665908083 for ; Wed, 28 Apr 2021 06:00:21 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=lNQERMB0; spf=pass (domain: kernel.org, ip: 198.145.29.99, mailfrom: ardb@kernel.org) Received: by mail.kernel.org (Postfix) with ESMTPSA id 8BE73610A5 for ; Wed, 28 Apr 2021 13:00:20 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1619614820; bh=Ci5kB0jPcZ2XlwbLEbuu6jHoOSE9WsAYyNjVIeSQNo8=; h=References:In-Reply-To:From:Date:Subject:To:Cc:From; b=lNQERMB0B0rRxia/tjPtH9UAumshsxtKKz3JnENoPP3ggjs6IlPJc+ws402riabeH 1weQRt19v/HBZ7+w98uZitgnQuTQtpNJk6mHJnTLeyrMY2OZ+ALszJ2qz3epZS+hrG gois25YUNTs4Qqk5YaBw8iD/4Jo6uFGOzs4oaSqfC7hBwIOi4GPVhXi9qQLPWvcmTD 1n/nRcWc2E0Mgl6q6jhWdseXlpHusaC0O8JiyMtH6r+PpB0c70AZQ8pvEQibC46oBn 3pYbleGxhfbjh6EDvmIMsPFXtoO6OEyOXIfDELWwEWWLxKN2nTnmeY26FEw0YsterL HvCpVTkSOrBYw== Received: by mail-oi1-f182.google.com with SMTP id i81so62949811oif.6 for ; Wed, 28 Apr 2021 06:00:20 -0700 (PDT) X-Gm-Message-State: AOAM5319m/Ok5WB3odb4C++HH1hTURbZ8VWiUhOBhcCoFY/81yVx/jeW pRUG50NM+Y0KIz16GOxh83UALf8DkEwa64VUwpM= X-Google-Smtp-Source: ABdhPJzKCotpRt35/fjIGtwjC9jiRjYchTyY4Xv9RwBxPxsYmClMW9u+yeAcZ5iNt0yTFmaYkXxPPLvCO9fQR71b4RA= X-Received: by 2002:aca:bb09:: with SMTP id l9mr20376735oif.33.1619614819752; Wed, 28 Apr 2021 06:00:19 -0700 (PDT) MIME-Version: 1.0 References: <20210428102020.2311-1-Pierre.Gondois@arm.com> In-Reply-To: <20210428102020.2311-1-Pierre.Gondois@arm.com> From: "Ard Biesheuvel" Date: Wed, 28 Apr 2021 15:00:08 +0200 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH v3 00/15] ArmPkg/ArmPlatformPkg CI enablement To: Pierre Cc: edk2-devel-groups-io , Sami Mujawar , Leif Lindholm , Ard Biesheuvel , Sean Brogan , Bret Barkelew Content-Type: text/plain; charset="UTF-8" On Wed, 28 Apr 2021 at 12:20, wrote: > > From: Pierre Gondois > > Enable upstream CI for the ArmPkg and ArmPlatformPkg. > Bugzilla tickets have been created for their enablement: > ArmPkg: > https://bugzilla.tianocore.org/show_bug.cgi?id=3349 > ArmPlatformPkg: > https://bugzilla.tianocore.org/show_bug.cgi?id=3348 > > The patch-set also fixes some Ecc reported errors, spelling and > CI reported errors. The following bugzillas should be resolved: > https://bugzilla.tianocore.org/show_bug.cgi?id=3258 > https://bugzilla.tianocore.org/show_bug.cgi?id=3254 > > The changes can be seen at: > https://github.com/PierreARM/edk2/tree/1409_Enable_CI_for_Arm_Packages_v3 > > V2: > - Remove "eoi'ed" from the list of exceptions of the spell > checker and re-phrase sentences where "eoi'ed" was used. [Sami] > - Add documentation to the advertised libraries in > ArmPkg and ArmPlatformPkg. [Bret] > - Alphabetically re-order libraries in ArmPkg.dec. [Pierre] > - Replace TARGET_ARM to TARGET_ARM_ARMPLATFORM [Bret] > V3: > - Correctly assign the library descriptions to > their library in ArmPkg.dec. [Sami] > > Pierre Gondois (15): > ArmPkg: Fix Ecc error 8003 > ArmPkg: Fix Ecc error 3002 in StandaloneMmMmuLib > ArmPkg: Add missing library headers to ArmPkg.dec > ArmPlatformPkg: Document libraries in ArmPlatformPkg.dec > ArmPkg: Document libraries in ArmPkg.dec > ArmPkg: Re-order libraries in ArmPkg.dec > ArmPkg: Add OemMiscLibNull library to ArmPkg.dsc > ArmPkg: Correct small typos > ArmPkg: Add ArmPkg.ci.yaml > ArmPlatformPkg: Add ArmPlatformPkg.ci.yaml > .pytool: Enable CI for ArmPkg > .pytool: Enable CI for ArmPlatformPkg > .pytool: Document LicenseCheck and EccCheck > AzurePipelines: Add support for ArmPkg > AzurePipelines: Add support for ArmPlatformPkg > Thank you Pierre. Merged as #1605 > .../templates/pr-gate-build-job.yml | 3 + > .pytool/CISettings.py | 4 +- > .pytool/Readme.md | 14 +- > ArmPkg/ArmPkg.ci.yaml | 221 ++++++++++++++++++ > ArmPkg/ArmPkg.dec | 65 +++++- > ArmPkg/ArmPkg.dsc | 1 + > ArmPkg/Drivers/ArmGic/ArmGicDxe.h | 6 +- > ArmPkg/Drivers/ArmGic/GicV2/ArmGicV2Dxe.c | 2 +- > ArmPkg/Drivers/ArmGic/GicV3/ArmGicV3Dxe.c | 2 +- > ArmPkg/Drivers/CpuDxe/Arm/Mmu.c | 2 +- > ArmPkg/Drivers/CpuDxe/CpuDxe.h | 6 +- > .../GenericWatchdogDxe/GenericWatchdog.h | 6 +- > ArmPkg/Filesystem/SemihostFs/Arm/SemihostFs.c | 2 +- > ArmPkg/Filesystem/SemihostFs/Arm/SemihostFs.h | 6 +- > ArmPkg/Include/AsmMacroIoLib.h | 6 +- > ArmPkg/Include/AsmMacroIoLibV8.h | 6 +- > ArmPkg/Include/Chipset/AArch64.h | 6 +- > ArmPkg/Include/Chipset/AArch64Mmu.h | 6 +- > ArmPkg/Include/Chipset/ArmCortexA9.h | 6 +- > ArmPkg/Include/Chipset/ArmV7.h | 6 +- > ArmPkg/Include/Chipset/ArmV7Mmu.h | 6 +- > ArmPkg/Include/Guid/ArmMpCoreInfo.h | 6 +- > ArmPkg/Include/IndustryStandard/ArmMmSvc.h | 6 +- > ArmPkg/Include/IndustryStandard/ArmStdSmc.h | 6 +- > ArmPkg/Include/Library/ArmDisassemblerLib.h | 6 +- > .../Library/ArmGenericTimerCounterLib.h | 6 +- > ArmPkg/Include/Library/ArmGicArchLib.h | 6 +- > ArmPkg/Include/Library/ArmHvcLib.h | 6 +- > ArmPkg/Include/Library/ArmLib.h | 6 +- > ArmPkg/Include/Library/ArmMmuLib.h | 6 +- > ArmPkg/Include/Library/ArmSmcLib.h | 6 +- > ArmPkg/Include/Library/ArmSvcLib.h | 6 +- > .../Library/DefaultExceptionHandlerLib.h | 6 +- > ArmPkg/Include/Library/OpteeLib.h | 6 +- > ArmPkg/Include/Library/SemihostLib.h | 6 +- > ArmPkg/Include/Library/StandaloneMmMmuLib.h | 6 +- > ArmPkg/Include/Ppi/ArmMpCoreInfo.h | 6 +- > ArmPkg/Library/ArmLib/AArch64/AArch64Lib.h | 6 +- > ArmPkg/Library/ArmLib/Arm/ArmV7Lib.h | 6 +- > ArmPkg/Library/ArmLib/ArmLibPrivate.h | 6 +- > .../Library/ArmMmuLib/Arm/ArmMmuLibUpdate.c | 4 +- > ArmPkg/Library/OpteeLib/OpteeSmc.h | 6 +- > .../PlatformBootManagerLib/PlatformBm.h | 6 +- > .../SemiHostingSerialPortLib/SerialPortLib.c | 6 +- > ArmPkg/Library/SemihostLib/SemihostPrivate.h | 6 +- > .../AArch64/ArmMmuStandaloneMmLib.c | 4 +- > ...MiscNumberOfInstallableLanguagesFunction.c | 6 +- > ArmPlatformPkg/ArmPlatformPkg.ci.yaml | 100 ++++++++ > ArmPlatformPkg/ArmPlatformPkg.dec | 19 +- > 49 files changed, 530 insertions(+), 123 deletions(-) > create mode 100644 ArmPkg/ArmPkg.ci.yaml > create mode 100644 ArmPlatformPkg/ArmPlatformPkg.ci.yaml > > -- > 2.17.1 >