From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217])
 by mx.groups.io with SMTP id smtpd.web12.668.1664314767117593477
 for <devel@edk2.groups.io>;
 Tue, 27 Sep 2022 14:39:27 -0700
Authentication-Results: mx.groups.io;
 dkim=pass header.i=@kernel.org header.s=k20201202 header.b=LBVqOoim;
 spf=pass (domain: kernel.org, ip: 139.178.84.217, mailfrom: ardb@kernel.org)
Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140])
	(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
	(No client certificate requested)
	by dfw.source.kernel.org (Postfix) with ESMTPS id 662AC61B44
	for <devel@edk2.groups.io>; Tue, 27 Sep 2022 21:39:26 +0000 (UTC)
Received: by smtp.kernel.org (Postfix) with ESMTPSA id CA469C433D7
	for <devel@edk2.groups.io>; Tue, 27 Sep 2022 21:39:25 +0000 (UTC)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org;
	s=k20201202; t=1664314765;
	bh=QQQ0Q5QFyFD+7JpvUW4ZE95jumi/lE1pE+Vt9A6CuHU=;
	h=From:Date:Subject:To:From;
	b=LBVqOoimmA6JsRUh7IKDhy8hr1gQgvDzw26TkdoDMdDsU+ShKp70ApIrHbi0u8Blc
	 4YioGaW5IiT0xtIGYNbYhFOFnQBXKe9P0mrR4n6EYnGuKwOXbuCbhSKJw9AK9D/xyY
	 K4Fqe6r3xZu1drIVYp/QwqtG4qEH4fRLXNfEj/UA0jmnvL5I8ssxuBaDIJAlds3/Jv
	 pVbpmc8iIuwSyQ8BPVRRNCFSuvxbjWgex/fKA4K634gLncagyjF4Zkc60ZHVAp9oi0
	 hmr7rwPPMIdIWg8/tshVyp0+I7wVywxhp8Uwbgvo+UvsSknyW0CTUfO0xbEQ2GwdW7
	 ctFABveMsokxg==
Received: by mail-lf1-f47.google.com with SMTP id o2so17579886lfc.10
        for <devel@edk2.groups.io>; Tue, 27 Sep 2022 14:39:25 -0700 (PDT)
X-Gm-Message-State: ACrzQf0iDn26s29qiFMQG5EHv3o8T1o3/AKkIuoyIdb1nLyCoWYAAnBI
	9mx2rJvrJB3q5sPY5nXt3bM115D6ePpAWIsiLW0=
X-Google-Smtp-Source: AMsMyM7f8E1aRRr917CvvCFTLqCtU+wlBD9C68VHfjnYyx3R1vb/Mka+vDNSFAzPkRIbmyA8HkOdqatVQieme0paJwU=
X-Received: by 2002:a05:6512:3da0:b0:4a1:e17a:2305 with SMTP id
 k32-20020a0565123da000b004a1e17a2305mr3508632lfv.228.1664314763791; Tue, 27
 Sep 2022 14:39:23 -0700 (PDT)
MIME-Version: 1.0
From: "Ard Biesheuvel" <ardb@kernel.org>
Date: Tue, 27 Sep 2022 23:39:12 +0200
X-Gmail-Original-Message-ID: <CAMj1kXHfUS=eSiE8T=rTWwXSy7qjFFctPS90vOg5CyqvbUL8Gg@mail.gmail.com>
Message-ID: <CAMj1kXHfUS=eSiE8T=rTWwXSy7qjFFctPS90vOg5CyqvbUL8Gg@mail.gmail.com>
Subject: version handling for EFI v2.10
To: edk2-devel-groups-io <devel@edk2.groups.io>, Michael Kinney <michael.d.kinney@intel.com>, 
	Leif Lindholm <quic_llindhol@quicinc.com>, Andrew Fish <afish@apple.com>, 
	Samer El-Haj-Mahmoud <Samer.El-Haj-Mahmoud@arm.com>
Content-Type: text/plain; charset="UTF-8"

Hello all,

I just noticed the v2.10 of the UEFI spec. It adds the following define

#define EFI_2_100_SYSTEM_TABLE_REVISION ((2<<16) | (100)

However, the revision field is documented as

"""
The revision of the EFI Specification to which this table conforms.
The upper 16 bits of this field contain the major revision value, and
the lower 16 bits contain the minor revision value. The minor revision
values are binary coded decimals and are limited to the range of
00..99.
"""

I'm not sure what 'binary coded decimals' is supposed to mean here,
given that we use ordinary decimals (30 == 30, and 0x30 == 48 not 30).
However, the range 00..99 is obviously decimal, and 100 is obviously
outside of that range, so something is out of whack here.

Not too important, but I was trying to adapt the Linux revision
reporting to the latest update, and the inconsistency makes that a bit
tricky.

Thanks,
Ard.