From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from ams.source.kernel.org (ams.source.kernel.org [145.40.68.75]) by mx.groups.io with SMTP id smtpd.web08.51056.1643735068840737981 for ; Tue, 01 Feb 2022 09:04:29 -0800 Authentication-Results: mx.groups.io; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=IQtrbym2; spf=pass (domain: kernel.org, ip: 145.40.68.75, mailfrom: ardb@kernel.org) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id 585FAB82EFC for ; Tue, 1 Feb 2022 17:04:27 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 2CD11C340EB for ; Tue, 1 Feb 2022 17:04:26 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1643735066; bh=09NBCaUQFXEk23zTTDl0fp5dPMH5Y93qUAyKbURO6BQ=; h=References:In-Reply-To:From:Date:Subject:To:Cc:From; b=IQtrbym2rxl1o9sj+iMoiWE0BZvFxPWEF52iySYw6tPK0gYbGpKVmg3o0LcTBf2V8 8+XGkLfai3soDUQ9lR1txdeR5E+SLeu+0AfzRwn7PgFknfaeebMlMKB4bkO3TjK8Qx A/smRNDAVJ9vzGeQSGQ0esfIocONL04ELW8/ypV8WH3qMph3uCHFPygZkcsY0Ez+iF i0h9uZ7AqYwvsWK2v5PAX4hwQeyup8ZMkZ75TMf6Clr6ipfllBfY1fJx5d9HaOgzoy CxKNaLRcgE2YpSjguBZ43qNuiC4Hy/bHh7rMl9RmTgBhV7ZjxW70PQXcxBfbdn+Gwv yR1CpPgpoU/TA== Received: by mail-wr1-f51.google.com with SMTP id s18so33255067wrv.7 for ; Tue, 01 Feb 2022 09:04:26 -0800 (PST) X-Gm-Message-State: AOAM533wdBMpvNKjYOgrLcws417EVfemgvOn/QR89v8/R4NU4Cxia2jI TacBN7QEaWyyPtScbK9DXakMEk0UN/Fl1bo+XUA= X-Google-Smtp-Source: ABdhPJxZVGDlfreAN1/AQ1IqZnJBwBF0DkeYXM0XbhKipo45015hGOA4VpY1ullOvZE5cxW8vL1KQKaOWd8lQgiJLNM= X-Received: by 2002:a05:6000:1107:: with SMTP id z7mr22131943wrw.189.1643735064461; Tue, 01 Feb 2022 09:04:24 -0800 (PST) MIME-Version: 1.0 References: <20220128154103.20752-1-Pierre.Gondois@arm.com> <20220128154103.20752-6-Pierre.Gondois@arm.com> <52503b9c-c820-15b3-65c5-f2cc110f5027@quicinc.com> <60a12a54-1860-f7b8-f4f1-144cf19f347f@arm.com> <04ae07d5-4340-eca6-469b-41fb5a74a4e0@arm.com> In-Reply-To: <04ae07d5-4340-eca6-469b-41fb5a74a4e0@arm.com> From: "Ard Biesheuvel" Date: Tue, 1 Feb 2022 18:04:12 +0100 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [edk2-devel] [PATCH v3 5/8] ArmVirtPkg/Kvmtool: Add DSDT ACPI table To: Pierre Gondois Cc: Sami Mujawar , Rebecca Cran , "devel@edk2.groups.io" , Ard Biesheuvel , nd Content-Type: text/plain; charset="UTF-8" On Tue, 1 Feb 2022 at 18:02, Pierre Gondois wrote: > > > > On 2/1/22 5:56 PM, Ard Biesheuvel wrote: > > On Tue, 1 Feb 2022 at 17:56, Ard Biesheuvel wrote: > >> > >> On Tue, 1 Feb 2022 at 17:55, Pierre Gondois wrote: > >>> > >>> Hi Rebecca, > >>> > >>> On 1/31/22 4:21 PM, Sami Mujawar wrote: > >>>> Hi Rebecca, > >>>> > >>>> Thanks for catching this. > >>>> > >>>> I think we also need to adda check in Acpiview to report this issue. However, > >>>> that would be another patch series. > >>>> > >>>> Regards, > >>>> > >>>> Sami Mujawar > >>>> > >>>> *From: *Rebecca Cran > >>>> *Date: *Monday, 31 January 2022 at 15:17 > >>>> *To: *devel@edk2.groups.io , Pierre Gondois > >>>> > >>>> *Cc: *Ard Biesheuvel , Sami Mujawar > >>>> > >>>> *Subject: *Re: [edk2-devel] [PATCH v3 5/8] ArmVirtPkg/Kvmtool: Add DSDT ACPI table > >>>> > >>>> On 1/28/22 08:41, PierreGondois wrote: > >>>> > >>>>> + Differentiated System Description Table Fields (DSDT) > >>>>> + > >>>>> + Copyright (c) 2021 - 2022, ARM Ltd. All rights reserved.
> >>>>> + SPDX-License-Identifier: BSD-2-Clause-Patent > >>>>> + > >>>>> +**/ > >>>>> + > >>>>> +DefinitionBlock ("DsdtTable.aml", "DSDT", 1, "ARMLTD", "ARM-KVMT", 1) { > >>>> > >>>> The Revision field should probably be 2, not 1. ACPI 6.4 says: > >>>> > >>>> > >>>> 2. This field also sets the global integer width for the AML > >>>> interpreter. Values less than two will cause the inter- > >>>> preter to use 32-bit integers and math. Values of two > >>>> and greater will cause the interpreter to use full 64-bit > >>>> integers and math. > >>>> > >>>> -- > >>>> Rebecca Cran > >>>> > >>> > >>> Yes indeed. I forgot to add it in the v4... I will send a v5. > >> > >> Please give me a minute before sending another version. > >> > >> I am still seeing > > > > No ACPI PMU IRQ for CPU26 > > > > errors and I am trying to figure out why. > > > > There is a --pmu option in kvmtool, we are not populating pmu > interrupts if kvmtool doesn't receive this option. Maybe this is it ? Yes you are right. So this is all looking fine now - I tested booting Linux with pci=nomsi, and the legacy interrupts are level and working as expected.