From: "Ard Biesheuvel" <ardb@kernel.org>
To: Pierre.Gondois@arm.com
Cc: devel@edk2.groups.io, Ard Biesheuvel <ardb+tianocore@kernel.org>,
Thomas Abraham <thomas.abraham@arm.com>,
Sami Mujawar <sami.mujawar@arm.com>
Subject: Re: [PATCH edk2-platforms 1/1] Platform/Sgi: Use MmUnblockMemoryLib when SECURE_STORAGE_ENABLE
Date: Wed, 14 Dec 2022 09:38:11 +0100 [thread overview]
Message-ID: <CAMj1kXHffHhwhVex8xpO5vbjrCw0Yt1KRqp0Dqspx2AJGGdQwQ@mail.gmail.com> (raw)
In-Reply-To: <20221214083348.1467596-1-Pierre.Gondois@arm.com>
On Wed, 14 Dec 2022 at 09:34, <Pierre.Gondois@arm.com> wrote:
>
> From: Pierre Gondois <pierre.gondois@arm.com>
>
> Building the RdV1 platform fails when only providing the
> '-D SECURE_STORAGE_ENABLE' flag due to MmUnblockMemoryLib missing.
>
> Signed-off-by: Pierre Gondois <Pierre.Gondois@arm.com>
> ---
> Platform/ARM/SgiPkg/SgiPlatform.dsc.inc | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/Platform/ARM/SgiPkg/SgiPlatform.dsc.inc b/Platform/ARM/SgiPkg/SgiPlatform.dsc.inc
> index 81764368a0b7..b36c130722b6 100644
> --- a/Platform/ARM/SgiPkg/SgiPlatform.dsc.inc
> +++ b/Platform/ARM/SgiPkg/SgiPlatform.dsc.inc
> @@ -38,7 +38,7 @@ [LibraryClasses.common]
> HobLib|MdePkg/Library/DxeHobLib/DxeHobLib.inf
> ResetSystemLib|ArmPkg/Library/ArmSmcPsciResetSystemLib/ArmSmcPsciResetSystemLib.inf
> TimerLib|ArmPkg/Library/ArmArchTimerLib/ArmArchTimerLib.inf
> -!if $(SECURE_BOOT_ENABLE) == TRUE
> +!if ($(SECURE_BOOT_ENABLE) == TRUE) || ($(SECURE_STORAGE_ENABLE) == TRUE)
> MmUnblockMemoryLib|MdePkg/Library/MmUnblockMemoryLib/MmUnblockMemoryLibNull.inf
> !endif
>
Thanks for the fix. However, if MmUnblockMemoryLib is just a library
resolution that is always satisfied by the same implementation,
couldn't we drop the conditional altogether?
next prev parent reply other threads:[~2022-12-14 8:38 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-12-14 8:33 [PATCH edk2-platforms 1/1] Platform/Sgi: Use MmUnblockMemoryLib when SECURE_STORAGE_ENABLE PierreGondois
2022-12-14 8:38 ` Ard Biesheuvel [this message]
2022-12-14 8:58 ` PierreGondois
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAMj1kXHffHhwhVex8xpO5vbjrCw0Yt1KRqp0Dqspx2AJGGdQwQ@mail.gmail.com \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox