From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by spool.mail.gandi.net (Postfix) with ESMTPS id 5C7D9D80A13 for ; Tue, 8 Aug 2023 16:25:55 +0000 (UTC) DKIM-Signature: a=rsa-sha256; bh=dj6muqbtDfmtcMs22oBi1q5gnmHS06gha9ZRYMVh1lQ=; c=relaxed/simple; d=groups.io; h=MIME-Version:References:In-Reply-To:From:Date:Message-ID:Subject:To:Cc:Precedence:List-Subscribe:List-Help:Sender:List-Id:Mailing-List:Delivered-To:Reply-To:List-Unsubscribe-Post:List-Unsubscribe:Content-Type; s=20140610; t=1691511953; v=1; b=Srcst5XvcvOvQpR2aCDXIeI3IDhhc5HhuCKT2dY3IQ5wU3mjAax9mE5w93LO/RN/4Fg3d4xL s/OGVBlT55wASwMs1kFcXdRx/6u2+dtBZ4gj1pqc51CiXFxWGJu53OCqht63pgH2qX3Z7yr24Et rbnV2wMWR7vSjQ8q7tMC63DI= X-Received: by 127.0.0.2 with SMTP id IwotYY7687511xxDGBYlZm8s; Tue, 08 Aug 2023 09:25:53 -0700 X-Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by mx.groups.io with SMTP id smtpd.web10.66328.1691511953334811857 for ; Tue, 08 Aug 2023 09:25:53 -0700 X-Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id AF3426252F for ; Tue, 8 Aug 2023 16:25:52 +0000 (UTC) X-Received: by smtp.kernel.org (Postfix) with ESMTPSA id 1B61FC433C8 for ; Tue, 8 Aug 2023 16:25:52 +0000 (UTC) X-Received: by mail-lf1-f44.google.com with SMTP id 2adb3069b0e04-4fe0d5f719dso9698341e87.2 for ; Tue, 08 Aug 2023 09:25:52 -0700 (PDT) X-Gm-Message-State: 5KT5MbgKQvgDlYaMYRbStzQMx7686176AA= X-Google-Smtp-Source: AGHT+IEcS14hIxpALfwXu7+SW/3tfYRY3XD1JEu3ffPTJK1ppfWobXC4bTXOTIC9cV0q7tLo88qGKNQZ0LmWoIBAyNA= X-Received: by 2002:ac2:54a8:0:b0:4f8:49a7:2deb with SMTP id w8-20020ac254a8000000b004f849a72debmr2066lfk.8.1691511950118; Tue, 08 Aug 2023 09:25:50 -0700 (PDT) MIME-Version: 1.0 References: <20230724130006.427522-1-corvink@FreeBSD.org> <20230724130006.427522-2-corvink@FreeBSD.org> <899bbdac-5aa3-50c4-f6e2-926b7a22c799@bsdio.com> In-Reply-To: <899bbdac-5aa3-50c4-f6e2-926b7a22c799@bsdio.com> From: "Ard Biesheuvel" Date: Tue, 8 Aug 2023 18:25:38 +0200 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [edk2-devel] [PATCH v1 1/1] OvmfPkg/Bhyve: build platform info HOB To: Rebecca Cran , Michael Kinney , Michael Kubacki Cc: =?UTF-8?Q?Corvin_K=C3=B6hne?= , devel@edk2.groups.io, Jiewen Yao , Jordan Justen , Gerd Hoffmann , Peter Grehan Precedence: Bulk List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,ardb@kernel.org List-Unsubscribe-Post: List-Unsubscribe=One-Click List-Unsubscribe: Content-Type: text/plain; charset="UTF-8" X-GND-Status: LEGIT Authentication-Results: spool.mail.gandi.net; dkim=pass header.d=groups.io header.s=20140610 header.b=Srcst5Xv; spf=pass (spool.mail.gandi.net: domain of bounce@groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce@groups.io; dmarc=fail reason="SPF not aligned (relaxed), DKIM not aligned (relaxed)" header.from=kernel.org (policy=none) On Tue, 8 Aug 2023 at 15:33, Rebecca Cran wrote: > > Nit: "sizeof" is normally used like a function. And this patch mixes the > two styles. > Actually, this is not unidiomatic for OVMF - sizeof takes either a type name (in which case the () are required) or an expression (in which case they are optional), and we have always permitted both idioms for the latter case. $ git grep -cE 'sizeof\s*[:alnum:]' OvmfPkg/ OvmfPkg/Bhyve/BhyveRfbDxe/VbeShim.c:4 OvmfPkg/EnrollDefaultKeys/AuthData.c:4 OvmfPkg/IncompatiblePciDeviceSupportDxe/IncompatiblePciDeviceSupport.c:7 OvmfPkg/Library/PciHostBridgeUtilityLib/PciHostBridgeUtilityLib.c:1 OvmfPkg/PlatformPei/MemTypeInfo.c:1 OvmfPkg/QemuKernelLoaderFsDxe/QemuKernelLoaderFsDxe.c:5 OvmfPkg/QemuVideoDxe/VbeShim.c:4 OvmfPkg/SmmControl2Dxe/SmiFeatures.c:4 OvmfPkg/Virtio10Dxe/Virtio10.c:1 OvmfPkg/VirtioGpuDxe/DriverBinding.c:4 > Other than that: > > > Reviewed-by: Rebecca Cran > Thanks I've tried to merge this but I am getting errors and I cannot figure out what they are: https://dev.azure.com/tianocore/edk2-ci/_build/results?buildId=99505&view=results -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#107642): https://edk2.groups.io/g/devel/message/107642 Mute This Topic: https://groups.io/mt/100327419/7686176 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io] -=-=-=-=-=-=-=-=-=-=-=-