From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217])
 by mx.groups.io with SMTP id smtpd.web10.459.1666889789496289084
 for <devel@edk2.groups.io>;
 Thu, 27 Oct 2022 09:56:29 -0700
Authentication-Results: mx.groups.io;
 dkim=pass header.i=@kernel.org header.s=k20201202 header.b=sjP1KM3F;
 spf=pass (domain: kernel.org, ip: 139.178.84.217, mailfrom: ardb@kernel.org)
Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140])
	(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
	(No client certificate requested)
	by dfw.source.kernel.org (Postfix) with ESMTPS id AC367623ED
	for <devel@edk2.groups.io>; Thu, 27 Oct 2022 16:56:28 +0000 (UTC)
Received: by smtp.kernel.org (Postfix) with ESMTPSA id 7D74EC433D7
	for <devel@edk2.groups.io>; Thu, 27 Oct 2022 16:56:28 +0000 (UTC)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org;
	s=k20201202; t=1666889788;
	bh=ggjACVWGF8ZOMx+IpHp9Sxg18N2qVoJu/5NfDUbNwNc=;
	h=References:In-Reply-To:From:Date:Subject:To:Cc:From;
	b=sjP1KM3FyT53cRsHEuH9Sza64ebIjfssLU1QorAeu0EfRIpa84eseXZiEj6dNPkSv
	 8hWf44mH2OjH1ngJ2IG4BwsdOIF3zorPE/ySJQtTCasBzgVrrN3oebStvE6OnwJyHX
	 pkaMv+D+sSvwjPr4Qo2OPGew/UcmXfj4H/BYcaD85kim/39Zm1Ju99i81pK+msP4ut
	 iyzJFatGypOEj9cC2j67Nfosuz35WlMPhi1cw8nE572pqFQ+XljVRXxuh9FRjeKLv8
	 v49ThTYXqj7cg/sfwd2dpmxjJPrz+niVGFc/cILwvQgGbKtoE3OfOPABhXE9VGKePc
	 J9+BfD6AtGwyA==
Received: by mail-lj1-f182.google.com with SMTP id s24so3832598ljs.11
        for <devel@edk2.groups.io>; Thu, 27 Oct 2022 09:56:28 -0700 (PDT)
X-Gm-Message-State: ACrzQf0m3CoTt1F4p4S57VaEcKfAHopu6OFJNevXGmdCbQ6Ab9Ffy0BD
	oNguJ6c3v2PKA6myxdirB2m1n3dHlPy0x1Rkwyw=
X-Google-Smtp-Source: AMsMyM5q2u2tKxx/IntrrLt13jjbbS68zrbDq06pzvZdGGTVHngaxu3hWhU1JEydpVw6vlmCH3JA605wTsHwOrkk9j0=
X-Received: by 2002:a05:651c:4d0:b0:26f:cd9b:419f with SMTP id
 e16-20020a05651c04d000b0026fcd9b419fmr17816915lji.415.1666889786538; Thu, 27
 Oct 2022 09:56:26 -0700 (PDT)
MIME-Version: 1.0
References: <20221024170122.594577-1-ardb@kernel.org> <Y1oNae3YdpQwqxE2@sunil-laptop>
In-Reply-To: <Y1oNae3YdpQwqxE2@sunil-laptop>
From: "Ard Biesheuvel" <ardb@kernel.org>
Date: Thu, 27 Oct 2022 18:56:15 +0200
X-Gmail-Original-Message-ID: <CAMj1kXHfyZVSeMc+69-bh_P57fTHbdg9te6FchxJdb09sbf7vA@mail.gmail.com>
Message-ID: <CAMj1kXHfyZVSeMc+69-bh_P57fTHbdg9te6FchxJdb09sbf7vA@mail.gmail.com>
Subject: Re: [PATCH 00/11] ArmVirtPkg: introduce VirtNorFlashDxe
To: Sunil V L <sunilvl@ventanamicro.com>
Cc: devel@edk2.groups.io, Gerd Hoffmann <kraxel@redhat.com>, 
	Sami Mujawar <sami.mujawar@arm.com>, Leif Lindholm <quic_llindhol@quicinc.com>
Content-Type: text/plain; charset="UTF-8"

On Thu, 27 Oct 2022 at 06:47, Sunil V L <sunilvl@ventanamicro.com> wrote:
>
> On Mon, Oct 24, 2022 at 07:01:11PM +0200, Ard Biesheuvel wrote:
> > Create a new driver VirtNorFlashDxe that targets QEMU and KvmTool's NOR
> > flash emulation specifically, and retire the ArmPlatformPkg one.
> >
> > This permits new virt implementations to wire up QEMU's NOR flash
> > emulation without having to rely on ARM specific packages. It also
> > permits us to implement some tweaks to work around some rough
> > performance edges of KVM memslot backed NOR flash.
> >
>
> Thank you very much!. Looks good to me. May be you want to fix the
> include gaurd in NorFlash.h and VirtNorFlashPlatformLib.h as per the
> coding standards.
>
> Reviewed-by: Sunil V L <sunilvl@ventanamicro.com>

Thanks. I've merged these now.