From: "Ard Biesheuvel" <ardb@kernel.org>
To: Rebecca Cran <rebecca@bsdio.com>
Cc: devel@edk2.groups.io, Oliver Smith-Denny <osd@smith-denny.com>,
Guomin Jiang <guomin.jiang@intel.com>,
Xiaoyu Lu <xiaoyu1.lu@intel.com>,
Jian J Wang <jian.j.wang@intel.com>,
Jiewen Yao <jiewen.yao@intel.com>,
Ard Biesheuvel <ardb+tianocore@kernel.org>,
Jordan Justen <jordan.l.justen@intel.com>,
Gerd Hoffmann <kraxel@redhat.com>,
Bob Feng <bob.c.feng@intel.com>,
Liming Gao <gaoliming@byosoft.com.cn>,
Andrew Fish <afish@apple.com>,
Leif Lindholm <quic_llindhol@quicinc.com>,
Michael D Kinney <michael.d.kinney@intel.com>
Subject: Re: [PATCH v2 00/13] BaseTools,CryptoPkg,MdePkg,OvmfPkg: Delete CLANG35,CLANG38,GCC48,GCC49, rename GCC5 to GCC, update CLANGDWARF, delete VS 2008-2013, EBC
Date: Tue, 28 Mar 2023 19:57:17 +0200 [thread overview]
Message-ID: <CAMj1kXHh6FwwPbFKwBmav_NTHcJiRGwbmeT=pT65DavwT8QgUQ@mail.gmail.com> (raw)
In-Reply-To: <20230328173111.759017-1-rebecca@bsdio.com>
Hi Rebecca,
Thanks for respining this.
On Tue, 28 Mar 2023 at 19:31, Rebecca Cran <rebecca@bsdio.com> wrote:
>
> Update the toolchain definitions:
>
> - Delete the CLANG35 and CLANG38 toolchains, and replace CLANG38 with
> CLANGDWARF, updating it to support ARM and AARCH64 in addition to X64
> and IA32.
>
As I have indicated before, I am strongly in favor of these changes.
However, using LLD with X86 and GNU ld with ARM is not what I would
like to see here: not only is it a bad idea for a single toolchain
definition to deviate in this manner between architectures, I also
think that having the ability to use LLD for ARM would be nice in
itself, as it removes the need for cross toolchains entirely, lowering
the bar for contributors to ensure that their changes do not regress
other architectures. And there are some differences related to BTI
that could be interesting as well.
> - Remove GCC48 and GCC49.
>
> - Remove VS2008, VS2010, VS2012 and VS2013.
>
> - Remove EBC compiler definitions. Full removal of EBC support from the
> various packages etc. will be done in a follow-up patch series.
>
> - Remove unused IPHONE_TOOLS and SOURCERY_CYGWIN_TOOLS definitions.
>
> - Remove unused CYGWIN_ definitions.
>
> - Rename GCC5 to GCC.
>
> Personal GitHub PR: https://github.com/tianocore/edk2/pull/4158
> GitHub branch: https://github.com/bcran/edk2/tree/clangdwarf
>
> Note: CI will fail due to changes that are needed in the edk2-basetools
> and containers repositories.
>
> Changes from v1 to v2:
>
> - Added a commit to delete GCC48 and GCC49, rename GCC5 to GCC and
> update the flags for other toolchains to work with the new GCC
> definitions.
>
> - Bumped VERSION from 2.00 to 3.00 to inform users that they should
> updated their Conf/tools_def.txt.
>
> Rebecca Cran (13):
> OvmfPkg: Replace static struct initialization with ZeroMem call
> CryptoPkg: Add CLANGDWARF and remove CLANG35 and CLANG38 compiler
> flags
> BaseTools: Update CLANGDWARF toolchain and remove CLANG35 and CLANG38
> BaseTools: Remove VS2008, 2010, 2012 and 2013 toolchain definitions
> BaseTools: Remove VS2008-VS2013 remnants
> MdePkg: Remove VS2008-VS2013 remnants
> edksetup.bat: Remove VS2008-VS2013 remnants
> BaseTools: Remove unused IPHONE_TOOLS and SOURCERY_CYGWIN_TOOLS defs
> BaseTools: Remove EBC (EFI Byte Code) compiler definitions
> OvmfPkg: Use Xcode5 version of CpuExceptionHandlerLib for CLANGDWARF
> Delete GCC48 and GCC49 toolchains and rename GCC5 to GCC
> BaseTools: Remove unused CYGWIN_ defines from tools_def.txt.template
> Bump tools_def.txt VERSION to 3.0
>
> UnitTestFrameworkPkg/UnitTestFrameworkPkgHost.dsc.inc | 4 +-
> IntelFsp2Pkg/Tools/Tests/QemuFspPkg.dsc | 12 +-
> OvmfPkg/OvmfPkgX64.dsc | 2 +-
> CryptoPkg/Library/BaseCryptLib/BaseCryptLib.inf | 3 +-
> CryptoPkg/Library/BaseCryptLib/PeiCryptLib.inf | 3 +-
> CryptoPkg/Library/BaseCryptLib/RuntimeCryptLib.inf | 3 +-
> CryptoPkg/Library/BaseCryptLib/SecCryptLib.inf | 3 +-
> CryptoPkg/Library/BaseCryptLib/SmmCryptLib.inf | 3 +-
> CryptoPkg/Library/BaseCryptLib/UnitTestHostBaseCryptLib.inf | 3 +-
> CryptoPkg/Library/OpensslLib/OpensslLib.inf | 5 +-
> CryptoPkg/Library/OpensslLib/OpensslLibAccel.inf | 5 +-
> CryptoPkg/Library/OpensslLib/OpensslLibCrypto.inf | 5 +-
> CryptoPkg/Library/OpensslLib/OpensslLibFull.inf | 5 +-
> CryptoPkg/Library/OpensslLib/OpensslLibFullAccel.inf | 5 +-
> EmulatorPkg/Unix/Host/Host.inf | 6 +-
> MdePkg/Include/Ia32/ProcessorBind.h | 8 +-
> MdePkg/Include/X64/ProcessorBind.h | 8 +-
> OvmfPkg/Library/PlatformInitLib/MemDetect.c | 4 +-
> OvmfPkg/Library/X86QemuLoadImageLib/X86QemuLoadImageLib.c | 5 -
> .azurepipelines/Ubuntu-GCC5.yml | 4 +-
> .azurepipelines/templates/platform-build-run-steps.yml | 2 +-
> .azurepipelines/templates/pr-gate-build-job.yml | 2 +-
> .azurepipelines/templates/pr-gate-steps.yml | 2 +-
> ArmPlatformPkg/Scripts/Makefile | 2 +-
> ArmVirtPkg/PlatformCI/.azurepipelines/Ubuntu-GCC5.yml | 4 +-
> ArmVirtPkg/PlatformCI/ReadMe.md | 2 +-
> BaseTools/Conf/tools_def.template | 2528 ++++----------------
> BaseTools/Edk2ToolsBuild.py | 2 +-
> BaseTools/Plugin/HostBasedUnitTestRunner/HostBasedUnitTestRunner.py | 2 +-
> BaseTools/Plugin/LinuxGcc5ToolChain/LinuxGcc5ToolChain.py | 62 +-
> BaseTools/Plugin/LinuxGcc5ToolChain/LinuxGcc5ToolChain_plug_in.yaml | 4 +-
> BaseTools/Scripts/SetVisualStudio.bat | 22 +-
> BaseTools/Scripts/ShowEnvironment.bat | 44 -
> BaseTools/get_vsvars.bat | 13 -
> BaseTools/set_vsprefix_envs.bat | 64 -
> BaseTools/toolsetup.bat | 24 +-
> DynamicTablesPkg/Readme.md | 10 +-
> EmulatorPkg/PlatformCI/.azurepipelines/Ubuntu-GCC5.yml | 4 +-
> EmulatorPkg/PlatformCI/ReadMe.md | 2 +-
> EmulatorPkg/Readme.md | 8 +-
> EmulatorPkg/build.sh | 14 +-
> OvmfPkg/CloudHv/README | 2 +-
> OvmfPkg/IntelTdx/README | 4 +-
> OvmfPkg/PlatformCI/.azurepipelines/Ubuntu-GCC5.yml | 4 +-
> OvmfPkg/PlatformCI/ReadMe.md | 2 +-
> OvmfPkg/README | 4 +-
> OvmfPkg/build.sh | 12 +-
> PrmPkg/Readme.md | 6 +-
> ReadMe.rst | 102 +-
> UnitTestFrameworkPkg/ReadMe.md | 8 +-
> edksetup.bat | 6 +-
> 51 files changed, 592 insertions(+), 2471 deletions(-)
>
> --
> 2.34.1
>
next prev parent reply other threads:[~2023-03-28 17:57 UTC|newest]
Thread overview: 68+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-03-28 17:30 [PATCH v2 00/13] BaseTools,CryptoPkg,MdePkg,OvmfPkg: Delete CLANG35,CLANG38,GCC48,GCC49, rename GCC5 to GCC, update CLANGDWARF, delete VS 2008-2013, EBC Rebecca Cran
2023-03-28 17:30 ` [PATCH v2 01/13] OvmfPkg: Replace static struct initialization with ZeroMem call Rebecca Cran
2023-03-28 22:40 ` Yao, Jiewen
2023-03-28 22:45 ` Michael D Kinney
2023-03-28 17:31 ` [PATCH v2 02/13] CryptoPkg: Add CLANGDWARF and remove CLANG35 and CLANG38 compiler flags Rebecca Cran
2023-03-28 17:31 ` [PATCH v2 03/13] BaseTools: Update CLANGDWARF toolchain and remove CLANG35 and CLANG38 Rebecca Cran
2023-03-29 3:46 ` [edk2-devel] " Guo, Gua
[not found] ` <1750C725F99FA0C2.29160@groups.io>
2023-03-29 9:24 ` Guo, Gua
2023-03-28 17:31 ` [PATCH v2 04/13] BaseTools: Remove VS2008, 2010, 2012 and 2013 toolchain definitions Rebecca Cran
2023-03-28 17:31 ` [PATCH v2 05/13] BaseTools: Remove VS2008-VS2013 remnants Rebecca Cran
2023-03-28 17:31 ` [PATCH v2 06/13] MdePkg: " Rebecca Cran
2023-03-28 17:31 ` [PATCH v2 07/13] edksetup.bat: " Rebecca Cran
2023-03-28 17:31 ` [PATCH v2 08/13] BaseTools: Remove unused IPHONE_TOOLS and SOURCERY_CYGWIN_TOOLS defs Rebecca Cran
2023-03-28 17:31 ` [PATCH v2 09/13] BaseTools: Remove EBC (EFI Byte Code) compiler definitions Rebecca Cran
2023-03-28 17:31 ` [PATCH v2 10/13] OvmfPkg: Use Xcode5 version of CpuExceptionHandlerLib for CLANGDWARF Rebecca Cran
2023-03-28 17:31 ` [PATCH v2 11/13] Delete GCC48 and GCC49 toolchains and rename GCC5 to GCC Rebecca Cran
2023-03-28 17:31 ` [PATCH v2 12/13] BaseTools: Remove unused CYGWIN_ defines from tools_def.txt.template Rebecca Cran
2023-03-28 17:31 ` [PATCH v2 13/13] Bump tools_def.txt VERSION to 3.0 Rebecca Cran
2023-03-28 17:57 ` Ard Biesheuvel [this message]
2023-03-28 18:01 ` [PATCH v2 00/13] BaseTools,CryptoPkg,MdePkg,OvmfPkg: Delete CLANG35,CLANG38,GCC48,GCC49, rename GCC5 to GCC, update CLANGDWARF, delete VS 2008-2013, EBC Rebecca Cran
2023-03-28 18:12 ` [edk2-devel] " Ard Biesheuvel
2023-03-29 10:21 ` Rebecca Cran
2023-03-29 10:30 ` Ard Biesheuvel
2023-03-29 1:19 ` 回复: " gaoliming
2023-03-29 7:39 ` Ard Biesheuvel
2023-03-29 10:20 ` Rebecca Cran
2023-03-29 11:28 ` Leif Lindholm
2023-03-29 11:53 ` Ard Biesheuvel
2023-04-02 15:41 ` 回复: " Rebecca Cran
2023-04-02 16:36 ` Ard Biesheuvel
2023-04-02 16:42 ` Michael D Kinney
2023-04-02 18:38 ` Pedro Falcato
2023-04-02 21:50 ` Rebecca Cran
2023-04-03 11:30 ` Gerd Hoffmann
2023-04-03 11:33 ` Rebecca Cran
2023-04-03 11:39 ` Gerd Hoffmann
2023-04-03 11:55 ` Ard Biesheuvel
2023-04-03 12:15 ` Leif Lindholm
2023-04-03 12:26 ` Rebecca Cran
2023-04-03 13:44 ` Pedro Falcato
2023-04-03 13:54 ` Rebecca Cran
2023-04-03 14:08 ` Gerd Hoffmann
2023-04-03 14:27 ` Rebecca Cran
2023-04-03 19:42 ` Michael D Kinney
2023-04-03 19:54 ` Rebecca Cran
2023-04-03 20:23 ` Michael D Kinney
2023-04-03 13:04 ` Ard Biesheuvel
2023-04-03 13:27 ` Michael D Kinney
2023-04-03 13:43 ` Ard Biesheuvel
2023-04-04 1:31 ` 回复: " gaoliming
2023-04-04 15:49 ` Rebecca Cran
2023-04-04 15:57 ` Pedro Falcato
2023-04-04 16:32 ` Leif Lindholm
2023-04-04 17:00 ` Rebecca Cran
2023-04-04 17:45 ` Michael D Kinney
2023-04-04 17:48 ` Rebecca Cran
2023-04-04 17:52 ` Michael D Kinney
2023-04-04 17:57 ` Pedro Falcato
2023-04-04 18:03 ` Rebecca Cran
2023-04-04 18:26 ` Ard Biesheuvel
2023-04-04 18:29 ` Michael D Kinney
2023-04-04 18:36 ` Rebecca Cran
2023-04-05 10:21 ` Ard Biesheuvel
2023-04-06 0:57 ` 回复: " gaoliming
2023-04-06 2:49 ` Rebecca Cran
2023-04-06 7:32 ` Ard Biesheuvel
2023-04-06 9:19 ` Marcin Juszkiewicz
2023-03-29 12:20 ` Ard Biesheuvel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAMj1kXHh6FwwPbFKwBmav_NTHcJiRGwbmeT=pT65DavwT8QgUQ@mail.gmail.com' \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox