From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from sin.source.kernel.org (sin.source.kernel.org [145.40.73.55]) by mx.groups.io with SMTP id smtpd.web11.3453.1680026254664578555 for ; Tue, 28 Mar 2023 10:57:35 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=YdlNWZti; spf=pass (domain: kernel.org, ip: 145.40.73.55, mailfrom: ardb@kernel.org) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by sin.source.kernel.org (Postfix) with ESMTPS id E0AE2CE1E6E for ; Tue, 28 Mar 2023 17:57:31 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 157C7C433A8 for ; Tue, 28 Mar 2023 17:57:31 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1680026251; bh=8HrvT0VS/cga9987cXuh/YrdaDD8+fX3PdbNE5z36Es=; h=References:In-Reply-To:From:Date:Subject:To:Cc:From; b=YdlNWZtiYKJi5NkXrLkLG/T91iGM0MVflHseBP20sVUC20Pj8QPIedZN3K2LxeuAB fEsg76czuORE3ZT1CIVB11F2pVnuCwmO2R/+jDDI3WUZgrFCiRrGFHOJqAKFoEmOGO B+2TXebhPWKLANzHwBW2EFzihKYNscQ8XEfEuUhR0PTQAFyvmfe91XORPSV+yHGBrJ 7pky7e/u0AiIIIVAL32HkreAjJWjr3BUExQfctWqOW7woSKa2BHnUTCl7im+UsocAW DHchs9IC+7jr7riUc8aBxSDIsotZqiRqPduUvDQ3NnfqraNUB5XTWrbifQfWeqgYkT ySMfPJUBX4q5g== Received: by mail-lj1-f170.google.com with SMTP id q14so13446376ljm.11 for ; Tue, 28 Mar 2023 10:57:30 -0700 (PDT) X-Gm-Message-State: AAQBX9fFqH3AyPIhZw+QMF7/+9T6mO3ao0LgnwTahw+WuFSoFTqsHIFg lu5wRRZbpsyGJAMy+fEJUlmt0KnKIft9WHDoAM8= X-Google-Smtp-Source: AKy350aPrAR4/iK8tgOfqRaPgz0ElCaJTqWVrTfeT7vfE7GjLQAvOLRn2OT2L3phXM3sqDz+WjyBdvmOkDBqUFTQmgQ= X-Received: by 2002:a2e:8782:0:b0:299:9de5:2f05 with SMTP id n2-20020a2e8782000000b002999de52f05mr4957698lji.2.1680026248969; Tue, 28 Mar 2023 10:57:28 -0700 (PDT) MIME-Version: 1.0 References: <20230328173111.759017-1-rebecca@bsdio.com> In-Reply-To: <20230328173111.759017-1-rebecca@bsdio.com> From: "Ard Biesheuvel" Date: Tue, 28 Mar 2023 19:57:17 +0200 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH v2 00/13] BaseTools,CryptoPkg,MdePkg,OvmfPkg: Delete CLANG35,CLANG38,GCC48,GCC49, rename GCC5 to GCC, update CLANGDWARF, delete VS 2008-2013, EBC To: Rebecca Cran Cc: devel@edk2.groups.io, Oliver Smith-Denny , Guomin Jiang , Xiaoyu Lu , Jian J Wang , Jiewen Yao , Ard Biesheuvel , Jordan Justen , Gerd Hoffmann , Bob Feng , Liming Gao , Andrew Fish , Leif Lindholm , Michael D Kinney Content-Type: text/plain; charset="UTF-8" Hi Rebecca, Thanks for respining this. On Tue, 28 Mar 2023 at 19:31, Rebecca Cran wrote: > > Update the toolchain definitions: > > - Delete the CLANG35 and CLANG38 toolchains, and replace CLANG38 with > CLANGDWARF, updating it to support ARM and AARCH64 in addition to X64 > and IA32. > As I have indicated before, I am strongly in favor of these changes. However, using LLD with X86 and GNU ld with ARM is not what I would like to see here: not only is it a bad idea for a single toolchain definition to deviate in this manner between architectures, I also think that having the ability to use LLD for ARM would be nice in itself, as it removes the need for cross toolchains entirely, lowering the bar for contributors to ensure that their changes do not regress other architectures. And there are some differences related to BTI that could be interesting as well. > - Remove GCC48 and GCC49. > > - Remove VS2008, VS2010, VS2012 and VS2013. > > - Remove EBC compiler definitions. Full removal of EBC support from the > various packages etc. will be done in a follow-up patch series. > > - Remove unused IPHONE_TOOLS and SOURCERY_CYGWIN_TOOLS definitions. > > - Remove unused CYGWIN_ definitions. > > - Rename GCC5 to GCC. > > Personal GitHub PR: https://github.com/tianocore/edk2/pull/4158 > GitHub branch: https://github.com/bcran/edk2/tree/clangdwarf > > Note: CI will fail due to changes that are needed in the edk2-basetools > and containers repositories. > > Changes from v1 to v2: > > - Added a commit to delete GCC48 and GCC49, rename GCC5 to GCC and > update the flags for other toolchains to work with the new GCC > definitions. > > - Bumped VERSION from 2.00 to 3.00 to inform users that they should > updated their Conf/tools_def.txt. > > Rebecca Cran (13): > OvmfPkg: Replace static struct initialization with ZeroMem call > CryptoPkg: Add CLANGDWARF and remove CLANG35 and CLANG38 compiler > flags > BaseTools: Update CLANGDWARF toolchain and remove CLANG35 and CLANG38 > BaseTools: Remove VS2008, 2010, 2012 and 2013 toolchain definitions > BaseTools: Remove VS2008-VS2013 remnants > MdePkg: Remove VS2008-VS2013 remnants > edksetup.bat: Remove VS2008-VS2013 remnants > BaseTools: Remove unused IPHONE_TOOLS and SOURCERY_CYGWIN_TOOLS defs > BaseTools: Remove EBC (EFI Byte Code) compiler definitions > OvmfPkg: Use Xcode5 version of CpuExceptionHandlerLib for CLANGDWARF > Delete GCC48 and GCC49 toolchains and rename GCC5 to GCC > BaseTools: Remove unused CYGWIN_ defines from tools_def.txt.template > Bump tools_def.txt VERSION to 3.0 > > UnitTestFrameworkPkg/UnitTestFrameworkPkgHost.dsc.inc | 4 +- > IntelFsp2Pkg/Tools/Tests/QemuFspPkg.dsc | 12 +- > OvmfPkg/OvmfPkgX64.dsc | 2 +- > CryptoPkg/Library/BaseCryptLib/BaseCryptLib.inf | 3 +- > CryptoPkg/Library/BaseCryptLib/PeiCryptLib.inf | 3 +- > CryptoPkg/Library/BaseCryptLib/RuntimeCryptLib.inf | 3 +- > CryptoPkg/Library/BaseCryptLib/SecCryptLib.inf | 3 +- > CryptoPkg/Library/BaseCryptLib/SmmCryptLib.inf | 3 +- > CryptoPkg/Library/BaseCryptLib/UnitTestHostBaseCryptLib.inf | 3 +- > CryptoPkg/Library/OpensslLib/OpensslLib.inf | 5 +- > CryptoPkg/Library/OpensslLib/OpensslLibAccel.inf | 5 +- > CryptoPkg/Library/OpensslLib/OpensslLibCrypto.inf | 5 +- > CryptoPkg/Library/OpensslLib/OpensslLibFull.inf | 5 +- > CryptoPkg/Library/OpensslLib/OpensslLibFullAccel.inf | 5 +- > EmulatorPkg/Unix/Host/Host.inf | 6 +- > MdePkg/Include/Ia32/ProcessorBind.h | 8 +- > MdePkg/Include/X64/ProcessorBind.h | 8 +- > OvmfPkg/Library/PlatformInitLib/MemDetect.c | 4 +- > OvmfPkg/Library/X86QemuLoadImageLib/X86QemuLoadImageLib.c | 5 - > .azurepipelines/Ubuntu-GCC5.yml | 4 +- > .azurepipelines/templates/platform-build-run-steps.yml | 2 +- > .azurepipelines/templates/pr-gate-build-job.yml | 2 +- > .azurepipelines/templates/pr-gate-steps.yml | 2 +- > ArmPlatformPkg/Scripts/Makefile | 2 +- > ArmVirtPkg/PlatformCI/.azurepipelines/Ubuntu-GCC5.yml | 4 +- > ArmVirtPkg/PlatformCI/ReadMe.md | 2 +- > BaseTools/Conf/tools_def.template | 2528 ++++---------------- > BaseTools/Edk2ToolsBuild.py | 2 +- > BaseTools/Plugin/HostBasedUnitTestRunner/HostBasedUnitTestRunner.py | 2 +- > BaseTools/Plugin/LinuxGcc5ToolChain/LinuxGcc5ToolChain.py | 62 +- > BaseTools/Plugin/LinuxGcc5ToolChain/LinuxGcc5ToolChain_plug_in.yaml | 4 +- > BaseTools/Scripts/SetVisualStudio.bat | 22 +- > BaseTools/Scripts/ShowEnvironment.bat | 44 - > BaseTools/get_vsvars.bat | 13 - > BaseTools/set_vsprefix_envs.bat | 64 - > BaseTools/toolsetup.bat | 24 +- > DynamicTablesPkg/Readme.md | 10 +- > EmulatorPkg/PlatformCI/.azurepipelines/Ubuntu-GCC5.yml | 4 +- > EmulatorPkg/PlatformCI/ReadMe.md | 2 +- > EmulatorPkg/Readme.md | 8 +- > EmulatorPkg/build.sh | 14 +- > OvmfPkg/CloudHv/README | 2 +- > OvmfPkg/IntelTdx/README | 4 +- > OvmfPkg/PlatformCI/.azurepipelines/Ubuntu-GCC5.yml | 4 +- > OvmfPkg/PlatformCI/ReadMe.md | 2 +- > OvmfPkg/README | 4 +- > OvmfPkg/build.sh | 12 +- > PrmPkg/Readme.md | 6 +- > ReadMe.rst | 102 +- > UnitTestFrameworkPkg/ReadMe.md | 8 +- > edksetup.bat | 6 +- > 51 files changed, 592 insertions(+), 2471 deletions(-) > > -- > 2.34.1 >