Re: [edk2-devel] [PATCH 2/2] NetworkPkg/HttpDxe: fix driver binding start issue.

["Ard Biesheuvel" <ardb@kernel.org>]

On Thu, 20 Jul 2023 at 19:10, Michael D Kinney
<michael.d.kinney@intel.com> wrote:
>
> Hi Ard,
>
> This is my mistake.  I usually check the Author field when
> adding Rb/Ab tags because I have seen lots of cases where
> the Author field needs updating as well.  I forgot to do this
> step in this one.
>
> I agree a CI check against the Author field being a valid
> email address and not one of the mailing addresses would be
> valuable.  Perhaps in PatchCheck.py?
>

Yeah, and actually, a test seems to exist already but it didn't catch
this particular case:

        if ' via Groups.Io' in name and mo.group(3).endswith('@groups.io'):
            self.error("Email rewritten by lists DMARC / DKIM / SPF: " +
                       email)

I suppose replacing the 'and' with 'or' would be sufficient here? I
don't think @groups.io is ever a valid author email domain.


-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#107108): https://edk2.groups.io/g/devel/message/107108
Mute This Topic: https://groups.io/mt/99821789/7686176
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io]
-=-=-=-=-=-=-=-=-=-=-=-