From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by spool.mail.gandi.net (Postfix) with ESMTPS id 539AD9417D0 for ; Thu, 20 Jul 2023 17:19:33 +0000 (UTC) DKIM-Signature: a=rsa-sha256; bh=rb1Lixx3J2PRNf11sYC+UqT0FyI4GPbwHI8p6mn7Zvg=; c=relaxed/simple; d=groups.io; h=X-Received:X-Received:X-Received:X-Received:X-Received:X-Gm-Message-State:X-Google-Smtp-Source:X-Received:MIME-Version:References:In-Reply-To:From:Date:X-Gmail-Original-Message-ID:Message-ID:Subject:To:Cc:Precedence:List-Unsubscribe:List-Subscribe:List-Help:Sender:List-Id:Mailing-List:Delivered-To:Reply-To:Content-Type; s=20140610; t=1689873571; v=1; b=U/IH6i0lsVrWAVJQOBJdnprSvyhzNpAVlYM4QmkZOi8yspm/r55Fk4U9dtQGdh7gFPVPhsBZ r6Rx6ZabWSulEZk+bdb6tMq6nbs8SIiQNa0iw5aI980oQNL5xTQCqHJ5n/QdmZ43Aoouy39Zr3N 5GrJtpjtXdRIiaINbZ3+4U2M= X-Received: by 127.0.0.2 with SMTP id lMKmYY7687511xeuoPCpGkng; Thu, 20 Jul 2023 10:19:31 -0700 X-Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by mx.groups.io with SMTP id smtpd.web11.3021.1689873571145531257 for ; Thu, 20 Jul 2023 10:19:31 -0700 X-Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 970A061B9D for ; Thu, 20 Jul 2023 17:19:30 +0000 (UTC) X-Received: by smtp.kernel.org (Postfix) with ESMTPSA id 0316AC433C8 for ; Thu, 20 Jul 2023 17:19:30 +0000 (UTC) X-Received: by mail-lf1-f46.google.com with SMTP id 2adb3069b0e04-4f4b2bc1565so1630187e87.2 for ; Thu, 20 Jul 2023 10:19:29 -0700 (PDT) X-Gm-Message-State: 0JsQAkCKLV54WlJHdS4j4YLMx7686176AA= X-Google-Smtp-Source: APBJJlHWWNX7x9IKyqZbtOn7A7OCiFhfO3dE5293o7FZN5Q6z79wMtLeDud9Ykwe6wjabJVj/Gp41DhcQ6bV+sXP+vI= X-Received: by 2002:ac2:5324:0:b0:4fb:7c40:9f95 with SMTP id f4-20020ac25324000000b004fb7c409f95mr3145521lfh.47.1689873568002; Thu, 20 Jul 2023 10:19:28 -0700 (PDT) MIME-Version: 1.0 References: <174276A45CE2816B.5513@groups.io> In-Reply-To: From: "Ard Biesheuvel" Date: Thu, 20 Jul 2023 19:19:16 +0200 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [edk2-devel] [PATCH 2/2] NetworkPkg/HttpDxe: fix driver binding start issue. To: devel@edk2.groups.io, michael.d.kinney@intel.com Cc: Leif Lindholm , "Demeter, Miki" , "Kasbekar, Saloni" , Nickle Wang , "Clark-williams, Zachary" , Abner Chang , Igor Kulchytskyy , Nick Ramirez Precedence: Bulk List-Unsubscribe: List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,ardb@kernel.org Content-Type: text/plain; charset="UTF-8" X-GND-Status: LEGIT Authentication-Results: spool.mail.gandi.net; dkim=pass header.d=groups.io header.s=20140610 header.b="U/IH6i0l"; dmarc=fail reason="SPF not aligned (relaxed), DKIM not aligned (relaxed)" header.from=kernel.org (policy=none); spf=pass (spool.mail.gandi.net: domain of bounce@groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce@groups.io On Thu, 20 Jul 2023 at 19:10, Michael D Kinney wrote: > > Hi Ard, > > This is my mistake. I usually check the Author field when > adding Rb/Ab tags because I have seen lots of cases where > the Author field needs updating as well. I forgot to do this > step in this one. > > I agree a CI check against the Author field being a valid > email address and not one of the mailing addresses would be > valuable. Perhaps in PatchCheck.py? > Yeah, and actually, a test seems to exist already but it didn't catch this particular case: if ' via Groups.Io' in name and mo.group(3).endswith('@groups.io'): self.error("Email rewritten by lists DMARC / DKIM / SPF: " + email) I suppose replacing the 'and' with 'or' would be sufficient here? I don't think @groups.io is ever a valid author email domain. -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#107108): https://edk2.groups.io/g/devel/message/107108 Mute This Topic: https://groups.io/mt/99821789/7686176 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io] -=-=-=-=-=-=-=-=-=-=-=-