From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by spool.mail.gandi.net (Postfix) with ESMTPS id 6C910740055 for ; Thu, 31 Aug 2023 16:02:12 +0000 (UTC) DKIM-Signature: a=rsa-sha256; bh=ooN+vidK5GF8Sfnn1hq4R/+Udfvswr6NmLV1034/yS4=; c=relaxed/simple; d=groups.io; h=MIME-Version:References:In-Reply-To:From:Date:Message-ID:Subject:To:Cc:Precedence:List-Subscribe:List-Help:Sender:List-Id:Mailing-List:Delivered-To:Reply-To:List-Unsubscribe-Post:List-Unsubscribe:Content-Type; s=20140610; t=1693497731; v=1; b=oO17fksXYa+WFlvdPh2Bkmc3LPHTsIdAeScpAJLrDIpOEPpF0MIUPZ97Bm8srAFZ25MZGK3Y u1TKht6p4Od3+5u4V6+cvF6cEL/W7xwiPtkmrz4bEQYpNUS3ACNNlg+BU2qqTz/Qs3NhGKB9ncU +uddip3VKFgb+L9mocS9eXX8= X-Received: by 127.0.0.2 with SMTP id 02XFYY7687511xCQ1uAUIgFT; Thu, 31 Aug 2023 09:02:11 -0700 X-Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by mx.groups.io with SMTP id smtpd.web10.1678.1693497730487976486 for ; Thu, 31 Aug 2023 09:02:10 -0700 X-Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id E38DF616DD for ; Thu, 31 Aug 2023 16:02:09 +0000 (UTC) X-Received: by smtp.kernel.org (Postfix) with ESMTPSA id 57D5EC433CB for ; Thu, 31 Aug 2023 16:02:09 +0000 (UTC) X-Received: by mail-lj1-f179.google.com with SMTP id 38308e7fff4ca-2bcc187e0b5so18357971fa.1 for ; Thu, 31 Aug 2023 09:02:09 -0700 (PDT) X-Gm-Message-State: lCdHgGI3B4vdxP1erWh1uCovx7686176AA= X-Google-Smtp-Source: AGHT+IFwR9S79wVg5uZSpf9AClTYEy5EWOlUgphHP/gFLWIIViVoMRB0Vi4sqGJVASEp3A5/wwl5iU4ZWy5CeAIUQnc= X-Received: by 2002:a2e:9f50:0:b0:2bb:985f:8479 with SMTP id v16-20020a2e9f50000000b002bb985f8479mr4547680ljk.48.1693497727322; Thu, 31 Aug 2023 09:02:07 -0700 (PDT) MIME-Version: 1.0 References: <20230720134557.3903923-1-ardb@kernel.org> <4bd53ehby2cto5n2venjfkucot5ayj2xtsl7z6diegh6llrpm2@tj5oh6txxjck> In-Reply-To: From: "Ard Biesheuvel" Date: Thu, 31 Aug 2023 18:01:56 +0200 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [edk2-devel] [RFC/RFT PATCH] OvmfPkg/IoMmuDxe: don't rely on TPLs for re-entrancy To: devel@edk2.groups.io, kraxel@redhat.com Cc: Pedro Falcato , Jiewen Yao , Michael Brown , Tom Lendacky , Michael Roth Precedence: Bulk List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,ardb@kernel.org List-Unsubscribe-Post: List-Unsubscribe=One-Click List-Unsubscribe: Content-Type: text/plain; charset="UTF-8" X-GND-Status: LEGIT Authentication-Results: spool.mail.gandi.net; dkim=pass header.d=groups.io header.s=20140610 header.b=oO17fksX; dmarc=fail reason="SPF not aligned (relaxed), DKIM not aligned (relaxed)" header.from=kernel.org (policy=none); spf=pass (spool.mail.gandi.net: domain of bounce@groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce@groups.io On Mon, 28 Aug 2023 at 13:13, Ard Biesheuvel wrote: > > On Mon, 28 Aug 2023 at 11:16, Gerd Hoffmann wrote: > > > > Hi, > > > > > I have tried the patch below, and I don't see any slowdowns with or > > > without the patch, running both DEBUG and RELEASE builds under > > > ordinary KVM/nested-virt. Note that the change in the first hunk will > > > cause the ASSERT()s removed in the other hunks to trigger so the code > > > is definitely being exercised. > > > > QE team tested again with fresh builds, the slowdown isn't there any > > more. Not fully clear where it came from, but most likely not from > > this patch. > > > > Only 20 successful test runs so far, which a good start, but with > > a reproduce rate below 20% not that much. I'll post an update > > when it I get more results. > > > > Excellent, thanks for the update. Given that the QE engineer appears to have lost interest, I intend to merge this patch as-is unless anyone feels this is premature. -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#108197): https://edk2.groups.io/g/devel/message/108197 Mute This Topic: https://groups.io/mt/100256049/7686176 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io] -=-=-=-=-=-=-=-=-=-=-=-