From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from sin.source.kernel.org (sin.source.kernel.org [145.40.73.55]) by mx.groups.io with SMTP id smtpd.web12.5666.1638431763233568966 for ; Wed, 01 Dec 2021 23:56:03 -0800 Authentication-Results: mx.groups.io; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=VNW6wVtv; spf=pass (domain: kernel.org, ip: 145.40.73.55, mailfrom: ardb@kernel.org) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by sin.source.kernel.org (Postfix) with ESMTPS id 14B34CE213D for ; Thu, 2 Dec 2021 07:55:54 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 471B8C53FD2 for ; Thu, 2 Dec 2021 07:55:52 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1638431752; bh=FgiNn+/wjL0mAPo1nqF8Y/A4OQH9a4AabYFDSfF+tJI=; h=References:In-Reply-To:From:Date:Subject:To:Cc:From; b=VNW6wVtvkP2zZ9My2EG06UpPSR/0icObaPInVbC6Hq5zSWISCzQ/ExUuC/93SRz+A k+vcos6nx5txWE5kyPTdF6TvYaSMhLsJqgVpXQvH51KtqRP0gKlHwT4yy//p0k3ifw s2kOQ7PerDZDDsH6Y8nD1rnK51ito+xlTyFbVjCiDUL/++5St4JK07ZEI0Jmg4jV8P cokJbALW50uJ4Lb975X29TrHYeyMPsecDEZNTV2rZnfyQ1Qxx4FKyd80x4LS5raZRq Ye/991UFCJ1R9dZrg0aAjiARQzvPKrMPDDbBm8k3d3e46ABwouow9A283rE14oOcvY IlSLZI0Om64oA== Received: by mail-oo1-f52.google.com with SMTP id d1-20020a4a3c01000000b002c2612c8e1eso8621673ooa.6 for ; Wed, 01 Dec 2021 23:55:52 -0800 (PST) X-Gm-Message-State: AOAM530XYxruH4lA2VfPUXrBLvzHRPUWM3wYJle2cEsagzNVUvQi7L8h S98wG/bTjQwnsGiVHaDpVzDBBYTzPy1T7DZi9nY= X-Google-Smtp-Source: ABdhPJxnufwJwW0qI3V1Aval8s4yM2Umw4sO8ZDCrESCe12KmzkHi8ZODdAl0lTLHgzULDWbyp0FbEN8eceURJzTKFY= X-Received: by 2002:a05:6820:30b:: with SMTP id l11mr7716723ooe.32.1638431751462; Wed, 01 Dec 2021 23:55:51 -0800 (PST) MIME-Version: 1.0 References: <20211130084103.830-1-masahisa.kojima@linaro.org> In-Reply-To: From: "Ard Biesheuvel" Date: Thu, 2 Dec 2021 08:55:40 +0100 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH edk2-platforms 1/1] Platform/Socionext/DeveloperBox: add SMBIOS type 17 table To: Masahisa Kojima Cc: edk2-devel-groups-io , Kazuhiko Sakamoto , Ard Biesheuvel , Leif Lindholm , Masami Hiramatsu Content-Type: text/plain; charset="UTF-8" On Wed, 1 Dec 2021 at 03:45, Masahisa Kojima wrote: > > Hi Ard, > > Thank you for your review. > > On Tue, 30 Nov 2021 at 20:39, Ard Biesheuvel wrote: > > > > Hello Masahisa, > > > > Thanks for this patch. > > > > On Tue, 30 Nov 2021 at 09:37, Masahisa Kojima > > wrote: > > > > > > This commit adds the SMBIOS type 17 table support for Developerbox. > > > The SPD can be accessed only from the SCP through I2C bus, > > > so this commit expects that SCP-firmware reads the SPD and > > > stores it in the non-secure SRAM. > > > > > > > What happens if the existing SCP firmware does not populate this memory region? > > If no valid SPD is found, fill the default SMBIOS Type17 information, > it is same as > current implementation. > > > > > > This commit also reduces the edk2 stack size to allocate > > > the space for storing SPD. It requires 2KB, 512bytes * 4 DIMMs. > > > > > > Cc: Ard Biesheuvel > > > Cc: Leif Lindholm > > > Cc: Masami Hiramatsu > > > Signed-off-by: Masahisa Kojima > > > > It seems to me that this patch contains some pieces that are generic > > SPD handling, and could be broken out. I haven't checked, but perhaps > > some of this already exists in the tree? > > Some SPD handling can be generic. > For example, HiSilicon platform has almost same JEP106_MANUFACTURER_TABLE table. > But most of the processing are platform specific in my check, no platform except > for Developerbox accesses the raw SPD to construct the SMBIOS type17 table. > OK, fair enough. Pushed as e9149e2c1b54..c718abce99a1 -- Ard.