From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by mx.groups.io with SMTP id smtpd.web08.10734.1636543993505162406 for ; Wed, 10 Nov 2021 03:33:13 -0800 Authentication-Results: mx.groups.io; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=QbeCNJAh; spf=pass (domain: kernel.org, ip: 198.145.29.99, mailfrom: ardb@kernel.org) Received: by mail.kernel.org (Postfix) with ESMTPSA id A861A611BF for ; Wed, 10 Nov 2021 11:33:12 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1636543992; bh=JOeQ/sTP56lLLMj93pGhQrmyu6i6sWhHpwRRr24FPIs=; h=References:In-Reply-To:From:Date:Subject:To:Cc:From; b=QbeCNJAh7Op5Ou+oEVpV5kVmjVVJES07uRXT/GoJ17gI6H2cO4CtWUAnYZ0qIQHXi xjINcXuRWP7/0xXKAMT0EzN3bIbdgi9juY0gS6+M6eEMIOpuQ1gy0uFnn1hZaPsUVM NsleOFDHWCCt6JhPejKTdfM3kyQT9/6LL3UOrCLO67tx2mKk5QVs+OrzistoH/DqMo yiiCsGHvQO0LcVhnQLfxVRvnhM1ehbuCt1gFaMW0mxFAS0Pp+9XMn9WRr/WL+PElH8 zmupZZ6NoisdoyJjoq96OsSxLiVvJMZUlVcgX6tkPgjDL17gcbCc5FybyydH6BUINQ 8TINkgNH9NvNg== Received: by mail-ot1-f47.google.com with SMTP id z2-20020a9d71c2000000b0055c6a7d08b8so3423380otj.5 for ; Wed, 10 Nov 2021 03:33:12 -0800 (PST) X-Gm-Message-State: AOAM531RSCRzmF525lzAETlRXT8Xx0U17N5mZQ0qWN/m9GbhnjhozyHw x2eui2tejd/VCKEDee1Qjj2r7a1h91aY11FfzHQ= X-Google-Smtp-Source: ABdhPJx6jBjY9Wzio2duhFBW6ir4pEHDidhbLicggkY2ez+7JJy+WBtvZ/x/8AtQWYoHUPnkv/tw3Kgvpr/ZM4g4QKk= X-Received: by 2002:a05:6830:1445:: with SMTP id w5mr4320616otp.112.1636543991907; Wed, 10 Nov 2021 03:33:11 -0800 (PST) MIME-Version: 1.0 References: <20211110110117.31160-1-sami.mujawar@arm.com> In-Reply-To: <20211110110117.31160-1-sami.mujawar@arm.com> From: "Ard Biesheuvel" Date: Wed, 10 Nov 2021 12:33:00 +0100 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [edk2-devel] [PATCH edk2-platforms v1 00/11] Fix build breaks and update IORT revision macro To: edk2-devel-groups-io , Sami Mujawar Cc: Ard Biesheuvel , Leif Lindholm , Pierre , Matteo.Carlini@arm.com, Akanksha.Jain2@arm.com, Ben.Adderson@arm.com, "Liming Gao (Byosoft address)" , Peter Batard , Thomas Abraham , Chandni.Cherukuri@arm.com, Khasim.Mohammed@arm.com, nd Content-Type: text/plain; charset="UTF-8" On Wed, 10 Nov 2021 at 12:01, Sami Mujawar wrote: > > The first 4 patches in this series fix build breaks in upstream > edk2-platforms code for Socionext, Lemaker and SynQuacerEvalBoard. > > The IORT Rev E.b specification updates the IORT table revision > to 3. Following this the IORT table revision macro > EFI_ACPI_IO_REMAPPING_TABLE_REVISION which was at Rev 0 has > been renamed to EFI_ACPI_IO_REMAPPING_TABLE_REV0. I *really* don't like this. All other ACPI tables are set up in a forward compatible way, where an existing definition in code is guaranteed to comply with later versions of the spec, and can always claim to be the newest revision. This is the reason why xxx_TABLE_REVISION macros exist in the first place. So I suppose that means that the IORT was modified in a non-forward compatible fashion? Does that mean that newer firmware has to stick with the old revision in order to remain able to boot older OS versions? > Therefore, > the last 7 patches in this series are added to reflect this > change for the following platforms: > - FVP > - Morello FVP > - SGI > - AMD/Styx > - Socionext/SynQuacer > - RaspberryPi > - N1SDP > > Note: This patch series is dependent on the edk2 patch series: > "[PATCH v3 0/8] IORT Rev E.b specification updates" > (https://edk2.groups.io/g/devel/message/83545), which must > be merged in edk2 before this patch series can be integrated. > > The changes can be seen at: > https://github.com/samimujawar/edk2-platforms/tree/1527_iort_rev_eb_platforms_v1 > > Sami Mujawar (11): > Platform/Socionext: Fix build break for SynQuacerEvalBoard > Platform/LeMaker: Fix build break for CelloBoard > Platform/Socionext/SynQuacerEvalBoard: Add missing ArmSoftFloatLib > Platform/Socionext/SynQuacerEvalBoard: Disable EbcDxe for AArch32 > builds > Platform/ARM: FVP: Update for IORT revision macro renaming > Platform/ARM: Morello: Update for IORT revision macro renaming > Platform/ARM: SGI: Update for IORT revision macro renaming > Silicon/AMD/Styx: Update for IORT revision macro renaming > Silicon/Socionext/SynQuacer: Update for IORT revision macro renaming > Platform/RaspberryPi: Update for IORT revision macro renaming > Platform/ARM: N1SDP: Update for IORT revision macro renaming > > Platform/ARM/Morello/ConfigurationManager/ConfigurationManagerDxe/ConfigurationManagerFvp.c | 2 +- > Platform/ARM/N1Sdp/ConfigurationManager/ConfigurationManagerDxe/ConfigurationManager.c | 2 +- > Platform/ARM/SgiPkg/AcpiTables/Iort.aslc | 2 +- > Platform/ARM/VExpressPkg/ConfigurationManager/ConfigurationManagerDxe/ConfigurationManager.c | 2 +- > Platform/LeMaker/CelloBoard/CelloBoard.dsc | 4 +++- > Platform/RaspberryPi/AcpiTables/Iort.aslc | 2 +- > Platform/Socionext/SynQuacerEvalBoard/SynQuacerEvalBoard.dsc | 11 +++++++++-- > Platform/Socionext/SynQuacerEvalBoard/SynQuacerEvalBoard.fdf | 8 +++++++- > Silicon/AMD/Styx/Drivers/AcpiPlatformDxe/Iort.aslc | 2 +- > Silicon/Socionext/SynQuacer/AcpiTables/Iort.aslc | 2 +- > 10 files changed, 26 insertions(+), 11 deletions(-) > > -- > 'Guid(CE165669-3EF3-493F-B85D-6190EE5B9759)' > > > > > >