From: "Ard Biesheuvel" <ardb@kernel.org>
To: "Ni, Ray" <ray.ni@intel.com>
Cc: "devel@edk2.groups.io" <devel@edk2.groups.io>,
"lersek@redhat.com" <lersek@redhat.com>,
"mikuback@linux.microsoft.com" <mikuback@linux.microsoft.com>,
Ard Biesheuvel <ardb+tianocore@kernel.org>,
Sami Mujawar <sami.mujawar@arm.com>
Subject: Re: [edk2-devel] [PATCH v1 1/1] StandaloneMmPkg/Core: Output status in MMI handler assertion
Date: Sat, 3 Feb 2024 17:46:27 +0100 [thread overview]
Message-ID: <CAMj1kXHkfHiYktYkTt6fHpeqSobthLZfX+Sp3ipqAWDZzQQ1_w@mail.gmail.com> (raw)
In-Reply-To: <MN6PR11MB82446A5FCE9638E58845B41D8C422@MN6PR11MB8244.namprd11.prod.outlook.com>
On Fri, 2 Feb 2024 at 01:24, Ni, Ray <ray.ni@intel.com> wrote:
>
> Reviewed-by: Ray Ni <ray.ni@intel.com>
>
Merged as #5340
Thanks all
> > From: devel@edk2.groups.io <devel@edk2.groups.io> On Behalf Of Laszlo
> > Ersek
> > Sent: Wednesday, January 31, 2024 7:27 PM
> > To: devel@edk2.groups.io; mikuback@linux.microsoft.com
> > Cc: Ard Biesheuvel <ardb+tianocore@kernel.org>; Sami Mujawar
> > <sami.mujawar@arm.com>; Ni, Ray <ray.ni@intel.com>
> > Subject: Re: [edk2-devel] [PATCH v1 1/1] StandaloneMmPkg/Core: Output
> > status in MMI handler assertion
> >
> > On 1/31/24 05:44, Michael Kubacki wrote:
> > > From: Michael Kubacki <michael.kubacki@microsoft.com>
> > >
> > > Currently, if a MMI handler returns an unexpected failure status
> > > code, ASSERT (FALSE) is used. It is more useful to use
> > > ASSERT_EFI_ERROR() which also outputs the status code value.
> > >
> > > Cc: Ard Biesheuvel <ardb+tianocore@kernel.org>
> > > Cc: Sami Mujawar <sami.mujawar@arm.com>
> > > Cc: Ray Ni <ray.ni@intel.com>
> > > Signed-off-by: Michael Kubacki <michael.kubacki@microsoft.com>
> > > ---
> > > StandaloneMmPkg/Core/Mmi.c | 2 +-
> > > 1 file changed, 1 insertion(+), 1 deletion(-)
> > >
> > > diff --git a/StandaloneMmPkg/Core/Mmi.c
> > b/StandaloneMmPkg/Core/Mmi.c
> > > index 8252355a48eb..0de6fd17fc88 100644
> > > --- a/StandaloneMmPkg/Core/Mmi.c
> > > +++ b/StandaloneMmPkg/Core/Mmi.c
> > > @@ -208,7 +208,7 @@ MmiManage (
> > > //
> > > // Unexpected status code returned.
> > > //
> > > - ASSERT (FALSE);
> > > + ASSERT_EFI_ERROR (Status);
> > > break;
> > > }
> > > }
> >
> > Reviewed-by: Laszlo Ersek <lersek@redhat.com>
> >
> >
> >
> >
> >
>
-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#115074): https://edk2.groups.io/g/devel/message/115074
Mute This Topic: https://groups.io/mt/104069723/7686176
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io]
-=-=-=-=-=-=-=-=-=-=-=-
prev parent reply other threads:[~2024-02-03 16:46 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-01-31 4:44 [edk2-devel] [PATCH v1 1/1] StandaloneMmPkg/Core: Output status in MMI handler assertion Michael Kubacki
2024-01-31 11:26 ` Laszlo Ersek
2024-02-02 0:23 ` Ni, Ray
2024-02-03 16:46 ` Ard Biesheuvel [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAMj1kXHkfHiYktYkTt6fHpeqSobthLZfX+Sp3ipqAWDZzQQ1_w@mail.gmail.com \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox