From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by spool.mail.gandi.net (Postfix) with ESMTPS id 0AE857803D1 for ; Sat, 3 Feb 2024 16:46:43 +0000 (UTC) DKIM-Signature: a=rsa-sha256; bh=2b6HQMcz9pGv+a8PCaOBZGu6Qbu1DrdlK0zTzdK8S5I=; c=relaxed/simple; d=groups.io; h=MIME-Version:References:In-Reply-To:From:Date:Message-ID:Subject:To:Cc:Precedence:List-Subscribe:List-Help:Sender:List-Id:Mailing-List:Delivered-To:Reply-To:List-Unsubscribe-Post:List-Unsubscribe:Content-Type; s=20140610; t=1706978802; v=1; b=PDsef5XdTVLHJl9pRYhAHoU892dUO4wNrWmeeLARuHeRNb4eQY+swWZatjzcpbdlq38vq1mh SkVarG76WXoX6yTdX4V9/5Pzdxqd41SbIoUdyj/NBscvuq6pRjXdLG9r7S42zuNJnouQZF3moaC FVrnHHbB4Na8fG5x6r7ImQTc= X-Received: by 127.0.0.2 with SMTP id Wa4oYY7687511xMdq9xPHa2t; Sat, 03 Feb 2024 08:46:42 -0800 X-Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by mx.groups.io with SMTP id smtpd.web11.20159.1706978801878498323 for ; Sat, 03 Feb 2024 08:46:42 -0800 X-Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by dfw.source.kernel.org (Postfix) with ESMTP id 1990060C19 for ; Sat, 3 Feb 2024 16:46:41 +0000 (UTC) X-Received: by smtp.kernel.org (Postfix) with ESMTPSA id 9CA4DC433C7 for ; Sat, 3 Feb 2024 16:46:40 +0000 (UTC) X-Received: by mail-lf1-f45.google.com with SMTP id 2adb3069b0e04-51124d86022so4992773e87.0 for ; Sat, 03 Feb 2024 08:46:40 -0800 (PST) X-Gm-Message-State: ynf4shhdtHIo32aabP8R45iix7686176AA= X-Google-Smtp-Source: AGHT+IGb6FnJ9gKgptbvyrKoTA/3eUXam3ilU8IYTrMUQC27trfgQhf6A1h7PpF8aaF8+gX30Ry/z/ZoqLqpOssud2A= X-Received: by 2002:a05:6512:3c92:b0:510:206b:e94a with SMTP id h18-20020a0565123c9200b00510206be94amr7499075lfv.53.1706978798787; Sat, 03 Feb 2024 08:46:38 -0800 (PST) MIME-Version: 1.0 References: <20240131044422.1837-1-mikuback@linux.microsoft.com> <9389723b-80a0-6c11-d630-6f80ab216087@redhat.com> In-Reply-To: From: "Ard Biesheuvel" Date: Sat, 3 Feb 2024 17:46:27 +0100 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [edk2-devel] [PATCH v1 1/1] StandaloneMmPkg/Core: Output status in MMI handler assertion To: "Ni, Ray" Cc: "devel@edk2.groups.io" , "lersek@redhat.com" , "mikuback@linux.microsoft.com" , Ard Biesheuvel , Sami Mujawar Precedence: Bulk List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,ardb@kernel.org List-Unsubscribe-Post: List-Unsubscribe=One-Click List-Unsubscribe: Content-Type: text/plain; charset="UTF-8" X-GND-Status: LEGIT Authentication-Results: spool.mail.gandi.net; dkim=pass header.d=groups.io header.s=20140610 header.b=PDsef5Xd; dmarc=fail reason="SPF not aligned (relaxed), DKIM not aligned (relaxed)" header.from=kernel.org (policy=none); spf=pass (spool.mail.gandi.net: domain of bounce@groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce@groups.io On Fri, 2 Feb 2024 at 01:24, Ni, Ray wrote: > > Reviewed-by: Ray Ni > Merged as #5340 Thanks all > > From: devel@edk2.groups.io On Behalf Of Laszlo > > Ersek > > Sent: Wednesday, January 31, 2024 7:27 PM > > To: devel@edk2.groups.io; mikuback@linux.microsoft.com > > Cc: Ard Biesheuvel ; Sami Mujawar > > ; Ni, Ray > > Subject: Re: [edk2-devel] [PATCH v1 1/1] StandaloneMmPkg/Core: Output > > status in MMI handler assertion > > > > On 1/31/24 05:44, Michael Kubacki wrote: > > > From: Michael Kubacki > > > > > > Currently, if a MMI handler returns an unexpected failure status > > > code, ASSERT (FALSE) is used. It is more useful to use > > > ASSERT_EFI_ERROR() which also outputs the status code value. > > > > > > Cc: Ard Biesheuvel > > > Cc: Sami Mujawar > > > Cc: Ray Ni > > > Signed-off-by: Michael Kubacki > > > --- > > > StandaloneMmPkg/Core/Mmi.c | 2 +- > > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > > > diff --git a/StandaloneMmPkg/Core/Mmi.c > > b/StandaloneMmPkg/Core/Mmi.c > > > index 8252355a48eb..0de6fd17fc88 100644 > > > --- a/StandaloneMmPkg/Core/Mmi.c > > > +++ b/StandaloneMmPkg/Core/Mmi.c > > > @@ -208,7 +208,7 @@ MmiManage ( > > > // > > > // Unexpected status code returned. > > > // > > > - ASSERT (FALSE); > > > + ASSERT_EFI_ERROR (Status); > > > break; > > > } > > > } > > > > Reviewed-by: Laszlo Ersek > > > > > > > > > > > -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#115074): https://edk2.groups.io/g/devel/message/115074 Mute This Topic: https://groups.io/mt/104069723/7686176 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io] -=-=-=-=-=-=-=-=-=-=-=-