From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by mx.groups.io with SMTP id smtpd.web08.5923.1632311267563900198 for ; Wed, 22 Sep 2021 04:47:47 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=FzkfaBSW; spf=pass (domain: kernel.org, ip: 198.145.29.99, mailfrom: ardb@kernel.org) Received: by mail.kernel.org (Postfix) with ESMTPSA id 3AF92611B0 for ; Wed, 22 Sep 2021 11:47:46 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1632311266; bh=+OZ7zfg4OgCieBr32Al65UWib8Hnb/NiItPiA7uKKmM=; h=References:In-Reply-To:From:Date:Subject:To:Cc:From; b=FzkfaBSWQxNvNnkDzat1sjEiMBK0GWvnEDulbIcPKj8ERNnNY7LTvsdvrmKQ6jk/x oy+VfNHKnZ+KpABYW+dJJfwEnlAA/6Bv/Tmx0Ufxc0PJlpYkzGjKEkiD5AfewFIdMH VmEW5P3rDHntkqCxoaYnpjHm+AxJd3rRlB5qFjlXorbb0/ua/JHjlesesDkWEhQuq1 f7cfrcJv0RsFejJxntxnJkeaeW8sUGJPDBZ0VjsqnbD8arrr/EHxgAGL/DYqS+k9Dl GT6EnFYS6dltXh8+XJoNdjuZJ2vJWHegLI6V8hsQHtwnp2ace/C0xdPUwqwJlAJIze xj+ygqrIid4ew== Received: by mail-oi1-f170.google.com with SMTP id z11so4056485oih.1 for ; Wed, 22 Sep 2021 04:47:46 -0700 (PDT) X-Gm-Message-State: AOAM531WRG6xF4qqDpvd2V3p/NAeob1XRWgYmLfl2bH6XrkatbVknAwf BYHVLFDRozBybwZ/RPoPKTDvK2B2G/OUpdd34s8= X-Google-Smtp-Source: ABdhPJxNp8Qzd8kfUE+YcQgOwSCGB/8Blwk0V3aTyH4nwnLjUaZzpMjt335Wro9WExBckZIh4Ipa0a22X7Q8BulwpoE= X-Received: by 2002:a05:6808:1148:: with SMTP id u8mr5609742oiu.33.1632311265539; Wed, 22 Sep 2021 04:47:45 -0700 (PDT) MIME-Version: 1.0 References: <169E28AD2269B506.9946@groups.io> In-Reply-To: From: "Ard Biesheuvel" Date: Wed, 22 Sep 2021 13:47:34 +0200 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [edk2-devel] [edk2-platforms][PATCH v3 0/5] Platform/Sgi: Add platform support for firmware first error handling To: Omkar Kulkarni , Sami Mujawar Cc: "devel@edk2.groups.io" , Ard Biesheuvel Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable On Fri, 3 Sept 2021 at 15:39, Omkar Kulkarni wrote= : > > Gentle reminder, to review this patch series. > Sami, would you mind taking this one? > > > On August 24, 2021 11:30 AM, Omkar Kulkarni wrote: > > Changes since v2: > > - Rebased to the latest upstream code. > > > > This patch series introduces platform support for RAS using Firmware Fi= rst > > error handling. Firmware first error handling on ARM Neoverse reference > > design platforms is achieved using HEST[1] and SDEI[2] ACPI tables. > > > > For doing so the Platform Error handler DXE driver is introduced. This = driver > > is integral part of the firmware first error handling framework in EDK2= . SDEI > > being the notification mechanism used to communicate the platform error= s > > to OSPM, it builds and installs the SDEI ACPI table. Also installs the = HEST table > > which is already created as part of firmware first framework in EDK2. > > > > This series does provide a reference implementation to leverage the > > firmware first framework by implementing a platform MM driver for > > Dynamic Memory Controller DMC[3] that has RAS feature enabled. This > > driver mainly handles > > following: > > - Implements the Hest Error Source Descriptor protocol introduced as pa= rt of > > firmware first framework in EDK2. Publishes the 1-bit ECC DRAM error > > sources > > as GHESv2[4] type error source descriptors. > > - For any 1-bit CE that occurs on DRAM it reads DMC error record regist= ers > > and > > populates a error status block (CPER)[5] of Memory Type error[6]. > > > > References: > > [1] : ACPI 6.3, Table 18-382, Hardware Error Source Table [2] : SDEI Pl= atform > > Design Document, revision b, 10 Appendix C, ACPI table > > definitions for SDEI > > [3] : DMC620 Dynamic Memory Controller, revision r1p0 [4] : ACPI Refere= nce > > Specification 6.3, Table 18-393 GHESv2 Structure [5] : UEFI Reference > > Specification 2.8, Appendix N - Common Platform Error > > Record > > [6] : UEFI Reference Specification 2.8, Section N.2.5 Memory Error Sect= ion > > > > This patch series is dependent on the edk2 patch series > > https://edk2.groups.io/g/devel/message/79741 > > > > Link to github branch with the patches in this series - > > https://github.com/omkkul01/edk2-platforms/tree/ras_firware_first_edk2- > > platforms_v3 > > > > Omkar Anand Kulkarni (5): > > Platform/ARM: Add DMC-620 ECC error handling driver > > Platform/Sgi: dmc-620 firmware-first error handling > > Platform/Sgi: define memory region for GHES error status block > > Platform/Sgi: Define values for ACPI table header > > Platform/Sgi: Add platform error handling driver > > > > Platform/ARM/Drivers/Dmc620Mm/Dmc620Mm.dec | 30 ++ > > Platform/ARM/SgiPkg/SgiPlatform.dec | 1 + > > Platform/ARM/SgiPkg/SgiPlatform.dsc.inc | 38 ++ > > Platform/ARM/SgiPkg/SgiPlatformMm.dsc.inc | 30 ++ > > Platform/ARM/SgiPkg/PlatformStandaloneMm.fdf | 6 + > > Platform/ARM/SgiPkg/SgiPlatform.fdf | 13 + > > Platform/ARM/Drivers/Dmc620Mm/Dmc620Mm.inf | 61 +++ > > .../PlatformErrorHandlerDxe.inf | 51 +++ > > .../Library/PlatformLib/PlatformLib.inf | 6 + > > Platform/ARM/Drivers/Dmc620Mm/Dmc620Mm.h | 174 +++++++++ > > Platform/ARM/Drivers/Dmc620Mm/Dmc620Mm.c | 362 > > ++++++++++++++++++ > > .../Dmc620Mm/Dmc620MmErrorSourceInfo.c | 194 ++++++++++ > > .../PlatformErrorHandlerDxe.c | 171 +++++++++ > > .../Library/PlatformLib/PlatformLibMem.c | 13 +- > > 14 files changed, 1148 insertions(+), 2 deletions(-) create mode 1006= 44 > > Platform/ARM/Drivers/Dmc620Mm/Dmc620Mm.dec > > create mode 100644 Platform/ARM/Drivers/Dmc620Mm/Dmc620Mm.inf > > create mode 100644 > > Platform/ARM/SgiPkg/Drivers/PlatformErrorHandlerDxe/PlatformErrorHandl > > erDxe.inf > > create mode 100644 Platform/ARM/Drivers/Dmc620Mm/Dmc620Mm.h > > create mode 100644 Platform/ARM/Drivers/Dmc620Mm/Dmc620Mm.c > > create mode 100644 > > Platform/ARM/Drivers/Dmc620Mm/Dmc620MmErrorSourceInfo.c > > create mode 100644 > > Platform/ARM/SgiPkg/Drivers/PlatformErrorHandlerDxe/PlatformErrorHandl > > erDxe.c > > > > -- > > 2.17.1 > > > > > > > > -=3D-=3D-=3D-=3D-=3D-=3D > > Groups.io Links: You receive all messages sent to this group. > > View/Reply Online (#79749): https://edk2.groups.io/g/devel/message/7974= 9 > > Mute This Topic: https://groups.io/mt/85104844/4857533 > > Group Owner: devel+owner@edk2.groups.io > > Unsubscribe: https://edk2.groups.io/g/devel/unsub > > [omkar.kulkarni@arm.com] > > -=3D-=3D-=3D-=3D-=3D-=3D > > > > IMPORTANT NOTICE: The contents of this email and any attachments are conf= idential and may also be privileged. If you are not the intended recipient,= please notify the sender immediately and do not disclose the contents to a= ny other person, use it for any purpose, or store or copy the information i= n any medium. Thank you.