From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by mx.groups.io with SMTP id smtpd.web11.30.1626456750035021895 for ; Fri, 16 Jul 2021 10:32:30 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=eV4EX8ak; spf=pass (domain: kernel.org, ip: 198.145.29.99, mailfrom: ardb@kernel.org) Received: by mail.kernel.org (Postfix) with ESMTPSA id 4385761402 for ; Fri, 16 Jul 2021 17:32:29 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1626456749; bh=Wn5os+Drgu2CRZHk9WrW3ap3jQtrjZj1tB1xccplwrs=; h=References:In-Reply-To:From:Date:Subject:To:Cc:From; b=eV4EX8akyqzJc40mZq1sp7/Ih4sFR3PvaABGibIJMlH87OLefwsVjoyOi+RYUW4p2 0p7+3YcGyis4yq//7MZTCA/cKziruz4mEAJKEybMZF+mnEV69rqx9wF/OkwqLSRhH4 N+jgeYfCW/eBSlznc4Zq31IeD4qfYMtAm9rHhaPYQiTI/7/QGy/wxvOFCl9EUb5WBp 2lCKPZ3YFr2FFSWeDatIG5cQbYU+Y+SUKVcqKPuYLDofR9jWk/vYu/w5cTf4BOdlLV 24BccNjonObm5i1FoH3SxDmWOxK6+oOZGPgjSlqXhM+XSmzZkZ3mhAiHZ2RK/EEvbX zR3LzpupOQaew== Received: by mail-oi1-f175.google.com with SMTP id p67so11760933oig.2 for ; Fri, 16 Jul 2021 10:32:29 -0700 (PDT) X-Gm-Message-State: AOAM533hSgCBTVKEShm0i9LVsRl86jmRnEnfKu4YmQ6e1Oi9bu8s3vpE SW9rQBQxcR6b7tAH5FcBOczCMAcD+sAjOULzOm0= X-Google-Smtp-Source: ABdhPJxsY3cA9B2xfig7+Lc42t3bDrEciiLKBOuKwMTc45TvkB9FfsAW2Q9cfsGejYCdx8uyWWHw5DFS8zp8n+2SM0U= X-Received: by 2002:aca:5a04:: with SMTP id o4mr8682904oib.33.1626456748646; Fri, 16 Jul 2021 10:32:28 -0700 (PDT) MIME-Version: 1.0 References: <20210613181631.2247221-1-mw@semihalf.com> <20210614215540.u2y4oc2s4cvs6kxw@leviathan> In-Reply-To: From: "Ard Biesheuvel" Date: Fri, 16 Jul 2021 19:32:16 +0200 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [edk2-platforms PATCH 0/4] ACPI MDIO support for Marvell SoCs To: Jon Nettleton Cc: Marcin Wojtas , Leif Lindholm , Ard Biesheuvel , edk2-devel-groups-io , Grzegorz Jaszczyk , Grzegorz Bernacki , upstream@semihalf.com, Samer El-Haj-Mahmoud Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable On Mon, 12 Jul 2021 at 13:17, Jon Nettleton wrote: > > On Mon, Jul 12, 2021 at 12:52 PM Marcin Wojtas wrote: > > > > Hi, > > > > wt., 29 cze 2021 o 16:17 Marcin Wojtas napisa=C5=82(a= ): > > > > > > Hi Leif, > > > > > > pon., 14 cze 2021 o 23:55 Leif Lindholm napisa=C5= =82(a): > > > > > > > > Hi Marcin, > > > > > > > > On Sun, Jun 13, 2021 at 20:16:27 +0200, Marcin Wojtas wrote: > > > > > Hi, > > > > > > > > > > The MDIO ACPI binding has been established and merged to the > > > > > Linux tree, > > > > > > > > Congratulations! :) > > > > > > > > Is FreeBSD expected to follow suit? > > > > > > There's no driver yet, but once it's finally created I will make sure > > > it supports ACPI properly. > > > > > > > > > > > > hence it is now possible to update the ACPI > > > > > description of the platforms that base on the Marvell SoCs. > > > > > > > > > > For convenience, the code is exposed in the public github branch: > > > > > https://github.com/semihalf-wojtas-marcin/edk2-platforms/commits/= acpi-mdio-r20210613 > > > > > There is also MacchiatoBin firmware binary avaialable for testing= : > > > > > https://drive.google.com/file/d/1eigP_aeM4wYQpEaLAlQzs3IN_w1-kQr0 > > > > > > > > > > I'm looking forward to the comments or remarks. > > > > > > > > The patches themselves look straightforward enough. > > > > I *would* prefer some tested-by, for these sources rather than the > > > > binary, before merging though. > > > > > > > > > > I have some our patches queued, that are blocked by this patchset. In > > > case no time is found for external testers - if this may help to get > > > it pushed through, please see below logs from the next-20210628 tag > > > and unchanged firmware. All network ports of MacchiatoBin and > > > CN913x-DB work properly, with full 1G/10G PHY support via X/MDIO > > > interfaces: > > > > > > MacchiatoBin > > > # uname -a > > > Linux buildroot 5.13.0-rc7-next-20210628 #6 SMP PREEMPT Tue Jun 29 > > > 09:14:07 CEST 2021 aarch64 GNU/Linux > > > # dmesg | grep MRVL0101 > > > [ 1.829659] mv88x3340 MRVL0101:00-mii:00: Firmware version 0.3.3.0 > > > [ 1.839622] mv88x3340 MRVL0101:00-mii:08: Firmware version 0.3.3.0 > > > [ 2.748351] mvpp2 MRVL0110:00 eth1: PHY [MRVL0101:00-mii:00] drive= r > > > [mv88x3340] (irq=3DPOLL) > > > [ 2.767479] mvpp2 MRVL0110:01 eth2: PHY [MRVL0101:00-mii:08] drive= r > > > [mv88x3340] (irq=3DPOLL) > > > # dmesg | grep MRVL0100 > > > [ 2.919424] mvpp2 MRVL0110:01 eth3: PHY [MRVL0100:00-mii:00] drive= r > > > [Marvell 88E1510] (irq=3DPOLL) > > > # dmesg | grep mvpp2 > > > [...] > > > [ 2.748351] mvpp2 MRVL0110:00 eth1: PHY [MRVL0101:00-mii:00] drive= r > > > [mv88x3340] (irq=3DPOLL) > > > [ 2.756701] mvpp2 MRVL0110:00 eth1: configuring for phy/10gbase-r = link mode > > > [ 2.767479] mvpp2 MRVL0110:01 eth2: PHY [MRVL0101:00-mii:08] drive= r > > > [mv88x3340] (irq=3DPOLL) > > > [ 2.775834] mvpp2 MRVL0110:01 eth2: configuring for phy/10gbase-r = link mode > > > [ 2.919424] mvpp2 MRVL0110:01 eth3: PHY [MRVL0100:00-mii:00] drive= r > > > [Marvell 88E1510] (irq=3DPOLL) > > > [ 2.928285] mvpp2 MRVL0110:01 eth3: configuring for phy/sgmii link= mode > > > [ 2.936351] mvpp2 MRVL0110:01 eth4: configuring for > > > inband/2500base-x link mode > > > [ 5.987259] mvpp2 MRVL0110:01 eth3: Link is Up - 1Gbps/Full - flow > > > control off > > > # > > > > > > CN913x-DB > > > # uname -a > > > Linux buildroot 5.13.0-rc7-next-20210628 #6 SMP PREEMPT Tue Jun 29 > > > 09:14:07 CEST 2021 aarch64 GNU/Linux > > > # dmesg | grep MRVL0100 > > > [ 2.621201] mvpp2 MRVL0110:00 eth2: PHY [MRVL0100:00-mii:00] drive= r > > > [Marvell 88E1510] (irq=3DPOLL) > > > [ 2.741199] mvpp2 MRVL0110:00 eth3: PHY [MRVL0100:00-mii:01] drive= r > > > [Marvell 88E1510] (irq=3DPOLL) > > > # dmesg | grep mvpp2 > > > [...] > > > [ 2.544917] mvpp2 MRVL0110:00 eth1: configuring for > > > inband/10gbase-r link mode > > > [ 2.552480] mvpp2 MRVL0110:00 eth1: Link is Up - 10Gbps/Full - flo= w > > > control rx > > > [ 2.621201] mvpp2 MRVL0110:00 eth2: PHY [MRVL0100:00-mii:00] drive= r > > > [Marvell 88E1510] (irq=3DPOLL) > > > [ 2.630060] mvpp2 MRVL0110:00 eth2: configuring for phy/rgmii-id l= ink mode > > > [ 2.741199] mvpp2 MRVL0110:00 eth3: PHY [MRVL0100:00-mii:01] drive= r > > > [Marvell 88E1510] (irq=3DPOLL) > > > [ 2.750056] mvpp2 MRVL0110:00 eth3: configuring for phy/rgmii-id l= ink mode > > > [ 2.810169] mvpp2 MRVL0110:01 eth4: configuring for > > > inband/10gbase-r link mode > > > [ 2.817471] mvpp2 MRVL0110:01 eth4: Link is Up - 10Gbps/Full - flo= w > > > control rx > > > [ 5.693231] mvpp2 MRVL0110:00 eth2: Link is Up - 1Gbps/Full - flow > > > control off > > > [ 10.840942] mvpp2 MRVL0110:00 eth1: Link is Down > > > [ 10.864124] mvpp2 MRVL0110:01 eth4: Link is Down > > > # > > > > > > > Both platforms were have been additionally tested by Greg, do you have > > any comments/objections to merging this patchset? > > > > Thanks, > > Marcin > > You can add my Tested-by as well. Finally got time over the weekend > to verify on all my Marvell platforms this effects. > Thanks all. I will get to this shortly - apologies for the delay.