public inbox for devel@edk2.groups.io
 help / color / mirror / Atom feed
From: "Ard Biesheuvel" <ardb@kernel.org>
To: Rebecca Cran <rebecca@nuviainc.com>
Cc: edk2-devel-groups-io <devel@edk2.groups.io>,
	Ard Biesheuvel <ardb+tianocore@kernel.org>,
	 Samer El-Haj-Mahmoud <samer.el-haj-mahmoud@arm.com>,
	Leif Lindholm <leif@nuviainc.com>,
	 Sami Mujawar <sami.mujawar@arm.com>,
	Masami Hiramatsu <masami.hiramatsu@linaro.org>,
	 Graeme Gregory <graeme@nuviainc.com>,
	Radoslaw Biernacki <rad@semihalf.com>,
	Marcin Wojtas <mw@semihalf.com>
Subject: Re: [edk2-platforms PATCH 0/8] Update Arm platforms following addition of EFI_MP_SERVICES_PROTOCOL support in edk2
Date: Thu, 16 Dec 2021 14:16:43 +0100	[thread overview]
Message-ID: <CAMj1kXHo0hHbCDiAPNBCK8Wz0QHzSvQZDJ+1u-g8ih0tLHQCHw@mail.gmail.com> (raw)
In-Reply-To: <34eb1118-89a1-7d4d-3705-d9915d5ae859@nuviainc.com>

On Thu, 16 Dec 2021 at 14:13, Rebecca Cran <rebecca@nuviainc.com> wrote:
>
> On 12/16/21 2:32 AM, Ard Biesheuvel wrote:
>
> > You appear to have missed a few instances:
> >
> > Platform/AMD/OverdriveBoard/OverdriveBoard.dsc
> > Platform/BeagleBoard/BeagleBoardPkg/BeagleBoardPkg.dsc
> > Platform/Hisilicon/D03/D03.dsc
> > Platform/Hisilicon/D05/D05.dsc
> > Platform/Hisilicon/D06/D06.dsc
> > Platform/Hisilicon/HiKey/HiKey.dsc
> > Platform/Hisilicon/HiKey960/HiKey960.dsc
> > Platform/LeMaker/CelloBoard/CelloBoard.dsc
> > Platform/Phytium/DurianPkg/DurianPkg.dsc
> > Platform/RaspberryPi/RPi3/RPi3.dsc
> > Platform/RaspberryPi/RPi4/RPi4.dsc
> > Platform/SoftIron/Overdrive1000Board/Overdrive1000Board.dsc
> >
> > I know this is tedious busywork, but you can't break existing
> > platforms like that, so please provide a solution for these as well.
>
> Thanks, I'm not sure how I managed to miss those. I'll send out a v2
> patch with them included.
>
> I agree, I can't break platforms like this.
>
>
> I'm also keeping track of platforms that are currently broken in other
> ways, such as
> Platform/Socionext/SynQuacerEvalBoard/SynQuacerEvalBoard.dsc which needs
> updated for the VariablePolicyHelperLib, and
> Platform/Comcast/RDKQemu/RDKQemu.dsc which has an ACPI build problem.
> Several other platforms claim to support ARM but don't currently build.
> For example, Platform/ARM/SgiPkg/RdV1Mc/RdV1Mc.dsc fails with:
>
>
>   : error F000: No files to be built in module [RELEASE, GCC5, ARM]
> [/home/bcran/src/upstream/uefi/edk2/ArmPkg/Drivers/MmCommunicationDxe/MmCommunication.inf]
>

There were some changes a while ago to support standalone MM in 32-bit
mode, but I don't think any of the Platform/ARM platforms implement
that. So the best fix here is to simply stop lying about ARM support.

As for RdkQemu - I think it is time we just remove that.

  reply	other threads:[~2021-12-16 13:16 UTC|newest]

Thread overview: 26+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-12-15  0:03 [edk2-platforms PATCH 0/8] Update Arm platforms following addition of EFI_MP_SERVICES_PROTOCOL support in edk2 Rebecca Cran
2021-12-15  0:03 ` [edk2-platforms PATCH 1/8] Platform/ARM: Add MpInitLib instance Rebecca Cran
2021-12-15  0:03 ` [edk2-platforms PATCH 2/8] Platform/Socionext: Add instance of MpInitLib Rebecca Cran
2021-12-15  0:03 ` [edk2-platforms PATCH 3/8] Silicon/Marvell: " Rebecca Cran
2021-12-16  7:14   ` Marcin Wojtas
2021-12-15  0:03 ` [edk2-platforms PATCH 4/8] Platform/Qemu: " Rebecca Cran
2021-12-15  0:03 ` [edk2-platforms PATCH 5/8] Platform/ARM: Update ARM_CORE_INFO initializer for MPIDR field change Rebecca Cran
2021-12-15  0:03 ` [edk2-platforms PATCH 6/8] Silicon/Marvell: " Rebecca Cran
2021-12-15  0:03 ` [edk2-platforms PATCH 7/8] Silicon/Socionext: " Rebecca Cran
2021-12-15  0:03 ` [edk2-platforms PATCH 8/8] Silicon/Qemu: " Rebecca Cran
2021-12-15  8:16 ` [edk2-platforms PATCH 0/8] Update Arm platforms following addition of EFI_MP_SERVICES_PROTOCOL support in edk2 Ard Biesheuvel
2021-12-16  9:32 ` Ard Biesheuvel
2021-12-16 13:13   ` Rebecca Cran
2021-12-16 13:16     ` Ard Biesheuvel [this message]
2021-12-16 13:38       ` [edk2-devel] " Marcin Juszkiewicz
2021-12-16 15:05         ` Ard Biesheuvel
2021-12-16 18:54           ` Sami Mujawar
2021-12-16 18:55             ` Ard Biesheuvel
2021-12-16 22:09       ` Rebecca Cran
2021-12-19 10:32         ` Marcin Wojtas
2022-01-10 20:33           ` Rebecca Cran
2021-12-16 13:26     ` Sami Mujawar
2021-12-16 14:59       ` Rebecca Cran
2021-12-16 15:26         ` PierreGondois
2021-12-16 15:44           ` Rebecca Cran
2021-12-16 15:27       ` Rebecca Cran

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-list from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CAMj1kXHo0hHbCDiAPNBCK8Wz0QHzSvQZDJ+1u-g8ih0tLHQCHw@mail.gmail.com \
    --to=devel@edk2.groups.io \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox