From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by mx.groups.io with SMTP id smtpd.web09.10358.1639660617880294088 for ; Thu, 16 Dec 2021 05:16:58 -0800 Authentication-Results: mx.groups.io; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=Ji98G0Vh; spf=pass (domain: kernel.org, ip: 139.178.84.217, mailfrom: ardb@kernel.org) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id F226561961 for ; Thu, 16 Dec 2021 13:16:56 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 671B6C36AE0 for ; Thu, 16 Dec 2021 13:16:56 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1639660616; bh=p3c1dGe1ObY361xL7ssV7hHv7rnh7Q3rUZ5tvdeaLVQ=; h=References:In-Reply-To:From:Date:Subject:To:Cc:From; b=Ji98G0VhRRq7nzJsPA0/hpVCmGbKt1+Ec050ZDb7HQK2BIFEL2wai7KFNBtX6CbW3 Al+/f6xcXRqFmPLY7rGvnj7GKDHgPMXwl3Ej8D54JSwHn6fkgxDLbkA5xaxWA2OQuN 5R7VcNoKmesDKRTaBQsgrQOlHDCAgz4VqSlUe8QqJyS5dL56xGK2z+8FuVp5VWfYFr ux/EEwQpOMQjDyRprbB821gM/qnkLL4I+YLJEDkOEYg0NBMr5xr1+4j83B1kcmOGn3 6e3TUIsDdOd1WOQBphRSnXhluEsOtmdoSnBx0mH8guySQ/l3GYf2mlLlQ85z9mOAlX B2CeyxBIE5UcQ== Received: by mail-wm1-f45.google.com with SMTP id o19-20020a1c7513000000b0033a93202467so18105467wmc.2 for ; Thu, 16 Dec 2021 05:16:56 -0800 (PST) X-Gm-Message-State: AOAM531qf2pgEm7fWWJ/UPluABqVQJjLeLUXmk1Qol3/di5yTUGGPQJ7 1XmTnq9WruvdCnTkRwTxhIpHA70QdrQ71RylYT0= X-Google-Smtp-Source: ABdhPJyYX3QxucWksYpVyWaD6eNX9WIg8MJ5stQEFUcBze56X+5QXW1B2J8G4kcYnUtAVwoJ5REB8WVMeBoNcdekq+w= X-Received: by 2002:a05:600c:3486:: with SMTP id a6mr4955887wmq.32.1639660614789; Thu, 16 Dec 2021 05:16:54 -0800 (PST) MIME-Version: 1.0 References: <20211215000324.11591-1-rebecca@nuviainc.com> <34eb1118-89a1-7d4d-3705-d9915d5ae859@nuviainc.com> In-Reply-To: <34eb1118-89a1-7d4d-3705-d9915d5ae859@nuviainc.com> From: "Ard Biesheuvel" Date: Thu, 16 Dec 2021 14:16:43 +0100 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [edk2-platforms PATCH 0/8] Update Arm platforms following addition of EFI_MP_SERVICES_PROTOCOL support in edk2 To: Rebecca Cran Cc: edk2-devel-groups-io , Ard Biesheuvel , Samer El-Haj-Mahmoud , Leif Lindholm , Sami Mujawar , Masami Hiramatsu , Graeme Gregory , Radoslaw Biernacki , Marcin Wojtas Content-Type: text/plain; charset="UTF-8" On Thu, 16 Dec 2021 at 14:13, Rebecca Cran wrote: > > On 12/16/21 2:32 AM, Ard Biesheuvel wrote: > > > You appear to have missed a few instances: > > > > Platform/AMD/OverdriveBoard/OverdriveBoard.dsc > > Platform/BeagleBoard/BeagleBoardPkg/BeagleBoardPkg.dsc > > Platform/Hisilicon/D03/D03.dsc > > Platform/Hisilicon/D05/D05.dsc > > Platform/Hisilicon/D06/D06.dsc > > Platform/Hisilicon/HiKey/HiKey.dsc > > Platform/Hisilicon/HiKey960/HiKey960.dsc > > Platform/LeMaker/CelloBoard/CelloBoard.dsc > > Platform/Phytium/DurianPkg/DurianPkg.dsc > > Platform/RaspberryPi/RPi3/RPi3.dsc > > Platform/RaspberryPi/RPi4/RPi4.dsc > > Platform/SoftIron/Overdrive1000Board/Overdrive1000Board.dsc > > > > I know this is tedious busywork, but you can't break existing > > platforms like that, so please provide a solution for these as well. > > Thanks, I'm not sure how I managed to miss those. I'll send out a v2 > patch with them included. > > I agree, I can't break platforms like this. > > > I'm also keeping track of platforms that are currently broken in other > ways, such as > Platform/Socionext/SynQuacerEvalBoard/SynQuacerEvalBoard.dsc which needs > updated for the VariablePolicyHelperLib, and > Platform/Comcast/RDKQemu/RDKQemu.dsc which has an ACPI build problem. > Several other platforms claim to support ARM but don't currently build. > For example, Platform/ARM/SgiPkg/RdV1Mc/RdV1Mc.dsc fails with: > > > : error F000: No files to be built in module [RELEASE, GCC5, ARM] > [/home/bcran/src/upstream/uefi/edk2/ArmPkg/Drivers/MmCommunicationDxe/MmCommunication.inf] > There were some changes a while ago to support standalone MM in 32-bit mode, but I don't think any of the Platform/ARM platforms implement that. So the best fix here is to simply stop lying about ARM support. As for RdkQemu - I think it is time we just remove that.