public inbox for devel@edk2.groups.io
 help / color / mirror / Atom feed
From: "Ard Biesheuvel" <ardb@kernel.org>
To: devel@edk2.groups.io, mikuback@linux.microsoft.com
Cc: Ard Biesheuvel <ardb+tianocore@kernel.org>,
	Jiewen Yao <jiewen.yao@intel.com>,
	 Jordan Justen <jordan.l.justen@intel.com>,
	Gerd Hoffmann <kraxel@redhat.com>,
	 Michael D Kinney <michael.d.kinney@intel.com>
Subject: Re: [edk2-devel] [PATCH v1 1/1] OvmfPkg/CI: Revert SMP mode
Date: Fri, 31 Mar 2023 18:13:32 +0200	[thread overview]
Message-ID: <CAMj1kXHogXJvGH+hgeqp2uykfSK+RNerDPpKc7bJkCs4WtCe+w@mail.gmail.com> (raw)
In-Reply-To: <20230331161043.191-1-mikuback@linux.microsoft.com>

On Fri, 31 Mar 2023 at 18:11, Michael Kubacki
<mikuback@linux.microsoft.com> wrote:
>
> From: Michael Kubacki <michael.kubacki@microsoft.com>
>
> This is causing excessive boot times in the VS2019 IA32/X64 Full
> run to shell tasks (> 2 minutes) and blocking all edk2 CI.
>
> This patch removes the change so it can be root caused separately
> without blocking other patches unrelated to OVMF.
>
> Reverts f92a9dce10281c103b04d6b38283e0ff1d677b91
>
> Cc: Ard Biesheuvel <ardb+tianocore@kernel.org>
> Cc: Jiewen Yao <jiewen.yao@intel.com>
> Cc: Jordan Justen <jordan.l.justen@intel.com>
> Cc: Gerd Hoffmann <kraxel@redhat.com>
> Cc: Michael D Kinney <michael.d.kinney@intel.com>
> Signed-off-by: Michael Kubacki <michael.kubacki@microsoft.com>
> ---
>  OvmfPkg/PlatformCI/PlatformBuildLib.py | 1 -
>  1 file changed, 1 deletion(-)
>
> diff --git a/OvmfPkg/PlatformCI/PlatformBuildLib.py b/OvmfPkg/PlatformCI/PlatformBuildLib.py
> index 1ff85fdc24bb..64fca48a7d1d 100644
> --- a/OvmfPkg/PlatformCI/PlatformBuildLib.py
> +++ b/OvmfPkg/PlatformCI/PlatformBuildLib.py
> @@ -196,7 +196,6 @@ class PlatformBuilder( UefiBuilder, BuildSettingsManager):
>          args  = "-debugcon stdio"                                           # write messages to stdio
>          args += " -global isa-debugcon.iobase=0x402"                        # debug messages out thru virtual io port
>          args += " -net none"                                                # turn off network
> -        args += " -smp 4"
>          args += f" -drive file=fat:rw:{VirtualDrive},format=raw,media=disk" # Mount disk with startup.nsh
>
>          if (self.env.GetValue("QEMU_HEADLESS").upper() == "TRUE"):

Thanks for the fixed

Queued up as #4220

      parent reply	other threads:[~2023-03-31 16:13 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-03-31 16:10 [PATCH v1 1/1] OvmfPkg/CI: Revert SMP mode Michael Kubacki
2023-03-31 16:13 ` [edk2-devel] " Michael D Kinney
2023-03-31 16:59   ` Ni, Ray
2023-03-31 18:50     ` Michael Kubacki
2023-03-31 16:13 ` Ard Biesheuvel [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-list from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CAMj1kXHogXJvGH+hgeqp2uykfSK+RNerDPpKc7bJkCs4WtCe+w@mail.gmail.com \
    --to=devel@edk2.groups.io \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox