* [PATCH] ArmPlatformPkg: Add PCD for serial debug port interrupt
@ 2022-06-22 10:12 Thomas Abraham
2022-06-22 14:52 ` [edk2-devel] " Ard Biesheuvel
0 siblings, 1 reply; 3+ messages in thread
From: Thomas Abraham @ 2022-06-22 10:12 UTC (permalink / raw)
To: devel; +Cc: Ard Biesheuvel, Leif Lindholm, Sami Mujawar
Add a PCD to specify the interrupt number of the serial debug port
controller.
Signed-off-by: Thomas Abraham <thomas.abraham@arm.com>
Change-Id: I4ce6d29cdf5e8b5fcbfe740269d966a53f2b852a
---
ArmPlatformPkg/ArmPlatformPkg.dec | 1 +
1 file changed, 1 insertion(+)
diff --git a/ArmPlatformPkg/ArmPlatformPkg.dec b/ArmPlatformPkg/ArmPlatformPkg.dec
index 3a25ddcdc8..dd6e78f62a 100644
--- a/ArmPlatformPkg/ArmPlatformPkg.dec
+++ b/ArmPlatformPkg/ArmPlatformPkg.dec
@@ -94,6 +94,7 @@
gArmPlatformTokenSpaceGuid.PcdSerialDbgRegisterBase|0x00000000|UINT64|0x00000030
gArmPlatformTokenSpaceGuid.PcdSerialDbgUartBaudRate|0x00000000|UINT64|0x00000031
gArmPlatformTokenSpaceGuid.PcdSerialDbgUartClkInHz|0x00000000|UINT32|0x00000032
+ gArmPlatformTokenSpaceGuid.PcdSerialDbgInterrupt|0x00000000|UINT32|0x00000041
## PL061 GPIO
gArmPlatformTokenSpaceGuid.PcdPL061GpioBase|0x0|UINT32|0x00000025
--
2.17.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [edk2-devel] [PATCH] ArmPlatformPkg: Add PCD for serial debug port interrupt
2022-06-22 10:12 [PATCH] ArmPlatformPkg: Add PCD for serial debug port interrupt Thomas Abraham
@ 2022-06-22 14:52 ` Ard Biesheuvel
2022-06-22 15:41 ` Thomas Abraham
0 siblings, 1 reply; 3+ messages in thread
From: Ard Biesheuvel @ 2022-06-22 14:52 UTC (permalink / raw)
To: edk2-devel-groups-io, Thomas Abraham
Cc: Ard Biesheuvel, Leif Lindholm, Sami Mujawar
On Wed, 22 Jun 2022 at 12:12, Thomas Abraham <thomas.abraham@arm.com> wrote:
>
> Add a PCD to specify the interrupt number of the serial debug port
> controller.
>
Why do we need this?
> Signed-off-by: Thomas Abraham <thomas.abraham@arm.com>
> Change-Id: I4ce6d29cdf5e8b5fcbfe740269d966a53f2b852a
Please drop the change id
> ---
> ArmPlatformPkg/ArmPlatformPkg.dec | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/ArmPlatformPkg/ArmPlatformPkg.dec b/ArmPlatformPkg/ArmPlatformPkg.dec
> index 3a25ddcdc8..dd6e78f62a 100644
> --- a/ArmPlatformPkg/ArmPlatformPkg.dec
> +++ b/ArmPlatformPkg/ArmPlatformPkg.dec
> @@ -94,6 +94,7 @@
> gArmPlatformTokenSpaceGuid.PcdSerialDbgRegisterBase|0x00000000|UINT64|0x00000030
> gArmPlatformTokenSpaceGuid.PcdSerialDbgUartBaudRate|0x00000000|UINT64|0x00000031
> gArmPlatformTokenSpaceGuid.PcdSerialDbgUartClkInHz|0x00000000|UINT32|0x00000032
> + gArmPlatformTokenSpaceGuid.PcdSerialDbgInterrupt|0x00000000|UINT32|0x00000041
>
> ## PL061 GPIO
> gArmPlatformTokenSpaceGuid.PcdPL061GpioBase|0x0|UINT32|0x00000025
> --
> 2.17.1
>
>
>
>
>
>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [edk2-devel] [PATCH] ArmPlatformPkg: Add PCD for serial debug port interrupt
2022-06-22 14:52 ` [edk2-devel] " Ard Biesheuvel
@ 2022-06-22 15:41 ` Thomas Abraham
0 siblings, 0 replies; 3+ messages in thread
From: Thomas Abraham @ 2022-06-22 15:41 UTC (permalink / raw)
To: Ard Biesheuvel, edk2-devel-groups-io
Cc: Ard Biesheuvel, Leif Lindholm, Sami Mujawar
On 22/06/2022 15:52, Ard Biesheuvel wrote:
> On Wed, 22 Jun 2022 at 12:12, Thomas Abraham <thomas.abraham@arm.com> wrote:
>>
>> Add a PCD to specify the interrupt number of the serial debug port
>> controller.
>>
>
> Why do we need this?
The commit message will be updated in next version of this patch the
describes the need for this change.
>
>> Signed-off-by: Thomas Abraham <thomas.abraham@arm.com>
>> Change-Id: I4ce6d29cdf5e8b5fcbfe740269d966a53f2b852a
>
> Please drop the change id
Apologies, I missed this, will fix in the next version.
Thanks Ard for your review.
>
>> ---
>> ArmPlatformPkg/ArmPlatformPkg.dec | 1 +
>> 1 file changed, 1 insertion(+)
>>
>> diff --git a/ArmPlatformPkg/ArmPlatformPkg.dec b/ArmPlatformPkg/ArmPlatformPkg.dec
>> index 3a25ddcdc8..dd6e78f62a 100644
>> --- a/ArmPlatformPkg/ArmPlatformPkg.dec
>> +++ b/ArmPlatformPkg/ArmPlatformPkg.dec
>> @@ -94,6 +94,7 @@
>> gArmPlatformTokenSpaceGuid.PcdSerialDbgRegisterBase|0x00000000|UINT64|0x00000030
>> gArmPlatformTokenSpaceGuid.PcdSerialDbgUartBaudRate|0x00000000|UINT64|0x00000031
>> gArmPlatformTokenSpaceGuid.PcdSerialDbgUartClkInHz|0x00000000|UINT32|0x00000032
>> + gArmPlatformTokenSpaceGuid.PcdSerialDbgInterrupt|0x00000000|UINT32|0x00000041
>>
>> ## PL061 GPIO
>> gArmPlatformTokenSpaceGuid.PcdPL061GpioBase|0x0|UINT32|0x00000025
>> --
>> 2.17.1
>>
>>
>>
>>
>>
>>
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2022-06-22 15:41 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2022-06-22 10:12 [PATCH] ArmPlatformPkg: Add PCD for serial debug port interrupt Thomas Abraham
2022-06-22 14:52 ` [edk2-devel] " Ard Biesheuvel
2022-06-22 15:41 ` Thomas Abraham
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox