From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217])
 by mx.groups.io with SMTP id smtpd.web10.8204.1655909570990098257
 for <devel@edk2.groups.io>;
 Wed, 22 Jun 2022 07:52:51 -0700
Authentication-Results: mx.groups.io;
 dkim=pass header.i=@kernel.org header.s=k20201202 header.b=gPKeZdUX;
 spf=pass (domain: kernel.org, ip: 139.178.84.217, mailfrom: ardb@kernel.org)
Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140])
	(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
	(No client certificate requested)
	by dfw.source.kernel.org (Postfix) with ESMTPS id 6E0BE6194B
	for <devel@edk2.groups.io>; Wed, 22 Jun 2022 14:52:50 +0000 (UTC)
Received: by smtp.kernel.org (Postfix) with ESMTPSA id D8266C3411B
	for <devel@edk2.groups.io>; Wed, 22 Jun 2022 14:52:49 +0000 (UTC)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org;
	s=k20201202; t=1655909569;
	bh=iVDrp0CWB3+9nG2UxJ64USNVbaI+iTNu4zjEx2tXN74=;
	h=References:In-Reply-To:From:Date:Subject:To:Cc:From;
	b=gPKeZdUXUm9OfcNjFpjuyhOc9/BlcsmtONKThC1b9mAfpnq/soPKxu+df0FZuXRFc
	 GtI8Ic835l6Eih7ZUC0Jkfr5fTtpMKsh5gtTQjcdUFm6nfGojfSxsQZZaiZS0op8XH
	 p6HpJ48jfXUgPCEnJJAAmcAuB0Eiyjx3kiIFOwYPIhzoWqPq7VaANt1cQSFEMrAKiw
	 5UrPdotHG2xfRxbLf5T/rtx/7+VWWP79U+Eac6L8xPpJeU0MDSUoW7IvSP0j+sDz3h
	 ahvq1hQsHuchicBVZJ+XsUg6uws7avWJwlm9+kr6gslUroMeG25d2xUJPelKFnqlWu
	 Z1N5Q6/wbydrw==
Received: by mail-lf1-f46.google.com with SMTP id i18so14572438lfu.8
        for <devel@edk2.groups.io>; Wed, 22 Jun 2022 07:52:49 -0700 (PDT)
X-Gm-Message-State: AJIora+Lm8NfWAe3WW3o8jxq6Ib3qEoGpYDpbLFEkncnNdOiKMQibHxy
	76IA0N3SCO02Nn47+J7n3+Iz538ScPO6G8Irwfw=
X-Google-Smtp-Source: AGRyM1uumwuG6JugIX8hS921JH0AFKOTfYd/mKHnDnuuGu//bmR46XmKtJvHT7zOn1cYUsr6sGtCZ6Zs6dlT0cXSbGc=
X-Received: by 2002:a05:6512:3045:b0:479:45d9:9476 with SMTP id
 b5-20020a056512304500b0047945d99476mr2365470lfb.181.1655909567942; Wed, 22
 Jun 2022 07:52:47 -0700 (PDT)
MIME-Version: 1.0
References: <20220622101210.21354-1-thomas.abraham@arm.com>
In-Reply-To: <20220622101210.21354-1-thomas.abraham@arm.com>
From: "Ard Biesheuvel" <ardb@kernel.org>
Date: Wed, 22 Jun 2022 16:52:36 +0200
X-Gmail-Original-Message-ID: <CAMj1kXHp-P-Gs-PNQhBOU7tdrOQYZYFHUmQwqR7OBBjzPXvS5w@mail.gmail.com>
Message-ID: <CAMj1kXHp-P-Gs-PNQhBOU7tdrOQYZYFHUmQwqR7OBBjzPXvS5w@mail.gmail.com>
Subject: Re: [edk2-devel] [PATCH] ArmPlatformPkg: Add PCD for serial debug port interrupt
To: edk2-devel-groups-io <devel@edk2.groups.io>, Thomas Abraham <thomas.abraham@arm.com>
Cc: Ard Biesheuvel <ardb+tianocore@kernel.org>, Leif Lindholm <quic_llindhol@quicinc.com>, 
	Sami Mujawar <sami.mujawar@arm.com>
Content-Type: text/plain; charset="UTF-8"

On Wed, 22 Jun 2022 at 12:12, Thomas Abraham <thomas.abraham@arm.com> wrote:
>
> Add a PCD to specify the interrupt number of the serial debug port
> controller.
>

Why do we need this?

> Signed-off-by: Thomas Abraham <thomas.abraham@arm.com>
> Change-Id: I4ce6d29cdf5e8b5fcbfe740269d966a53f2b852a

Please drop the change id

> ---
>  ArmPlatformPkg/ArmPlatformPkg.dec | 1 +
>  1 file changed, 1 insertion(+)
>
> diff --git a/ArmPlatformPkg/ArmPlatformPkg.dec b/ArmPlatformPkg/ArmPlatformPkg.dec
> index 3a25ddcdc8..dd6e78f62a 100644
> --- a/ArmPlatformPkg/ArmPlatformPkg.dec
> +++ b/ArmPlatformPkg/ArmPlatformPkg.dec
> @@ -94,6 +94,7 @@
>    gArmPlatformTokenSpaceGuid.PcdSerialDbgRegisterBase|0x00000000|UINT64|0x00000030
>    gArmPlatformTokenSpaceGuid.PcdSerialDbgUartBaudRate|0x00000000|UINT64|0x00000031
>    gArmPlatformTokenSpaceGuid.PcdSerialDbgUartClkInHz|0x00000000|UINT32|0x00000032
> +  gArmPlatformTokenSpaceGuid.PcdSerialDbgInterrupt|0x00000000|UINT32|0x00000041
>
>    ## PL061 GPIO
>    gArmPlatformTokenSpaceGuid.PcdPL061GpioBase|0x0|UINT32|0x00000025
> --
> 2.17.1
>
>
>
> 
>
>