From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by mx.groups.io with SMTP id smtpd.web09.5126.1662536120089975664 for ; Wed, 07 Sep 2022 00:35:20 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=A88ZofSR; spf=pass (domain: kernel.org, ip: 139.178.84.217, mailfrom: ardb@kernel.org) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 2839B617AE for ; Wed, 7 Sep 2022 07:35:19 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 05F73C43140 for ; Wed, 7 Sep 2022 07:35:17 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1662536118; bh=vgQsbUt2aoZJzfiH2itCGx+kKwjD8xNhAeqnTkFEIa8=; h=References:In-Reply-To:From:Date:Subject:To:Cc:From; b=A88ZofSReY+cqhhyrslvNgetZPnR4SsFieOJ+bV5yn/6UB/k9djat4yXdz7DLlCKD W1KRWsCjWS+LEwTSzWYzW9dSyLsTQcl3QmlL3nPDJ/waOctiSPKCiubW9InLfrtGjx 1V3+Pm1nYW7xhA+3Tqzo+IZr3OSQRspqRqV8DBu70Hr6ZOlcq0eSQXLW3rQN4D9kVY 7dlV7zTj+BG+GIAOjue5HZ/xUVG8BaJhQzbw4PF6xgegp4Ds7m5Zt3WmfAmguX/49e InwZlLat+DFpY0IykA6bu6MM1PmPaE4uk9OMtzz9xm8/QJOzZB0ME8l6GByrlXK8Lq mlcNX+7+MMJ9w== Received: by mail-lj1-f181.google.com with SMTP id v6so1541639ljj.0 for ; Wed, 07 Sep 2022 00:35:17 -0700 (PDT) X-Gm-Message-State: ACgBeo0IDVNd+ODrVe8lR0lSbK2nptHr3pxzRpKUxgmKn37Q+u8weOnP PCmLuhgDHw55gcrMEMQb/f4KNgcPGx0Fo5Zp85Q= X-Google-Smtp-Source: AA6agR71Jm5mRVFjhzRdj0NHEFsbOlGv939ufRIJJzsiU82Qa9VJ/nCgs3vTwTUMpNlmJX8dHIHrOwpwn1+feMPgnv8= X-Received: by 2002:a05:651c:1508:b0:268:a367:ebd8 with SMTP id e8-20020a05651c150800b00268a367ebd8mr654672ljf.516.1662536115906; Wed, 07 Sep 2022 00:35:15 -0700 (PDT) MIME-Version: 1.0 References: <20220907040326.388003-1-rebecca@quicinc.com> <20220907040326.388003-2-rebecca@quicinc.com> <1712796FB27A1CB6.17907@groups.io> <817ece1b-ab1d-7639-093d-de40867ea1b8@quicinc.com> In-Reply-To: <817ece1b-ab1d-7639-093d-de40867ea1b8@quicinc.com> From: "Ard Biesheuvel" Date: Wed, 7 Sep 2022 09:35:04 +0200 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [edk2-devel] [PATCH v2 1/2] ArmPkg: implement EFI_MP_SERVICES_PROTOCOL based on PSCI calls To: devel@edk2.groups.io, quic_rcran@quicinc.com, quic_llindhol@quicinc.com, Michael Kinney , Andrew Fish Cc: Sami Mujawar , Jian J Wang , Liming Gao , Michael Kubacki Content-Type: text/plain; charset="UTF-8" On Wed, 7 Sept 2022 at 06:35, Rebecca Cran wrote: > > Also, CI is failing in the SpellCheck test because of the > "-mstrict-align" in > ArmPsciMpServicesDxe.inf. > > /home/vsts/work/1/s/ArmPkg/Drivers/ArmPsciMpServicesDxe/ArmPsciMpServicesDxe.inf:55:25 > - Unknown word (mstrict) > > Should I add "mstrict" to pytool/Plugin/SpellCheck/cspell.base.yaml ? > This is getting ridiculous. I'm all for code quality and automation, but if t we cannot use compiler command line options that it supported since the dawn of time without bending over backwards to placate the CI machine, we are throwing out the baby with the bath water. At the very least, maintainers should be able to override the CI - I spent 2 hours yesterday preparing a submission that ultimately got rejected because MPIDR is not in the permitted word list (suggestion: use 'mpidr') In the Linux kernel, we have patch check and sparse (which is somewhat similar to ECC in a sense). Some maintainers run it, some don't, but in the end, the discretion lies with the person not the machine. This is the only way that makes sense. As the co-maintainer of ArmPkg, ArmVirtPkg, ArmPlatformPkg, OvmfPkg and EmbeddedPkg, I hereby request that the Ci restrictions are either lifted entirely for these packages, or relaxed so that a PR can be merged at my discretion, even if the CI thinks there are unresolved issues. > On 9/6/22 22:25, Rebecca Cran wrote: > > On 9/6/22 22:03, Rebecca Cran wrote: > >> diff --git a/ArmPkg/ArmPkg.dsc b/ArmPkg/ArmPkg.dsc > >> index 59fd8f295d4f..4716789402fc 100644 > >> --- a/ArmPkg/ArmPkg.dsc > >> +++ b/ArmPkg/ArmPkg.dsc > >> @@ -125,6 +125,7 @@ [Components.common] > >> ArmPkg/Drivers/CpuPei/CpuPei.inf > >> ArmPkg/Drivers/ArmGic/ArmGicDxe.inf > >> ArmPkg/Drivers/ArmGic/ArmGicLib.inf > >> + ArmPkg/Drivers/ArmPsciMpServicesDxe/ArmPsciMpServicesDxe.inf > >> ArmPkg/Drivers/GenericWatchdogDxe/GenericWatchdogDxe.inf > >> ArmPkg/Drivers/TimerDxe/TimerDxe.inf > > This won't work, since there's no support for 32-bit ARM code. > > I'll move it into the AARCH64 section. > > > > > > > >