Re: [PATCH] OvmfPkg: Close mAcceptAllMemoryEvent

["Ard Biesheuvel" <ardb@kernel.org>]

On Wed, 15 Feb 2023 at 00:07, Dionna Glaze <dionnaglaze@google.com> wrote:
>
> This event should only trigger once. It should be idempotent, but the
> allocation of the memory map itself is observable and can cause
> ExitBootServices to fail with a modified map key.
>
> Cc: Ard Biesheuvel <ardb@kernel.org>
> Cc: Thomas Lendacky <Thomas.Lendacky@amd.com>
> Cc: Erdem Aktas <erdemaktas@google.com>
> Cc: James Bottomley <jejb@linux.ibm.com>
> Cc: Jiewen Yao <jiewen.yao@intel.com>
> Cc: Min Xu <min.m.xu@intel.com>
> Cc: Michael Roth <michael.roth@amd.com>
>
> Signed-off-by: Dionna Glaze <dionnaglaze@google.com>
> ---
>  OvmfPkg/AmdSevDxe/AmdSevDxe.c | 1 +
>  1 file changed, 1 insertion(+)
>
> diff --git a/OvmfPkg/AmdSevDxe/AmdSevDxe.c b/OvmfPkg/AmdSevDxe/AmdSevDxe.c
> index 6391d1f775..f9baca90bd 100644
> --- a/OvmfPkg/AmdSevDxe/AmdSevDxe.c
> +++ b/OvmfPkg/AmdSevDxe/AmdSevDxe.c
> @@ -124,6 +124,7 @@ AcceptAllMemory (
>    }
>
>    gBS->FreePool (AllDescMap);
> +  gBS->CloseEvent (mAcceptAllMemoryEvent);
>    return Status;
>  }
>
> --
> 2.39.1.637.g21b0678d19-goog
>

Reviewed-by: Ard Biesheuvel <ardb@kernel.org>

Queued as #4041