[PATCH v2 0/3] OvmfPkg/Bhyve: enable bus enumeration

[PATCH v2 0/3] OvmfPkg/Bhyve: enable bus enumeration

[Corvin Köhne]

CI: https://github.com/tianocore/edk2/pull/4543

Corvin Köhne (3):
  Revert "OvmfPkg/Bhyve: consume PciHostBridgeLibScan"
  Revert "OvmfPkg/Bhyve: remove IncompatiblePciDeviceSupport DXE driver"
  OvmfPkg/BhyvePkg: enable bus enumeration

 OvmfPkg/Bhyve/BhyveX64.dsc | 4 ++--
 OvmfPkg/Bhyve/BhyveX64.fdf | 1 +
 2 files changed, 3 insertions(+), 2 deletions(-)

-- 
2.41.0

[PATCH v2 1/3] Revert "OvmfPkg/Bhyve: consume PciHostBridgeLibScan"

[Corvin Köhne]

We like to enable bus enumartion for bhyve. Therefore, this patch needs
to be reverted.

This reverts commit c2f24ba3218ae91a8d5a1a31c31dad3417850d0c.

Signed-off-by: Corvin Köhne <corvink@FreeBSD.org>
Acked-by: Peter Grehan <grehan@freebsd.org>
Cc: Ard Biesheuvel <ardb+tianocore@kernel.org>
Cc: Gerd Hoffmann <kraxel@redhat.com>
Cc: Jiewen Yao <jiewen.yao@intel.com>
Cc: Jordan Justen <jordan.l.justen@intel.com>
Cc: Rebecca Cran <rebecca@bsdio.com>
---
 OvmfPkg/Bhyve/BhyveX64.dsc | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/OvmfPkg/Bhyve/BhyveX64.dsc b/OvmfPkg/Bhyve/BhyveX64.dsc
index 7fa40998ae80..fd3f8470f2c6 100644
--- a/OvmfPkg/Bhyve/BhyveX64.dsc
+++ b/OvmfPkg/Bhyve/BhyveX64.dsc
@@ -650,7 +650,7 @@ [Components]
   OvmfPkg/PciHotPlugInitDxe/PciHotPlugInit.inf
   MdeModulePkg/Bus/Pci/PciHostBridgeDxe/PciHostBridgeDxe.inf {
     <LibraryClasses>
-      PciHostBridgeLib|OvmfPkg/Library/PciHostBridgeLibScan/PciHostBridgeLibScan.inf
+      PciHostBridgeLib|OvmfPkg/Library/PciHostBridgeLib/PciHostBridgeLib.inf
       PciHostBridgeUtilityLib|OvmfPkg/Library/PciHostBridgeUtilityLib/PciHostBridgeUtilityLib.inf
       NULL|OvmfPkg/Library/PlatformHasIoMmuLib/PlatformHasIoMmuLib.inf
   }
-- 
2.41.0

[PATCH v2 2/3] Revert "OvmfPkg/Bhyve: remove IncompatiblePciDeviceSupport DXE driver"

[Corvin Köhne]

We like to enable bus enumeration for bhyve. Therefore, this patch needs
to be reverted.

This reverts commit 8c8f886f27556f2fb6e8b502d32aa9ccee930acc.

Signed-off-by: Corvin Köhne <corvink@FreeBSD.org>
Acked-by: Peter Grehan <grehan@freebsd.org>
Cc: Ard Biesheuvel <ardb+tianocore@kernel.org>
Cc: Jiewen Yao <jiewen.yao@intel.com>
Cc: Jordan Justen <jordan.l.justen@intel.com>
Cc: Gerd Hoffmann <kraxel@redhat.com>
Cc: Rebecca Cran <rebecca@bsdio.com>
---
 OvmfPkg/Bhyve/BhyveX64.dsc | 1 +
 OvmfPkg/Bhyve/BhyveX64.fdf | 1 +
 2 files changed, 2 insertions(+)

diff --git a/OvmfPkg/Bhyve/BhyveX64.dsc b/OvmfPkg/Bhyve/BhyveX64.dsc
index fd3f8470f2c6..873eec60906e 100644
--- a/OvmfPkg/Bhyve/BhyveX64.dsc
+++ b/OvmfPkg/Bhyve/BhyveX64.dsc
@@ -647,6 +647,7 @@ [Components]
   UefiCpuPkg/CpuIo2Dxe/CpuIo2Dxe.inf
   UefiCpuPkg/CpuDxe/CpuDxe.inf
   PcAtChipsetPkg/HpetTimerDxe/HpetTimerDxe.inf
+  OvmfPkg/IncompatiblePciDeviceSupportDxe/IncompatiblePciDeviceSupport.inf
   OvmfPkg/PciHotPlugInitDxe/PciHotPlugInit.inf
   MdeModulePkg/Bus/Pci/PciHostBridgeDxe/PciHostBridgeDxe.inf {
     <LibraryClasses>
diff --git a/OvmfPkg/Bhyve/BhyveX64.fdf b/OvmfPkg/Bhyve/BhyveX64.fdf
index c62d5757092e..282586fa81ec 100644
--- a/OvmfPkg/Bhyve/BhyveX64.fdf
+++ b/OvmfPkg/Bhyve/BhyveX64.fdf
@@ -207,6 +207,7 @@ [FV.DXEFV]
 INF  UefiCpuPkg/CpuIo2Dxe/CpuIo2Dxe.inf
 INF  UefiCpuPkg/CpuDxe/CpuDxe.inf
 INF  PcAtChipsetPkg/HpetTimerDxe/HpetTimerDxe.inf
+INF  OvmfPkg/IncompatiblePciDeviceSupportDxe/IncompatiblePciDeviceSupport.inf
 INF  OvmfPkg/PciHotPlugInitDxe/PciHotPlugInit.inf
 INF  MdeModulePkg/Bus/Pci/PciHostBridgeDxe/PciHostBridgeDxe.inf
 INF  MdeModulePkg/Bus/Pci/PciBusDxe/PciBusDxe.inf
-- 
2.41.0

[PATCH v2 3/3] OvmfPkg/BhyvePkg: enable bus enumeration

[Corvin Köhne]

bhyve supports adding a ROM to PCI devices. It was added to support GPU
passthrough of dedicated AMD GPUs. At the moment, this ROM file is
mostly useless as it's not shadowed and executed by firmware. Change
that by enabling bus enumeration.

Signed-off-by: Corvin Köhne <corvink@FreeBSD.org>
Acked-by: Peter Grehan <grehan@freebsd.org>
Cc: Ard Biesheuvel <ardb+tianocore@kernel.org>
Cc: Jiewen Yao <jiewen.yao@intel.com>
Cc: Jordan Justen <jordan.l.justen@intel.com>
Cc: Gerd Hoffmann <kraxel@redhat.com>
Cc: Rebecca Cran <rebecca@bsdio.com>
---
 OvmfPkg/Bhyve/BhyveX64.dsc | 1 -
 1 file changed, 1 deletion(-)

diff --git a/OvmfPkg/Bhyve/BhyveX64.dsc b/OvmfPkg/Bhyve/BhyveX64.dsc
index 873eec60906e..82c60ace1bbd 100644
--- a/OvmfPkg/Bhyve/BhyveX64.dsc
+++ b/OvmfPkg/Bhyve/BhyveX64.dsc
@@ -428,7 +428,6 @@ [PcdsFeatureFlag]
 !endif
 
 [PcdsFixedAtBuild]
-  gEfiMdeModulePkgTokenSpaceGuid.PcdPciDisableBusEnumeration|TRUE
   gEfiMdeModulePkgTokenSpaceGuid.PcdStatusCodeUseSerial|FALSE
   gEfiMdeModulePkgTokenSpaceGuid.PcdStatusCodeUseMemory|TRUE
   gEfiMdeModulePkgTokenSpaceGuid.PcdStatusCodeMemorySize|1
-- 
2.41.0

Re: [edk2-devel] [PATCH v2 0/3] OvmfPkg/Bhyve: enable bus enumeration

[Corvin Köhne]

[-- Attachment #1: Type: text/plain, Size: 867 bytes --]

On Tue, 2023-07-11 at 09:16 +0200, Corvin Köhne wrote:
> CI: https://github.com/tianocore/edk2/pull/4543
> 
> Corvin Köhne (3):
>   Revert "OvmfPkg/Bhyve: consume PciHostBridgeLibScan"
>   Revert "OvmfPkg/Bhyve: remove IncompatiblePciDeviceSupport DXE
> driver"
>   OvmfPkg/BhyvePkg: enable bus enumeration
> 
>  OvmfPkg/Bhyve/BhyveX64.dsc | 4 ++--
>  OvmfPkg/Bhyve/BhyveX64.fdf | 1 +
>  2 files changed, 3 insertions(+), 2 deletions(-)
> 

Ping


-- 
Kind regards,
Corvin


-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#107168): https://edk2.groups.io/g/devel/message/107168
Mute This Topic: https://groups.io/mt/100074281/7686176
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io]
-=-=-=-=-=-=-=-=-=-=-=-



[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 833 bytes --]

Re: [edk2-devel] [PATCH v2 0/3] OvmfPkg/Bhyve: enable bus enumeration

[Rebecca Cran]

For the series:


Reviewed-by: Rebecca Cran <rebecca@bsdio.com>


On 7/11/23 01:16, Corvin Köhne wrote:
> CI: https://github.com/tianocore/edk2/pull/4543
>
> Corvin Köhne (3):
>    Revert "OvmfPkg/Bhyve: consume PciHostBridgeLibScan"
>    Revert "OvmfPkg/Bhyve: remove IncompatiblePciDeviceSupport DXE driver"
>    OvmfPkg/BhyvePkg: enable bus enumeration
>
>   OvmfPkg/Bhyve/BhyveX64.dsc | 4 ++--
>   OvmfPkg/Bhyve/BhyveX64.fdf | 1 +
>   2 files changed, 3 insertions(+), 2 deletions(-)
>


-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#107384): https://edk2.groups.io/g/devel/message/107384
Mute This Topic: https://groups.io/mt/100074281/7686176
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io]
-=-=-=-=-=-=-=-=-=-=-=-

Re: [edk2-devel] [PATCH v2 0/3] OvmfPkg/Bhyve: enable bus enumeration

[Rebecca Cran]

Sorry for the delay! I started a new job recently and haven't had time 
for upstream EDK2 work.

I've created https://github.com/tianocore/edk2/pull/4698 and set the 
'push' label.


-- 
Rebecca Cran


On 7/24/23 04:34, Corvin Köhne wrote:
> On Tue, 2023-07-11 at 09:16 +0200, Corvin Köhne wrote:
>> CI: https://github.com/tianocore/edk2/pull/4543
>>
>> Corvin Köhne (3):
>>    Revert "OvmfPkg/Bhyve: consume PciHostBridgeLibScan"
>>    Revert "OvmfPkg/Bhyve: remove IncompatiblePciDeviceSupport DXE
>> driver"
>>    OvmfPkg/BhyvePkg: enable bus enumeration
>>
>>   OvmfPkg/Bhyve/BhyveX64.dsc | 4 ++--
>>   OvmfPkg/Bhyve/BhyveX64.fdf | 1 +
>>   2 files changed, 3 insertions(+), 2 deletions(-)
>>
> Ping
>
>


-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#107386): https://edk2.groups.io/g/devel/message/107386
Mute This Topic: https://groups.io/mt/100074281/7686176
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io]
-=-=-=-=-=-=-=-=-=-=-=-

Re: [edk2-devel] [PATCH v2 0/3] OvmfPkg/Bhyve: enable bus enumeration

[Ard Biesheuvel]

On Mon, 31 Jul 2023 at 02:46, Rebecca Cran <rebecca@bsdio.com> wrote:
>
> For the series:
>
>
> Reviewed-by: Rebecca Cran <rebecca@bsdio.com>
>

Thanks for taking care of this.

In the future, when you merge patches for a package that you don't
maintain, could you please mention this in a reply to the thread? That
way, I'll know I won't have to bother pulling the patches and trying
to apply them.

Thanks,
Ard.


-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#107397): https://edk2.groups.io/g/devel/message/107397
Mute This Topic: https://groups.io/mt/100074281/7686176
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io]
-=-=-=-=-=-=-=-=-=-=-=-

Re: [edk2-devel] [PATCH v2 0/3] OvmfPkg/Bhyve: enable bus enumeration

[Rebecca Cran]

Sorry, I'll try and remember to do that in future.


On 7/31/23 02:24, Ard Biesheuvel wrote:
> On Mon, 31 Jul 2023 at 02:46, Rebecca Cran <rebecca@bsdio.com> wrote:
>> For the series:
>>
>>
>> Reviewed-by: Rebecca Cran <rebecca@bsdio.com>
>>
> Thanks for taking care of this.
>
> In the future, when you merge patches for a package that you don't
> maintain, could you please mention this in a reply to the thread? That
> way, I'll know I won't have to bother pulling the patches and trying
> to apply them.
>
> Thanks,
> Ard.


-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#107402): https://edk2.groups.io/g/devel/message/107402
Mute This Topic: https://groups.io/mt/100074281/7686176
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io]
-=-=-=-=-=-=-=-=-=-=-=-