From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by spool.mail.gandi.net (Postfix) with ESMTPS id 61E5674003B for ; Wed, 16 Aug 2023 20:22:48 +0000 (UTC) DKIM-Signature: a=rsa-sha256; bh=qD8gdORbP+RF9gkQq+3C7OCUTAq/OJ28KXH93TVg01E=; c=relaxed/simple; d=groups.io; h=MIME-Version:References:In-Reply-To:From:Date:Message-ID:Subject:To:Cc:Precedence:List-Subscribe:List-Help:Sender:List-Id:Mailing-List:Delivered-To:Reply-To:List-Unsubscribe-Post:List-Unsubscribe:Content-Type; s=20140610; t=1692217366; v=1; b=Y1aQ//Io2lBGMJr1UvtN+enOphl4G8JrqtB1FpXi09zXsVrh0B/1T07K9uJ0sAtS78wFKKeI uIkHG9lI4dGN5l8dGDOHp80m3QSnn1RwGVZ0+OR52joRn32hC44qSeyScgAoyBNmPUq2fJPOu81 sN2U5KMwAL2TWHQfIj7ZotzQ= X-Received: by 127.0.0.2 with SMTP id zBSfYY7687511xuldOJDrsa7; Wed, 16 Aug 2023 13:22:46 -0700 X-Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by mx.groups.io with SMTP id smtpd.web10.171234.1692217366124689852 for ; Wed, 16 Aug 2023 13:22:46 -0700 X-Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 61D5863759 for ; Wed, 16 Aug 2023 20:22:45 +0000 (UTC) X-Received: by smtp.kernel.org (Postfix) with ESMTPSA id 33272C433CA for ; Wed, 16 Aug 2023 20:22:44 +0000 (UTC) X-Received: by mail-lj1-f169.google.com with SMTP id 38308e7fff4ca-2bb734a9081so2630741fa.1 for ; Wed, 16 Aug 2023 13:22:44 -0700 (PDT) X-Gm-Message-State: WVDioOUUMG1wjLww1sjiEAc8x7686176AA= X-Google-Smtp-Source: AGHT+IHR4d7do5o6PAQFs7HgPyRHG9yGgkjtBbiFiR6NaikXYAY6/WoIQNJuQYrX+P4tnUMiKjtGNKeSx3cYIqAuk3Y= X-Received: by 2002:a19:6404:0:b0:4fe:7e3d:de7 with SMTP id y4-20020a196404000000b004fe7e3d0de7mr202952lfb.29.1692217362151; Wed, 16 Aug 2023 13:22:42 -0700 (PDT) MIME-Version: 1.0 References: <20230816201146.1634348-1-michael.roth@amd.com> <20230816201146.1634348-3-michael.roth@amd.com> In-Reply-To: <20230816201146.1634348-3-michael.roth@amd.com> From: "Ard Biesheuvel" Date: Wed, 16 Aug 2023 22:22:30 +0200 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [edk2-devel] [PATCH 2/2] OvmfPkg/AmdSev: Disable PcdFirstTimeWakeUpAPsBySipti To: Michael Roth , "Liming Gao (Byosoft address)" Cc: devel@edk2.groups.io, YuanhaoXie , Tom Lendacky , Eric Dong , Ray Ni , Rahul Kumar , Gerd Hoffmann , Jiewen Yao , Jordan Justen , Erdem Aktas , James Bottomley , Min Xu Precedence: Bulk List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,ardb@kernel.org List-Unsubscribe-Post: List-Unsubscribe=One-Click List-Unsubscribe: Content-Type: text/plain; charset="UTF-8" X-GND-Status: LEGIT Authentication-Results: spool.mail.gandi.net; dkim=pass header.d=groups.io header.s=20140610 header.b="Y1aQ//Io"; dmarc=fail reason="SPF not aligned (relaxed), DKIM not aligned (relaxed)" header.from=kernel.org (policy=none); spf=pass (spool.mail.gandi.net: domain of bounce@groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce@groups.io On Wed, 16 Aug 2023 at 22:13, Michael Roth wrote: > > PcdFirstTimeWakeUpAPsBySipi was recently introduced to indicate when > the full INIT-SIPI-SIPI sequence can be skipped for AP bringup. It is > true by default, but needs to be disabled for QEMU/OVMF where early INIT > is not simulated. Commit 1d76560146 ("OvmfPkg: Disable > PcdFirstTimeWakeUpAPsBySipi.") added changes to disable it > by default for OvmfPkg, but a similar change was not made for the > AmdSev package. This breaks booting of SEV and SNP guests. > > Fix this defaulting PcdFirstTimeWakeUpAPsBySipi to false for AmdSev > package, as was previously done for OvmfPkg variants. > > Fixes: eaffa1d7ff ("UefiCpuPkg:Wake up APs after power-up or RESET through SIPI.") > Cc: YuanhaoXie > Cc: Tom Lendacky > Cc: Eric Dong > Cc: Ray Ni > Cc: Rahul Kumar > Cc: Gerd Hoffmann > Cc: Ard Biesheuvel > Cc: Jiewen Yao > Cc: Jordan Justen > Cc: Erdem Aktas > Cc: James Bottomley > Cc: Min Xu > Signed-off-by: Michael Roth Reviewed-by: Ard Biesheuvel Apologies for the oversight. This should be included in the upcoming stable tag. > --- > OvmfPkg/AmdSev/AmdSevX64.dsc | 8 ++++++++ > 1 file changed, 8 insertions(+) > > diff --git a/OvmfPkg/AmdSev/AmdSevX64.dsc b/OvmfPkg/AmdSev/AmdSevX64.dsc > index f43300a95e..cf058f6a05 100644 > --- a/OvmfPkg/AmdSev/AmdSevX64.dsc > +++ b/OvmfPkg/AmdSev/AmdSevX64.dsc > @@ -469,6 +469,14 @@ > gEfiMdeModulePkgTokenSpaceGuid.PcdConInConnectOnDemand|TRUE > gUefiOvmfPkgTokenSpaceGuid.PcdBootRestrictToFirmware|TRUE > > + # > + # INIT is now triggered before BIOS by ucode/hardware. In the OVMF > + # environment, QEMU lacks a simulation for the INIT process. > + # To address this, PcdFirstTimeWakeUpAPsBySipi set to FALSE to > + # broadcast INIT-SIPI-SIPI for the first time. > + # > + gUefiCpuPkgTokenSpaceGuid.PcdFirstTimeWakeUpAPsBySipi|FALSE > + > ################################################################################ > # > # Pcd Dynamic Section - list of all EDK II PCD Entries defined by this Platform > -- > 2.25.1 > -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#107808): https://edk2.groups.io/g/devel/message/107808 Mute This Topic: https://groups.io/mt/100787520/7686176 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io] -=-=-=-=-=-=-=-=-=-=-=-