From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by mx.groups.io with SMTP id smtpd.web10.6990.1685178479644019201 for ; Sat, 27 May 2023 02:07:59 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=KZ/UhnI0; spf=pass (domain: kernel.org, ip: 139.178.84.217, mailfrom: ardb@kernel.org) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id E5337618D5 for ; Sat, 27 May 2023 09:07:56 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 50800C433EF for ; Sat, 27 May 2023 09:07:56 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1685178476; bh=5+wiNrl3Zty067mYueoFXQBqDwLSjhLD72tUYRcxJXM=; h=References:In-Reply-To:From:Date:Subject:To:Cc:From; b=KZ/UhnI05JckObBOpS3wsTFDvqe7BbhhBBm+NhiWO2tnmQhfeR1+fRzi/2Ws6BhZ1 j103UCjKBXsI11ER01oEfF4pbPAzyQ53Yzc9qRLtU+m1gIfWHXeCxN/dDFXYDRbbIl u/Bgi/76Db9EDebZb5BJo+BddGMOToeCSB5y158Ds6te8h6SJOiVBFgfOirA/PhdH0 AvfAoXZpu85S7qURzpLRtiJt0bmhpH/KQ5rqA95/oiEQRw7RmkwFjlFVeRhSOcjcpI +klb/2DoWvvX3t3p8/omJiiYMr/0ERHBpMlXHaGJg1syKIHNQRBn/MsNGG/Zt9/vM/ N8G7xVcjjt26g== Received: by mail-lj1-f169.google.com with SMTP id 38308e7fff4ca-2af1822b710so16031091fa.1 for ; Sat, 27 May 2023 02:07:56 -0700 (PDT) X-Gm-Message-State: AC+VfDwg4LKdwDgOJ/4NFK0wUqJ5HQUUX0WpHfVZsaXtfltBcMFibxfd tqJBgEYTET+xJI2Nfge5A4tHuP0SM6MDSCCdNVc= X-Google-Smtp-Source: ACHHUZ5B/9U3RER0JR0G+A1oApb6eOnDtAhU9OVE5vpdeDQIid2tSJK7joT0R40sAN4GWX9Go42E6SdoQaKdzJAS5GQ= X-Received: by 2002:a2e:84c1:0:b0:2a7:748c:1eef with SMTP id q1-20020a2e84c1000000b002a7748c1eefmr1442139ljh.38.1685178474349; Sat, 27 May 2023 02:07:54 -0700 (PDT) MIME-Version: 1.0 References: <20230526231734.1445-1-michael.d.kinney@intel.com> In-Reply-To: <20230526231734.1445-1-michael.d.kinney@intel.com> From: "Ard Biesheuvel" Date: Sat, 27 May 2023 11:07:43 +0200 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [Patch 1/1] OvmfPkg/VirtIoSerialDxe: Update for VS2015x86 compatibility To: Michael D Kinney Cc: devel@edk2.groups.io, Ard Biesheuvel , Jiewen Yao , Jordan Justen , Gerd Hoffmann Content-Type: text/plain; charset="UTF-8" On Sat, 27 May 2023 at 01:17, Michael D Kinney wrote: > > Move initialization of local variable structure from declaration > to statements to fix VS2015x86 build break. > > Cc: Ard Biesheuvel > Cc: Jiewen Yao > Cc: Jordan Justen > Cc: Gerd Hoffmann > Signed-off-by: Michael D Kinney Reviewed-by: Ard Biesheuvel > --- > OvmfPkg/VirtioSerialDxe/VirtioSerial.c | 10 +++++----- > 1 file changed, 5 insertions(+), 5 deletions(-) > > diff --git a/OvmfPkg/VirtioSerialDxe/VirtioSerial.c b/OvmfPkg/VirtioSerialDxe/VirtioSerial.c > index bfb2b324eadf..df545c080e9d 100644 > --- a/OvmfPkg/VirtioSerialDxe/VirtioSerial.c > +++ b/OvmfPkg/VirtioSerialDxe/VirtioSerial.c > @@ -66,11 +66,11 @@ VirtioSerialTxControl ( > IN UINT16 Value > ) > { > - VIRTIO_SERIAL_CONTROL Control = { > - .Id = Id, > - .Event = Event, > - .Value = Value, > - }; > + VIRTIO_SERIAL_CONTROL Control; > + > + Control.Id = Id; > + Control.Event = Event; > + Control.Value = Value; > > DEBUG (( > DEBUG_INFO, > -- > 2.40.1.windows.1 >