From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mail.kernel.org (mail.kernel.org [198.145.29.99])
 by mx.groups.io with SMTP id smtpd.web10.179.1626456335357187966
 for <devel@edk2.groups.io>;
 Fri, 16 Jul 2021 10:25:35 -0700
Authentication-Results: mx.groups.io;
 dkim=pass header.i=@kernel.org header.s=k20201202 header.b=GWGx8t95;
 spf=pass (domain: kernel.org, ip: 198.145.29.99, mailfrom: ardb@kernel.org)
Received: by mail.kernel.org (Postfix) with ESMTPSA id 861AE61403
	for <devel@edk2.groups.io>; Fri, 16 Jul 2021 17:25:34 +0000 (UTC)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org;
	s=k20201202; t=1626456334;
	bh=yLelxgvi5nBwT5ecfwSaGpZ/IRjYMxGMy6a3VM+owl8=;
	h=References:In-Reply-To:From:Date:Subject:To:Cc:From;
	b=GWGx8t95PNIUXhIxDqo3UvfgKMirmhOExJnePZ2bRSJAxvXeTJvG+B8YTBu0JuDWY
	 GKnBCe1az6wQsz5QrX4dWHeMsaP1EJ6RCZgr5hKnKGwKhn9roICbGftC9ThqXO/Lr5
	 nkI0hHfEPVGNx05o1nKFduscYdLskSBZY66dnvgFf9Xe7VaTSB0rum4SsarpfCbucO
	 r+kOGqEn+moFc1bmcV7nzcJh8bHg54werCstwtxMCSY/AF8wPleLZ3yIaAjb+y8rY0
	 RMswjKrKKV/ByXYYg3dfUC67y7abL4IO7VyN9UFLYdfAOhlIscqt/dxSvrMUqWEcZU
	 GGTRvwX3Hx9xA==
Received: by mail-oo1-f49.google.com with SMTP id o3-20020a4a84c30000b0290251d599f19bso2598525oog.8
        for <devel@edk2.groups.io>; Fri, 16 Jul 2021 10:25:34 -0700 (PDT)
X-Gm-Message-State: AOAM532X+PvuTOs8HYzfyEkVWey+x9usl2q/HlNXint4jOxxjqu7Ppy3
	xbscUsCmEf7+fPus1IYXCcpD1JTm84yXwOfy9I8=
X-Google-Smtp-Source: ABdhPJxmelGA0ES5Essr06h6CCMoElVRakxa1DkDuhWu+Ug1x/gtXx8k77f1TTqWOmkBbiT82Mp3z4gHyr+tK8yTZLk=
X-Received: by 2002:a4a:8241:: with SMTP id t1mr8409993oog.13.1626456333904;
 Fri, 16 Jul 2021 10:25:33 -0700 (PDT)
MIME-Version: 1.0
References: <20210705100641.97166-1-jianyong.wu@arm.com>
In-Reply-To: <20210705100641.97166-1-jianyong.wu@arm.com>
From: "Ard Biesheuvel" <ardb@kernel.org>
Date: Fri, 16 Jul 2021 19:25:18 +0200
X-Gmail-Original-Message-ID: <CAMj1kXHsk=7jp7YVXkXPnM6Gv_PW4ZDvMOMgzFkKTMeWJxhzDA@mail.gmail.com>
Message-ID: <CAMj1kXHsk=7jp7YVXkXPnM6Gv_PW4ZDvMOMgzFkKTMeWJxhzDA@mail.gmail.com>
Subject: Re: [PATCH v4 0/3] Enable Cloud Hypervisor support in edk2
To: Jianyong Wu <jianyong.wu@arm.com>
Cc: edk2-devel-groups-io <devel@edk2.groups.io>, Laszlo Ersek <lersek@redhat.com>, 
	Sami Mujawar <sami.mujawar@arm.com>, Ard Biesheuvel <ardb+tianocore@kernel.org>, justin.he@arm.com
Content-Type: text/plain; charset="UTF-8"

On Mon, 5 Jul 2021 at 12:06, Jianyong Wu <jianyong.wu@arm.com> wrote:
>
> Cloud Hypervisor is an open source Virtual Machine Monitor (VMM) that
> runs on top of KVM. Cloud Hypervisor is implemented in Rust and is based
> on the rust-vmm crates. See [1] to find more.
>
> To support UEFI, Cloud Hypervisor is introduced here.
> There are 2 parts to be considered to do this enablement, that is:
>   1. specific ACPI service implementation compared with qemu, there is no
>      device like Fw-cfg, so we have no elegant way to get the RSDP address.
>      A specific ACPI implementation is introduced here.
>
>   2. build configuration file for Cloud Hypervisor
>
> Change log:
>
> v3 to v4:
>      (1) remove Tpm support in dsc file
>      (2) refine Acpi table install code base on Sami's comments in v3
>
> v2 to v3:
>      (1) reuse qemu's memory initialization lib as they are in nearly the same
> memory laout.
>      (2) split Acpi implemetation into PlatformHasAcpi and
> InstallAcpiTable.
>      (3) remove lots of dependencies from qemu like "*Fwcfg*" lib.
>      (4) lots of code cleanup work to let it more approach to edk2 code
> style.
>
> [1] https://github.com/cloud-hypervisor/cloud-hypervisor
>
> Jianyong Wu (3):
>   Acpi: reimplement PlatformHasAcpi for Cloud Hypervisor
>   Acpi: Install Acpi tables for Cloud hypervisor
>   ArmVirtCloudHv: support Cloud Hypervisor in edk2
>

Sami, any thoughts on this code?


>  ArmVirtPkg/ArmVirtPkg.dec                     |   6 +
>  ArmVirtPkg/ArmVirtCloudHv.dsc                 | 364 ++++++++++++++++++
>  ArmVirtPkg/ArmVirtCloudHv.fdf                 | 258 +++++++++++++
>  .../CloudHvAcpiPlatformDxe.inf                |  47 +++
>  .../CloudHvHasAcpiDtDxe.inf                   |  43 +++
>  .../CloudHvAcpiPlatformDxe/CloudHvAcpi.c      | 155 ++++++++
>  .../CloudHvHasAcpiDtDxe.c                     |  69 ++++
>  7 files changed, 942 insertions(+)
>  create mode 100644 ArmVirtPkg/ArmVirtCloudHv.dsc
>  create mode 100644 ArmVirtPkg/ArmVirtCloudHv.fdf
>  create mode 100644 ArmVirtPkg/CloudHvAcpiPlatformDxe/CloudHvAcpiPlatformDxe.inf
>  create mode 100644 ArmVirtPkg/CloudHvPlatformHasAcpiDtDxe/CloudHvHasAcpiDtDxe.inf
>  create mode 100644 ArmVirtPkg/CloudHvAcpiPlatformDxe/CloudHvAcpi.c
>  create mode 100644 ArmVirtPkg/CloudHvPlatformHasAcpiDtDxe/CloudHvHasAcpiDtDxe.c
>
> --
> 2.17.1
>