From: "Ard Biesheuvel" <ardb@kernel.org>
To: Pierre.Gondois@arm.com
Cc: devel@edk2.groups.io, Thomas Abraham <thomas.abraham@arm.com>,
Sami Mujawar <sami.mujawar@arm.com>
Subject: Re: [PATCH v2 1/1] Platform/Sgi: Use MmUnblockMemoryLib when SECURE_BOOT_ENABLE
Date: Thu, 15 Dec 2022 10:54:12 +0100 [thread overview]
Message-ID: <CAMj1kXHsn42EhN9unW=8kBrPeM3rMVUCJ5Nxc3Gf-angPbpUBQ@mail.gmail.com> (raw)
In-Reply-To: <20221215083448.1824815-1-Pierre.Gondois@arm.com>
On Thu, 15 Dec 2022 at 09:35, <Pierre.Gondois@arm.com> wrote:
>
> From: Pierre Gondois <pierre.gondois@arm.com>
>
> Building the RdV1 platform fails when only providing the
> '-D SECURE_BOOT_ENABLE' flag due to MmUnblockMemoryLib missing.
> There is only one MmUnblockMemoryLib implementation used,
> so unconditionally use this implementation.
>
> Signed-off-by: Pierre Gondois <Pierre.Gondois@arm.com>
> ---
>
> Notes:
> v2:
> - Instead of defining the library when SECURE_BOOT_ENABLE is defined,
> unconditionally include the library. [Ard]
>
Pushed as 425cce541517..20e07099d8f1, thanks.
> Platform/ARM/SgiPkg/SgiPlatform.dsc.inc | 2 --
> 1 file changed, 2 deletions(-)
>
> diff --git a/Platform/ARM/SgiPkg/SgiPlatform.dsc.inc b/Platform/ARM/SgiPkg/SgiPlatform.dsc.inc
> index 81764368a0b7..a21faa249b07 100644
> --- a/Platform/ARM/SgiPkg/SgiPlatform.dsc.inc
> +++ b/Platform/ARM/SgiPkg/SgiPlatform.dsc.inc
> @@ -38,9 +38,7 @@ [LibraryClasses.common]
> HobLib|MdePkg/Library/DxeHobLib/DxeHobLib.inf
> ResetSystemLib|ArmPkg/Library/ArmSmcPsciResetSystemLib/ArmSmcPsciResetSystemLib.inf
> TimerLib|ArmPkg/Library/ArmArchTimerLib/ArmArchTimerLib.inf
> -!if $(SECURE_BOOT_ENABLE) == TRUE
> MmUnblockMemoryLib|MdePkg/Library/MmUnblockMemoryLib/MmUnblockMemoryLibNull.inf
> -!endif
>
> # Virtio Support
> VirtioLib|OvmfPkg/Library/VirtioLib/VirtioLib.inf
> --
> 2.25.1
>
prev parent reply other threads:[~2022-12-15 9:54 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-12-15 8:34 [PATCH v2 1/1] Platform/Sgi: Use MmUnblockMemoryLib when SECURE_BOOT_ENABLE PierreGondois
2022-12-15 9:54 ` Ard Biesheuvel [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAMj1kXHsn42EhN9unW=8kBrPeM3rMVUCJ5Nxc3Gf-angPbpUBQ@mail.gmail.com' \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox