From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from ams.source.kernel.org (ams.source.kernel.org [145.40.68.75])
 by mx.groups.io with SMTP id smtpd.web11.130136.1671098068848166791
 for <devel@edk2.groups.io>;
 Thu, 15 Dec 2022 01:54:29 -0800
Authentication-Results: mx.groups.io;
 dkim=pass header.i=@kernel.org header.s=k20201202 header.b=GSIPIbHn;
 spf=pass (domain: kernel.org, ip: 145.40.68.75, mailfrom: ardb@kernel.org)
Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140])
	(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
	(No client certificate requested)
	by ams.source.kernel.org (Postfix) with ESMTPS id 0FDB2B81AFA
	for <devel@edk2.groups.io>; Thu, 15 Dec 2022 09:54:27 +0000 (UTC)
Received: by smtp.kernel.org (Postfix) with ESMTPSA id C8BBBC433F1
	for <devel@edk2.groups.io>; Thu, 15 Dec 2022 09:54:25 +0000 (UTC)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org;
	s=k20201202; t=1671098065;
	bh=Ur8ut0oBUBaXJKi32p+cwCp90a4WuHkOCQ7dKufW/Uc=;
	h=References:In-Reply-To:From:Date:Subject:To:Cc:From;
	b=GSIPIbHnmdQQQH5fUc89ztWQzPIDJRP7dy+J3b013a4GxIbu7XBYafBydoIz+F6xi
	 a2zWxdimib4Qj1yKs5Ih9xQfzc+afcnKtYm1PaPSVEASRafcSvWz6nO6j5Vqq2qodJ
	 sS2BPea4aXnP6EuiauWb9QhMviCAJm54nXjons4DMXYvd9XC4s86Ax+iLlRk7O4yz5
	 B1EyQBFvjXASIng668l4uv87SXiWTOmCjYEY9281X/8eODKW1z/iAli6hSnIyYSmAD
	 Jowd5QnbUgyhPaeIPuBIGdPZgGALBauDkWThS1ph68I+pEyckQKM3YulBxuSgh5OCE
	 /JAgTkfxZ0fmA==
Received: by mail-lj1-f173.google.com with SMTP id x11so9381578ljh.7
        for <devel@edk2.groups.io>; Thu, 15 Dec 2022 01:54:25 -0800 (PST)
X-Gm-Message-State: ANoB5pkL+ucFT7I/Aa20NxFKO/98/8xu4H6o+Fi8csvWAKbqRvJ01QLJ
	TxJVj0QFkjJ+8Xis2C8q277gTw8hSYiXqR+gW2I=
X-Google-Smtp-Source: AA0mqf5wkoreWUBNx/Q9OXqmgMwtwF1dtqCoTx0QCB0TDbK+sd+KM8zXXhPXCkqbtt2hAw9T2ZrywVCgGyiOyo6B0rQ=
X-Received: by 2002:a05:651c:484:b0:26f:bcaf:a1c7 with SMTP id
 s4-20020a05651c048400b0026fbcafa1c7mr23597581ljc.69.1671098063745; Thu, 15
 Dec 2022 01:54:23 -0800 (PST)
MIME-Version: 1.0
References: <20221215083448.1824815-1-Pierre.Gondois@arm.com>
In-Reply-To: <20221215083448.1824815-1-Pierre.Gondois@arm.com>
From: "Ard Biesheuvel" <ardb@kernel.org>
Date: Thu, 15 Dec 2022 10:54:12 +0100
X-Gmail-Original-Message-ID: <CAMj1kXHsn42EhN9unW=8kBrPeM3rMVUCJ5Nxc3Gf-angPbpUBQ@mail.gmail.com>
Message-ID: <CAMj1kXHsn42EhN9unW=8kBrPeM3rMVUCJ5Nxc3Gf-angPbpUBQ@mail.gmail.com>
Subject: Re: [PATCH v2 1/1] Platform/Sgi: Use MmUnblockMemoryLib when SECURE_BOOT_ENABLE
To: Pierre.Gondois@arm.com
Cc: devel@edk2.groups.io, Thomas Abraham <thomas.abraham@arm.com>, 
	Sami Mujawar <sami.mujawar@arm.com>
Content-Type: text/plain; charset="UTF-8"

On Thu, 15 Dec 2022 at 09:35, <Pierre.Gondois@arm.com> wrote:
>
> From: Pierre Gondois <pierre.gondois@arm.com>
>
> Building the RdV1 platform fails when only providing the
> '-D SECURE_BOOT_ENABLE' flag due to MmUnblockMemoryLib missing.
> There is only one MmUnblockMemoryLib implementation used,
> so unconditionally use this implementation.
>
> Signed-off-by: Pierre Gondois <Pierre.Gondois@arm.com>
> ---
>
> Notes:
>     v2:
>      - Instead of defining the library when SECURE_BOOT_ENABLE is defined,
>        unconditionally include the library. [Ard]
>

Pushed as 425cce541517..20e07099d8f1, thanks.

>  Platform/ARM/SgiPkg/SgiPlatform.dsc.inc | 2 --
>  1 file changed, 2 deletions(-)
>
> diff --git a/Platform/ARM/SgiPkg/SgiPlatform.dsc.inc b/Platform/ARM/SgiPkg/SgiPlatform.dsc.inc
> index 81764368a0b7..a21faa249b07 100644
> --- a/Platform/ARM/SgiPkg/SgiPlatform.dsc.inc
> +++ b/Platform/ARM/SgiPkg/SgiPlatform.dsc.inc
> @@ -38,9 +38,7 @@ [LibraryClasses.common]
>    HobLib|MdePkg/Library/DxeHobLib/DxeHobLib.inf
>    ResetSystemLib|ArmPkg/Library/ArmSmcPsciResetSystemLib/ArmSmcPsciResetSystemLib.inf
>    TimerLib|ArmPkg/Library/ArmArchTimerLib/ArmArchTimerLib.inf
> -!if $(SECURE_BOOT_ENABLE) == TRUE
>    MmUnblockMemoryLib|MdePkg/Library/MmUnblockMemoryLib/MmUnblockMemoryLibNull.inf
> -!endif
>
>    # Virtio Support
>    VirtioLib|OvmfPkg/Library/VirtioLib/VirtioLib.inf
> --
> 2.25.1
>